Mike Percy has abandoned this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Abandoned
With boost now part of thirdparty, it doesn't look like there is a strong case
for reimplementing opti
Todd Lipcon has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
yea, ASAN does insert poisoning between variables on the stack:
http://llvm.org/docs/doxy
Mike Percy has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
> Also not sure of the purpose of the extra red zones (ASAN
> would already insert those a
Todd Lipcon has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
The boost implementation already has ASSERTs for accessing it while not
initialized, so t
Mike Percy has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
> I would like some careful eyes on this before we merge it, as the
> move semantics relat
Mike Percy has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
> Well, the call sites are going to stay the same, but we're taking
> on a few hundred line
Todd Lipcon has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
> This is meant to completely replace our usage of boost::optional so it should
> be net
Mike Percy has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3512/1/src/kudu/util/optional.h
File src/k
Adar Dembo has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
> I don't see the purpose of taking on this extra code. Code's a
> liability, not an asset
Adar Dembo has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
(3 comments)
I only skimmed this; I think a real review requires a level of C++ knowledge
Todd Lipcon has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1: Code-Review-1
I don't see the purpose of taking on this extra code. Code's a liability, no
Kudu Jenkins has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2052/
--
To view, visit http://gerr
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3512
to review the following change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Implement k
13 matches
Mail list logo
