---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36916/
---
Review request for mesos, Joerg Schad and Till Toenshoff.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36914/#review93461
---
Ship it!
Ship It!
- Till Toenshoff
On July 29, 2015, 2:45 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---
(Updated July 29, 2015, 5:07 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36429/#review93457
---
src/slave/containerizer/isolators/filesystem/linux.cpp (line 238)
On July 29, 2015, 3:34 p.m., Bernd Mathiske wrote:
src/tests/fetcher_cache_tests.cpp, line 1474
https://reviews.apache.org/r/36773/diff/7/?file=1024458#file1024458line1474
const Path
Jan Schlicht wrote:
Path::basename() is not marked const (which it probably should), hence
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36909/#review93472
---
Patch looks great!
Reviews applied: [36909]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/
---
(Updated July 29, 2015, 4:59 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/
---
(Updated July 29, 2015, 6:34 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36916/#review93473
---
Ship it!
Ship It!
- Joerg Schad
On July 29, 2015, 4:58 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36912/#review93474
---
Ship it!
Ship It!
- haosdent huang
On July 29, 2015, 2:11 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36821/
---
(Updated July 29, 2015, 5:08 p.m.)
Review request for mesos, Adam B and
On July 29, 2015, 1:01 p.m., Alexander Rukletsov wrote:
include/mesos/mesos.proto, line 399
https://reviews.apache.org/r/36663/diff/5/?file=1021578#file1021578line399
`ip` and `port` are required, while `address` is optional. Is it
intentional / doesn't it introduce a pitfall?
On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, lines 515-516
https://reviews.apache.org/r/35702/diff/9/?file=994080#file994080line515
It looks like we actually have the role, but it's buried in resources.
Do you envision having resources collection
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review93456
---
src/master/http.cpp (line 524)
On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, lines 515-516
https://reviews.apache.org/r/35702/diff/9/?file=994080#file994080line515
It looks like we actually have the role, but it's buried in resources.
Do you envision having resources collection
On July 29, 2015, 5:43 p.m., Vinod Kone wrote:
Aah. Good catch. Thank you!
You are welcome. :-)
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36909/#review93482
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36919/
---
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36909/#review93509
---
src/tests/mesos.hpp (line 317)
On July 29, 2015, 8 p.m., Vinod Kone wrote:
src/tests/master_tests.cpp, line 2170
https://reviews.apache.org/r/36807/diff/2/?file=1024091#file1024091line2170
new line.
would you like me to push another revision or will you do this yourself when
committing?
I'm easy either way,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36822/#review93522
---
Ship it!
Ship It!
- Benjamin Hindman
On July 27, 2015, 8:18
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36920/
---
Review request for mesos, haosdent huang and Vinod Kone.
Bugs: MESOS-3168
On July 29, 2015, 8 p.m., Vinod Kone wrote:
src/tests/master_tests.cpp, line 2170
https://reviews.apache.org/r/36807/diff/2/?file=1024091#file1024091line2170
new line.
Marco Massenzio wrote:
would you like me to push another revision or will you do this yourself
when
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/
---
(Updated July 29, 2015, 8:54 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93515
---
forgot to rebase?
- Vinod Kone
On July 29, 2015, 8:54 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36920/#review93510
---
Ship it!
- Vinod Kone
On July 29, 2015, 8:39 p.m., Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36625/
---
(Updated July 29, 2015, 3:01 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36900/
---
(Updated July 29, 2015, 9:07 p.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36821/#review93520
---
Patch looks great!
Reviews applied: [36821]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36919/
---
(Updated July 29, 2015, 7:43 p.m.)
Review request for mesos, Anand Mazumdar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review93481
---
include/mesos/mesos.proto (line 1213)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36821/
---
(Updated July 29, 2015, 5:40 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36916/#review93500
---
Patch looks great!
Reviews applied: [36916]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36900/#review93374
---
src/master/contender.cpp (line 239)
On July 29, 2015, 7:44 p.m., Vinod Kone wrote:
Thanks, I have the impression you were looking at an earlier revision, but no
matter - the one I'll be uploading in a second will reflect your comments.
- Marco
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36909/#review93482
---
Ship it!
Aah. Good catch. Thank you!
- Vinod Kone
On July 29,
On July 29, 2015, 7:12 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 2128-2159
https://reviews.apache.org/r/36720/diff/3/?file=1021871#file1021871line2128
Any reason you're skipping validation (authorization) of the framework?
Looks like we should pull out the pid specific
On July 28, 2015, 7:46 a.m., Alexander Rojas wrote:
Thank you for your review. I updated the code, could you reivew it again?
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93496
---
Patch looks great!
Reviews applied: [36908]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93505
---
Ship it!
src/tests/master_tests.cpp (line 2170)
On July 28, 2015, 8:05 a.m., Adam B wrote:
src/health-check/main.cpp, line 243
https://reviews.apache.org/r/36816/diff/1/?file=1021956#file1021956line243
Maybe we should add `http.protocol()` in case the user wants https? Or
`http.ssl` like BenH suggested. Would we ever want
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
---
(Updated July 29, 2015, 6:08 p.m.)
Review request for mesos and Adam B.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/#review93499
---
Looks like this needs a rebase? Wasn't able to get it applied
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36919/#review93504
---
Ship it!
nice cleanup!
src/master/master.cpp (lines 1697 - 1698)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36920/#review93525
---
Bad patch!
Reviews applied: [36920]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36865/
---
(Updated July 29, 2015, 4:51 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36930/
---
Review request for mesos, Chi Zhang and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36625/
---
(Updated July 29, 2015, 4:18 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36627/
---
(Updated July 29, 2015, 4:11 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36929/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36927/#review93532
---
src/master/master.cpp (lines 1574 - 1576)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36927/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36824/#review93528
---
Ship it!
src/tests/containerizer/ns_tests.cpp (line 149)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36827/#review93529
---
Ship it!
Ship It!
- Benjamin Hindman
On July 27, 2015, 9:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36823/#review93527
---
Ship it!
src/tests/containerizer/cgroups_tests.cpp (line 814)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review93530
---
Patch looks great!
Reviews applied: [36913]
All tests passed.
-
On July 29, 2015, 8:40 p.m., Alexander Rukletsov wrote:
src/tests/mesos.hpp, line 317
https://reviews.apache.org/r/36909/diff/3/?file=1024461#file1024461line317
Shouldn't it come after network shutdown?
https://reviews.apache.org/r/36920/
sorry, my fault
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36865/#review93542
---
Patch looks great!
Reviews applied: [36864, 36865]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
---
(Updated July 30, 2015, 2:47 a.m.)
Review request for mesos and Adam B.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36930/#review93548
---
Patch looks great!
Reviews applied: [36929, 36930]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36927/#review93549
---
Patch looks great!
Reviews applied: [36927]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36920/#review93540
---
Ship it!
Ship It!
- haosdent huang
On July 29, 2015, 8:39 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/
---
(Updated July 30, 2015, 2:49 a.m.)
Review request for mesos, Benjamin Hindman
On July 27, 2015, 11:38 p.m., Ben Mahler wrote:
src/master/master.cpp, line 1850
https://reviews.apache.org/r/32961/diff/4/?file=927192#file927192line1850
Anand discovered that we shouldn't be calling this in the
FrameworkErrorMessage case below, where we drop the message. Looks
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated July 29, 2015, 7:16 a.m.)
Review request for mesos, Adam B and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/
---
(Updated July 29, 2015, 7:44 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated July 29, 2015, 7:18 a.m.)
Review request for mesos, Adam B and Niklas
On July 28, 2015, 5:58 a.m., Adam B wrote:
Did you test this with java enabled as well? What about without
`--with-protobuf=`? All four combinations still need to compile pass the
unit tests.
haosdent huang wrote:
I only run it with --disable-java and --with_protobuf, let me
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/
---
(Updated July 29, 2015, 7:43 a.m.)
Review request for mesos and Benjamin
On July 27, 2015, 5:58 p.m., Marco Massenzio wrote:
thanks for doing this!
(this may also fix a long-standing issue of mine:
https://issues.apache.org/jira/browse/MESOS-2337 - could you please take a
look?)
Only a few minor nits about formatting and stuff, then I think this is
On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, lines 1325-1332
https://reviews.apache.org/r/35983/diff/1/?file=994085#file994085line1325
Why do we need to recover resources for unreserve?
Michael Park wrote:
If reserved resources are offered, we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/
---
(Updated July 29, 2015, 1:52 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36909/
---
Review request for mesos.
Repository: mesos
Description
---
Add
On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote:
src/master/master.cpp, line 749
https://reviews.apache.org/r/35702/diff/6/?file=989449#file989449line749
I think reserve is too abstract and may collide with future actions
(think quota). How about `/dynamic/reserve`?
On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, lines 515-516
https://reviews.apache.org/r/35702/diff/9/?file=994080#file994080line515
It looks like we actually have the role, but it's buried in resources.
Do you envision having resources collection
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93430
---
src/tests/fetcher_cache_tests.cpp (line 1460)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93438
---
Ship it!
Ship It!
- Joerg Schad
On July 29, 2015, 11:52 a.m.,
On July 29, 2015, 12:21 p.m., Till Toenshoff wrote:
src/Makefile.am, line 261
https://reviews.apache.org/r/36908/diff/1/?file=1024447#file1024447line261
This line looks too long.
Till Toenshoff wrote:
Seems we actually tolerate this - feel free to drop this issue.
I was
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/
---
(Updated July 29, 2015, 1:11 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36910/
---
Review request for mesos.
Repository: mesos
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/
---
(Updated July 29, 2015, 2:59 p.m.)
Review request for mesos, Bernd Mathiske
On July 29, 2015, 12:21 p.m., Till Toenshoff wrote:
src/Makefile.am, line 261
https://reviews.apache.org/r/36908/diff/1/?file=1024447#file1024447line261
This line looks too long.
Seems we actually tolerate this - feel free to drop this issue.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/#review93441
---
include/mesos/mesos.proto (line 399)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36910/
---
(Updated July 29, 2015, 1:41 p.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review93550
---
Patch looks great!
Reviews applied: [36816]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36627/
---
(Updated July 29, 2015, 4:14 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36900/#review93533
---
Patch looks great!
Reviews applied: [36900]
All tests passed.
-
On July 30, 2015, 12:49 a.m., Vinod Kone wrote:
src/master/master.cpp, lines 1757-1779
https://reviews.apache.org/r/36927/diff/1/?file=1024921#file1024921line1757
checking validationError.isNone() in each if statement looks a bit
weird. how about doing these in an else if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---
(Updated July 29, 2015, 3:04 p.m.)
Review request for mesos and Alexander
On July 29, 2015, 3:34 p.m., Bernd Mathiske wrote:
src/tests/fetcher_cache_tests.cpp, line 1474
https://reviews.apache.org/r/36773/diff/7/?file=1024458#file1024458line1474
const Path
Jan Schlicht wrote:
Path::basename() is not marked const (which it probably should), hence
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36909/
---
(Updated July 29, 2015, 1:56 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/
---
(Updated July 29, 2015, 3:59 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36909/
---
(Updated July 29, 2015, 1:53 p.m.)
Review request for mesos.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36909/
---
(Updated July 29, 2015, 1:53 p.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93447
---
src/tests/fetcher_cache_tests.cpp (line 1474)
On July 29, 2015, 3:34 p.m., Bernd Mathiske wrote:
src/tests/fetcher_cache_tests.cpp, line 1474
https://reviews.apache.org/r/36773/diff/7/?file=1024458#file1024458line1474
const Path
Path::basename() is not marked const (which it probably should), hence we have
to iterate over
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36912/
---
Review request for mesos.
Bugs: MESOS-3172
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93445
---
include/mesos/master/quota.hpp (lines 19 - 20)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36911/
---
Review request for mesos, Marco Massenzio and Till Toenshoff.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93443
---
docs/fetcher-cache-internals.md (line 107)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/#review93444
---
Ship it!
Ship It!
- Bernd Mathiske
On July 29, 2015, 6:11 a.m.,
100 matches
Mail list logo
