Re: Review Request 37703: Add docker exec command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/ --- (Updated Sept. 9, 2015, 9:15 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38197: Increment a metric when master drop a message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38197/#review98152 --- Patch looks great! Reviews applied: [38197] All tests passed. -

Re: Review Request 38201: [MESOS-1187] precision errors with allocation calculations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38201/#review98164 --- Patch looks great! Reviews applied: [38201] All tests passed. -

Re: Review Request 37703: Add docker exec command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review98168 --- Patch looks great! Reviews applied: [37703] All tests passed. -

Re: Review Request 38160: Documented how to expedite event firing.

> On Sept. 8, 2015, 3:44 p.m., Guangya Liu wrote: > > docs/mesos-testing-patterns.md, line 10 > > > > > > What does "Naïve" means? > > haosdent huang wrote: > Naïve waiting means just waiting until timeout.

Re: Review Request 38160: Documented how to expedite event firing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/ --- (Updated Sept. 9, 2015, 2:28 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/ --- (Updated Sept. 9, 2015, 2:27 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

> On Sept. 8, 2015, 2:30 p.m., Bernd Mathiske wrote: > > src/tests/fault_tolerance_tests.cpp, line 705 > > > > > > s/re-/ > > s/retry/ Let's keep "retry" for clarity (we send a second registration request). -

Re: Review Request 38160: Documented how to expedite event firing.

> On Sept. 8, 2015, 2:34 p.m., Bernd Mathiske wrote: > > docs/mesos-testing-patterns.md, line 55 > > > > > > s/re-/ Good catch, thanks! - Alexander ---

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/#review98181 --- Ship it! Ship It! - Qian Zhang On Sept. 3, 2015, 3:32 a.m.,

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review98186 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m.,

Re: Review Request 38046: Replace hard-coded reap interval with a constant

> On 九月 7, 2015, 4:22 p.m., Alexander Rukletsov wrote: > > I would encourage you to check the reaping concept in > > `libprocess/reap.{hpp|cpp}`. Comments in those files should be sufficient > > to understand what's reaping and how we use it in Mesos. Though some of the > > changes you've

Re: Review Request 38046: Replace hard-coded reap interval with a constant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/#review98193 --- Looks like we are converging here. One unclear thing I would like

Re: Review Request 38046: Replace hard-coded reap interval with a constant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/ --- (Updated 九月 9, 2015, 4:09 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/ --- (Updated Sept. 9, 2015, 2:46 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 38154: Switched to type traits for checking whether a type is a protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38154/ --- (Updated Sept. 9, 2015, 2:45 p.m.) Review request for mesos and Michael Park.

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37827/ --- (Updated Sept. 9, 2015, 2:46 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/#review98191 --- Ship it! Ship It! - Guangya Liu On 九月 9, 2015, 2:27 p.m.,

Re: Review Request 38168: Replace hard-coded reap interval with a constant for 3rdparty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38168/ --- (Updated 九月 9, 2015, 2:59 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 38046: Replace hard-coded reap interval with a constant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/ --- (Updated 九月 9, 2015, 3:01 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review98187 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m.,

Re: Review Request 38046: Replace hard-coded reap interval with a constant

> On Sept. 7, 2015, 4:22 p.m., Alexander Rukletsov wrote: > > I would encourage you to check the reaping concept in > > `libprocess/reap.{hpp|cpp}`. Comments in those files should be sufficient > > to understand what's reaping and how we use it in Mesos. Though some of the > > changes you've

Re: Review Request 38168: Replace hard-coded reap interval with a constant for 3rdparty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38168/#review98190 --- This looks good, thanks! Have you run `make distcheck`? I believe

Re: Review Request 38168: Replace hard-coded reap interval with a constant for 3rdparty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38168/#review98198 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 9, 2015, 2:59

Re: Review Request 38160: Documented how to expedite event firing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/#review98204 --- Patch looks great! Reviews applied: [38161, 38160] All tests

Re: Review Request 38158: Refactored Value::Ranges coalesce().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review98200 --- include/mesos/values.hpp (line 21)

Re: Review Request 38046: Replace hard-coded reap interval with a constant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/#review98205 --- src/tests/gc_tests.cpp (lines 805 - 807)

Re: Review Request 38214: Add a REASON for TASK_LOST with hard slave drain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38214/#review98208 --- Patch looks great! Reviews applied: [38214] All tests passed. -

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35984/ --- (Updated Sept. 9, 2015, 10:12 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37445: Fix typos in style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37445/#review98306 --- Ship it! Ship It! - Niklas Nielsen On Aug. 13, 2015, 2:58 p.m.,

Re: Review Request 38149: Add message_call_received metrics for master

> On 九月 9, 2015, 5:37 p.m., Vinod Kone wrote: > > What's the use case for this metric? For old style messages, we had per > > framework "messages_received" because it was used for rate limiting. I see there is a "// TODO(vinod): Add metrics for calls." in comments and also adding this metrics

Re: Review Request 38233: os: add swap information to memory().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38233/#review98307 --- 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp

Review Request 38239: Moved appc.{hpp|cpp} into slave/containerizer/provisioners/appc/ folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38239/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/ --- (Updated Sept. 9, 2015, 3:20 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 38030: [2/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38030/ --- (Updated Sept. 9, 2015, 3:20 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 38074: Calculate schedule latency with trace events

> On Sept. 5, 2015, 2:31 a.m., Guangya Liu wrote: > > src/slave/flags.cpp, line 306 > > > > > > Interval between which two values? Interval between two sched sampling. Same as perf events sampling. > On Sept. 5,

Re: Review Request 38028: [1/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38028/ --- (Updated Sept. 9, 2015, 3:20 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

> On Sept. 9, 2015, 3:24 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, lines 103-110 > > > > > > Let's make this overlapped storage private and add accessors. We

Re: Review Request 37824: mesos: Updates for google-glog upgrade to 0.3.4

> On Aug. 27, 2015, 1:27 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [37823] > > > > Failed command: ./support/apply-review.sh -n -r 37823 > > > > Error: > > 2015-08-27 20:25:09 URL:https://reviews.apache.org/r/37823/diff/raw/ > > [9017/9017] -> "37823.patch" [1] >

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35984/ --- (Updated Sept. 9, 2015, 10:27 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/#review98301 --- Ship it! Minor nits

Re: Review Request 38137: Added Docker provisioner and local store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review98247 --- First pass. Haven't looked at LocalStore and MetadataManager in

Re: Review Request 38239: Moved appc.{hpp|cpp} into slave/containerizer/provisioners/appc/ folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38239/#review98321 --- src/Makefile.am (line 485)

Re: Review Request 38240: Renamed appc_backend flag to appc_provisioner_backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38240/#review98322 --- Ship it! Ship It! - Jie Yu On Sept. 10, 2015, 12:28 a.m., Jiang

Review Request 38240: Renamed appc_backend flag to appc_provisioner_backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38240/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.

> On Aug. 26, 2015, 6:33 a.m., Jie Yu wrote: > > src/tests/reservation_endpoints_tests.cpp, line 109 > > > > > > Are we allowed to use cxx11 raw string literals now? This is definitely > > better! I found out

Re: Review Request 38028: [1/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38028/#review98281 --- Ship it! - Joris Van Remoortere On Sept. 9, 2015, 10:20 p.m.,

Re: Review Request 38030: [2/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38030/#review98279 --- Ship it! - Joris Van Remoortere On Sept. 9, 2015, 10:20 p.m.,

Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38077/#review98288 --- Ship it! - Joris Van Remoortere On Sept. 9, 2015, 10:20 p.m.,

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review98308 --- Patch looks great! Reviews applied: [37871, 37427, 37773] All

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/ --- (Updated Sept. 9, 2015, 11:47 p.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review98312 --- docs/persistent-volume.md (line 227)

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review98313 --- src/slave/containerizer/provisioners/docker/registry_client.hpp

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/#review98293 --- 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 8, 2015, 9:44 p.m., Joseph Wu wrote: > > Just a bit more cleanup, and I think this would be good to go. > > > > If possible, you should coordinate with Alex Clemmer to make sure this > > change doesn't conflict/break what he's working on > > (https://reviews.apache.org/r/37019/). >

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 8, 2015, 9:44 p.m., Joseph Wu wrote: > > Just a bit more cleanup, and I think this would be good to go. > > > > If possible, you should coordinate with Alex Clemmer to make sure this > > change doesn't conflict/break what he's working on > > (https://reviews.apache.org/r/37019/). >

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review98326 --- most (if not all) comments here pertain to the unversioned

Re: Review Request 38234: Check if swap is enabled before running memory pressure related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38234/#review98330 --- Patch looks great! Reviews applied: [38233, 38234] All tests

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review98347 --- Patch looks great! Reviews applied: [37871, 37427, 37773] All

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/#review98348 --- 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp (line

Re: Review Request 37126: Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37126/#review98349 --- src/tests/reservation_endpoints_tests.cpp (lines 1026 - 1048)

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/ --- (Updated Sept. 10, 2015, 4:49 a.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/ --- (Updated Sept. 10, 2015, 4:53 a.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 38075: Added an Appc provisioner recovery test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38075/#review98353 --- Bad patch! Reviews applied: [38239] Failed command:

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/ --- (Updated Sept. 10, 2015, 5:07 a.m.) Review request for mesos. Bugs:

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

> On Sept. 9, 2015, 11:08 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 402 > > > > > > An alternative could have been: > > > > IP(prefix == 0 ? 0 :

Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38077/#review98333 --- Patch looks great! Reviews applied: [38028, 38030, 38031, 38076,

Re: Review Request 36125: Removing '.json' extension in master endpoints url

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/#review98335 --- Bad patch! Reviews applied: [36125] Failed command:

Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37176/#review98320 --- Ship it! src/master/allocator/sorter/drf/sorter.cpp (lines 173 -

Re: Review Request 37002: Introduced ACL protobuf definitions for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37002/#review98338 --- include/mesos/mesos.proto (line 1120)

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review98337 --- Ship it! include/mesos/maintenance/maintenance.hpp (line 31)

Re: Review Request 37125: Added 'Master::authorize' for Reserve/Unreserve.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37125/#review98340 --- In the description of this patch, you mentioned that "These are

Re: Review Request 37505: Fix broken health check in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/ --- (Updated Sept. 10, 2015, 2:20 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38158: Refactored Value::Ranges coalesce().

> On Sept. 10, 2015, 2:48 a.m., Till Toenshoff wrote: > > Looks really good to me, thanks Joerg. Just noticed the tests fail at a point that seems relevant to this code - please make sure you can recreate the buildbot failure and then fix it please :) - Till

Re: Review Request 38158: Refactored Value::Ranges coalesce().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review97983 --- Ship it! Looks really good to me, thanks Joerg.

Re: Review Request 37110: Enabled the Authorizer to handle Reserve/Unreserve ACLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37110/#review98339 --- src/tests/authorization_tests.cpp (line 397)

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/#review98341 --- Patch looks great! Reviews applied: [36126] All tests passed. -

Re: Review Request 38239: Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38239/ --- (Updated Sept. 9, 2015, 10:35 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 37427: Docker registry: adding TokenManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Sept. 9, 2015, 4:50 p.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/ --- (Updated Sept. 9, 2015, 4:50 p.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 37878: mesos: Replace volatile with std::atomic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37878/#review98212 --- Ship it! - Joris Van Remoortere On Sept. 9, 2015, 4:01 p.m.,

Re: Review Request 37877: libprocess: Replace GCC instrinsics and volatile with std::atomic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37877/#review98207 --- Ship it! 3rdparty/libprocess/include/process/metrics/counter.hpp

Re: Review Request 37876: stout: Replace GCC intrinsics with std::atomic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37876/#review98209 --- Ship it! Thanks for cleaning this all up Neil! Let's add some

Re: Review Request 38191: Removing unused Executor protobuf

> On Sept. 9, 2015, 5:33 p.m., Vinod Kone wrote: > > Why is this being removed? The plan is to have a v1/executor.proto and an > > unversioned executor.proto much like what we did with scheduler.proto. > > Anand Mazumdar wrote: > Vinod, Why can't the executor driver just directly use the

Review Request 38231: Fixed typos in modules documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38231/ --- Review request for mesos and Niklas Nielsen. Repository: mesos Description

Re: Review Request 38158: Refactored Value::Ranges coalesce().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 9, 2015, 8:48 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/#review98218 --- Ship it! Ship It! - haosdent huang On Aug. 28, 2015, 8:11 a.m.,

Re: Review Request 38154: Switched to type traits for checking whether a type is a protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38154/#review98220 --- Patch looks great! Reviews applied: [37826, 37827, 37830, 38154]

Re: Review Request 37877: libprocess: Replace GCC instrinsics and volatile with std::atomic.

> On Sept. 9, 2015, 5:16 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/process.cpp, lines 757-773 > > > > > > Would you agree that what is happening here is not immediately obvious? > > > >

Re: Review Request 38191: Removing unused Executor protobuf

> On Sept. 9, 2015, 5:33 p.m., Vinod Kone wrote: > > Why is this being removed? The plan is to have a v1/executor.proto and an > > unversioned executor.proto much like what we did with scheduler.proto. Vinod, Why can't the executor driver just directly use the V1 protobuf ? The unversioned

Re: Review Request 38137: Added Docker provisioner and local store

> On Sept. 9, 2015, 4:57 p.m., Jiang Yan Xu wrote: > > Could you take out the paths.hpp|cpp changes that have already been > > committed? done - Timothy --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38137: Added Docker provisioner and local store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- (Updated Sept. 9, 2015, 5:03 p.m.) Review request for mesos, Jojy Varghese,

Re: Review Request 38149: Add message_call_received metrics for master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38149/#review98225 --- What's the use case for this metric? For old style messages, we had

Re: Review Request 37773: Docker: Adding registry client.

> On Sept. 1, 2015, 9:35 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 359 > > > > > > Should we make sure somewhere that we encode or check the tag so that > >

Re: Review Request 38137: Added Docker provisioner and local store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review98213 --- Could you take out the paths.hpp|cpp changes that have already been

Re: Review Request 37876: stout: Replace GCC intrinsics with std::atomic.

> On Sept. 9, 2015, 5:16 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp, line 278 > > > > > > Some places in this review chain you use the provided typedefs

Re: Review Request 38191: Removing unused Executor protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38191/#review98222 --- Why is this being removed? The plan is to have a v1/executor.proto

Re: Review Request 38191: Removing unused Executor protobuf

> On Sept. 9, 2015, 5:33 p.m., Vinod Kone wrote: > > Why is this being removed? The plan is to have a v1/executor.proto and an > > unversioned executor.proto much like what we did with scheduler.proto. > > Anand Mazumdar wrote: > Vinod, Why can't the executor driver just directly use the

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/ --- (Updated Sept. 9, 2015, 8:08 p.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 38046: Replace hard-coded reap interval with a constant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/#review98245 --- Patch looks great! Reviews applied: [38046] All tests passed. -

  1   2   >