Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/ --- (Updated Nov. 27, 2015, 6:11 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 40756: Updated codebase to use `nonRevocable()` where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40756/#review108244 --- Patch looks great! Reviews applied: [40755, 40756] Passed

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/#review108240 --- Ship it! Ship It! - Avinash sridharan On Nov. 27, 2015, 1:44

Review Request 40777: Updated CHANGELOG for 0.26.0-rc2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40777/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description

Re: Review Request 40777: Updated CHANGELOG for 0.26.0-rc2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40777/#review108237 --- Ship it! Ship It! - Bernd Mathiske On Nov. 27, 2015, 8:02

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108214 --- Patch looks great! Reviews applied: [39590, 39591, 39592, 40445]

Re: Review Request 40755: Introduced filter for non-revocable resources.

> On Nov. 27, 2015, 8:34 a.m., Klaus Ma wrote: > > src/common/resources.cpp, line 775 > > > > > > Any UT cases for it? > > Alexander Rukletsov wrote: > What is a UT case? google points me to >

Re: Review Request 40755: Introduced filter for non-revocable resources.

> On Nov. 27, 2015, 12:54 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 779 > > > > > > 1) v1 should also be updated > > 2) Add a unit test for this new type? Good catch, thanks! Do we have a doc

Re: Review Request 40755: Introduced filter for non-revocable resources.

> On Nov. 27, 2015, 12:34 a.m., Klaus Ma wrote: > > src/common/resources.cpp, line 775 > > > > > > Any UT cases for it? > > Alexander Rukletsov wrote: > What is a UT case? google points me to >

Re: Review Request 40755: Introduced filter for non-revocable resources.

> On Nov. 27, 2015, 2:32 a.m., Michael Park wrote: > > src/common/resources.cpp, lines 777-778 > > > > > > I think it would be simpler if we were to just use a lambda here, what > > do you think? > > > >

Re: Review Request 40755: Introduced filter for non-revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40755/ --- (Updated Nov. 27, 2015, 2:46 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 40756: Updated codebase to use `nonRevocable()` where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40756/ --- (Updated Nov. 27, 2015, 2:48 p.m.) Review request for mesos and Michael Park.

Re: Review Request 40756: Updated codebase to use `nonRevocable()` where appropriate.

> On Nov. 27, 2015, 12:54 a.m., Guangya Liu wrote: > > I think we should also update > > https://github.com/apache/mesos/blob/master/src/common/http.cpp#L94 > > Guangya Liu wrote: > It is ok if only want to handle allocator part. Yeah, we can extend the scope of the update. - Alexander

Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/ --- Review request for mesos, Alexander Rukletsov, Avinash sridharan, Klaus Ma,

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/ --- (Updated Nov. 27, 2015, 5:44 a.m.) Review request for mesos, Alexander

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

> On Nov. 26, 2015, 6:20 a.m., Bernd Mathiske wrote: > > Ship It! An addendum intended to address the issues below is available here: https://reviews.apache.org/r/40767/ - Bernd --- This is an automatically generated e-mail. To reply,

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/#review108245 --- Patch looks great! Reviews applied: [40776] Passed command:

Re: Review Request 40756: Updated codebase to use `nonRevocable()` where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40756/#review108250 ---

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/ --- (Updated Nov. 28, 2015, 4:26 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39635/ --- (Updated Nov. 28, 2015, 4:26 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 39636: FreeBSD: Add basic support to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/ --- (Updated Nov. 28, 2015, 4:26 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 40754: Fixed flaky test (AvailableResourcesAfterRescinding).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40754/#review108247 --- Ship it! Fixed before committing.

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/#review108246 --- Ship it! Thanks for this Benjamin - really made sense to

Re: Review Request 40755: Introduced filter for non-revocable resources.

> On 十一月 27, 2015, 12:54 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 779 > > > > > > 1) v1 should also be updated > > 2) Add a unit test for this new type? > > Alexander Rukletsov wrote: >

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40620/ --- (Updated Nov. 28, 2015, 7:24 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated Nov. 28, 2015, 7:16 a.m.) Review request for mesos, Artem

Re: Review Request 40745: Cleaned up `RemoveSingleQuota` test and corrected formatting issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40745/ --- (Updated Nov. 27, 2015, 2:54 p.m.) Review request for mesos, Joerg Schad and

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/#review108226 --- Patch looks great! Reviews applied: [40767] Passed command:

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/#review108227 --- Ship it! Ship It! - Klaus Ma On Nov. 27, 2015, 9:44 p.m.,

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/#review108235 --- Ship it! Ship It! - Till Toenshoff On Nov. 27, 2015, 1:44

Re: Review Request 40755: Introduced filter for non-revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40755/#review108248 --- Ship it! Ship It! - Klaus Ma On Nov. 27, 2015, 10:46 p.m.,

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108054 --- support/mesos-license.py (line 29)

Re: Review Request 40755: Introduced filter for non-revocable resources.

> On Nov. 27, 2015, 12:34 a.m., Klaus Ma wrote: > > src/common/resources.cpp, line 775 > > > > > > Any UT cases for it? What is a UT case? google points me to

Re: Review Request 40445: Added linter for license headers in some file types.

> On Nov. 27, 2015, 8:48 a.m., Marco Massenzio wrote: > > support/mesos-license.py, line 30 > > > > > > is this dead code? please remove > > However, I'd like to see the log-level to be set to INFO by defaul and

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Nov. 27, 2015, 10:52 a.m.) Review request for mesos, Benjamin