Re: Review Request 41950: Cleaned up hierarchical allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review114937 --- Patch looks great! Reviews applied: [41936, 41937, 41947, 41948,

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 18, 2016, 6:48 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

> On 一月 15, 2016, 8:53 p.m., Timothy Chen wrote: > > src/tests/hook_tests.cpp, line 389 > > > > > > If hookFuture never becomes ready that this blocks forever right? > > AWAIT_READY has a timeout built in, and

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review114941 --- Patch looks great! Reviews applied: [42241] Passed command:

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 18, 2016, 6:50 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

> On Jan. 18, 2016, 2:12 a.m., Guangya Liu wrote: > > include/mesos/docker/spec.proto, line 33 > > > > > > Can you please also add some comments here? The tag can be either > > "latest" or the image version. Added.

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42235/ --- (Updated Jan. 18, 2016, 6:57 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41306/ --- (Updated Jan. 18, 2016, 3:19 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42235/ --- (Updated Jan. 18, 2016, 6:53 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- (Updated Jan. 18, 2016, 6:54 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42415: Added a roles field to FrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42415/#review114911 --- Patch looks great! Reviews applied: [42415] Passed command:

Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

> On Jan. 15, 2016, 8:23 p.m., Gilbert Song wrote: > > src/uri/fetchers/docker.cpp, line 575 > > > > > > Should we take `strings::tokenize(tokens[1], ",")` out and check its > > size? Nope. the contains check

Re: Review Request 41961: Added an HTTP decode response method.

> On Jan. 8, 2016, 9:31 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/src/http.cpp, line 707 > > > > > > Why don't we return the failure message? This is a limitation of the decoder currently. - Jie

Re: Review Request 41961: Added an HTTP decode response method.

> On Jan. 8, 2016, 9:30 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/src/http.cpp, line 714 > > > > > > Should we also comment that we only return the first response even if > > there are multiples? Changed

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

> On Jan. 13, 2016, 6:44 p.m., Gilbert Song wrote: > > src/docker/spec.cpp, line 62 > > > > > > We remove setting default tag as `latest`, is it because not necessary > > to set (if no tag is specified, it will pull

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

> On Jan. 13, 2016, 6:44 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp, lines > > 23-26 > > > > > > move them under `#include ` This file will be removed later.

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

> On Jan. 13, 2016, 6:44 p.m., Gilbert Song wrote: > > src/tests/containerizer/docker_spec_tests.cpp, line 22 > > > > > > ditto. We put library headers before mesos headers. - Jie

Review Request 42442: Made Docker::create return an Owned object instead of a raw pointer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42442/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Bugs:

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- (Updated Jan. 17, 2016, 9:53 p.m.) Review request for mesos, Ben Mahler,

Review Request 42444: Added an internet access test filter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42444/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy

Re: Review Request 42441: Decrease scheduler authenticate timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42441/#review114912 --- Patch looks great! Reviews applied: [42441] Passed command:

Re: Review Request 42236: Added a utility function to create https URI.

> On Jan. 13, 2016, 9:11 p.m., Timothy Chen wrote: > > src/uri/schemes/http.hpp, line 54 > > > > > > Should we provide the default port for https here? Nope. Tools (e.g., curl) will figure out the default. I don't

Re: Review Request 42236: Added a utility function to create https URI.

> On Jan. 13, 2016, 7:05 p.m., Gilbert Song wrote: > > LGTM! Just consider whether or not we should put it as `https.hpp` under > > `schemes` directory. I prefer not. https is http + ssl. Also, they might share some functions in the future. - Jie

Re: Review Request 41961: Added an HTTP decode response method.

> On Jan. 8, 2016, 9:30 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 718 > > > > > > bmahler might have different say on this, as he was proposing that the > > comment style

Re: Review Request 42237: Added docker image manifest parsing functions for strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42237/ --- (Updated Jan. 17, 2016, 9:51 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/ --- (Updated Jan. 17, 2016, 9:51 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42275: Added utility functions to create docker URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42275/ --- (Updated Jan. 17, 2016, 9:51 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41961: Added an HTTP decode response method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/ --- (Updated Jan. 17, 2016, 9:50 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42235/ --- (Updated Jan. 17, 2016, 9:50 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42236: Added a utility function to create https URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/ --- (Updated Jan. 17, 2016, 9:51 p.m.) Review request for mesos, Ben Mahler,

Review Request 42443: Reordered filters in test environment according to lexical order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42443/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Bugs:

Review Request 42441: Decrease scheduler authenticate timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42441/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jian Qiu. Bugs:

Re: Review Request 42068: Porting Mesos on ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42068/#review114910 --- We avoid making changes in 3rdparty and the Mesos code within the

Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/#review114922 --- Ship it! Ship It! - Gilbert Song On Jan. 13, 2016, 3:14 p.m.,

Re: Review Request 42069: Porting libprocess on ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42069/#review114926 --- Ship it! Ship It! - Zhiwei Chen On Jan. 18, 2016, 9:52 a.m.,

Re: Review Request 42068: Porting Mesos on ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42068/#review114927 --- Ship it! Ship It! - Zhiwei Chen On Jan. 18, 2016, 9:51 a.m.,

Re: Review Request 42068: Porting Mesos on ppc64le.

> On Jan. 18, 2016, 2:37 a.m., Artem Harutyunyan wrote: > > We avoid making changes in 3rdparty and the Mesos code within the same > > patch. Could you please break this patch into 2? Did you mean splitting the commit between mesos and libprocess? I saw we have a check in the pre-commit (see

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42235/#review114929 --- include/mesos/docker/spec.proto (line 33)

Re: Review Request 42255: Updated user documentation around HTTP response codes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42255/#review114930 --- Ship it! Ship It! - Guangya Liu On 一月 13, 2016, 3:48 p.m.,

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review114931 --- Ship it! Ship It! - Guangya Liu On 一月 12, 2016, 9:34 p.m.,

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/ --- (Updated 一月 18, 2016, 2:28 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 42255: Updated user documentation around HTTP response codes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42255/#review114933 --- Bad patch! Reviews applied: [40539, 37999, 38000, 38094, 38950,

Re: Review Request 41772: Added helper function to flatten resources.

> On Jan. 7, 2016, 8:31 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 894-904 > > > > > > This seems more appropriate as an optional parameter for > > `Resources::flatten`, just like `Option`. > >

Re: Review Request 42221: Removed references to wDRF from allocator.

> On Jan. 16, 2016, 10:36 p.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1245 > > > > > > How about `allocatedStage2`? Good, much shorter with the same meaning. -

Review Request 42414: Ignore a review chain if any of the reviews in the chain is unpublished.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42414/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4399

Re: Review Request 42414: Ignore a review chain if any of the reviews in the chain is unpublished.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42414/ --- (Updated Jan. 17, 2016, 8:45 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42305: Updated comments around sorters in the allocator.

> On Jan. 16, 2016, 11:09 p.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 412 > > > > > > I think you mean `Level 1`? Correct, sorry! - Alexander

Re: Review Request 42222: Added a comment on allocator recovery.

> On Jan. 15, 2016, 6:50 a.m., Ben Mahler wrote: > > Thanks Alex! I ended up going over the structure of the recover code and > > left some higher level comments. There also appears to be a bug that will > > crash the master that I marked as an issue :) > > > > Have we convinced ourselves

Re: Review Request 42414: Ignore a review chain if any of the reviews in the chain is unpublished.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42414/#review114902 --- Patch looks great! Reviews applied: [42414] Passed command:

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review114908 --- Ping @alex-mesos/@jvanremoortere, any comments. - Klaus Ma On

Review Request 42440: Create a test macro to advance `Clock` for `Future`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42440/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, Jian Qiu, and

Review Request 42415: Added a roles field to FrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42415/ --- Review request for mesos, Benjamin Bannier and Vinod Kone. Bugs: MESOS-4363

Re: Review Request 42440: Create a test macro to advance `Clock` for `Future`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42440/#review114909 --- Patch looks great! Reviews applied: [42440] Passed command: