Re: Review Request 42362: Added persistent volume endpoint test without authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 28, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/#review116791 --- docs/fetcher.md (line 122)

Re: Review Request 42773: Added utility function to compute SHA512 digest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/#review116786 --- Fix it, then Ship it! src/common/command_utils.hpp (line 65)

Review Request 42914: Listed supported file extensions in fetcher documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/ --- Review request for mesos, Jan Schlicht and Till Toenshoff. Bugs: MESOS-4336

Re: Review Request 42911: Removed extra blank line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42911/#review116777 --- Patch looks great! Reviews applied: [42908, 42910, 42633, 42636,

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

> On Jan. 28, 2016, 11:05 a.m., Alexander Rukletsov wrote: > > Thanks Alex! :-) > On Jan. 28, 2016, 11:05 a.m., Alexander Rukletsov wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, line 1087 > > > > > >

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/#review116793 --- docs/fetcher.md (line 122)

Re: Review Request 42810: Added the CgroupInfo protobuf. The agent can use this message to reflect any cgroup configuration that might have been applied to a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42810/ --- (Updated Jan. 28, 2016, 5:31 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42936: Edited flag help strings for style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/#review116916 --- Patch looks great! Reviews applied: [42936] Passed command:

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

> On Jan. 15, 2016, 12:03 a.m., Zhitao Li wrote: > > src/docker/docker.cpp, lines 410-420 > > > > > > (Sorry I just got time to come back to this). > > > > I don't exactly understand your suggestion about

Re: Review Request 42946: Replace tabs with spaces in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42946/#review116914 --- Ship it! Ship It! - haosdent huang On Jan. 29, 2016, 2:55

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

> On Jan. 28, 2016, 11:40 p.m., Timothy Chen wrote: > > docs/fetcher.md, line 119 > > > > > > then files with a recognized extension > > Bernd Mathiske wrote: > Soryy, I do not understand what you mean. > >

Re: Review Request 42927: Deleted Dockerfile in favor of `support/docker_build.sh`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42927/#review116917 --- Ship it! Ship It! - Guangya Liu On Jan. 29, 2016, 12:05

Re: Review Request 42946: Replace tabs with spaces in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42946/#review116927 --- Ship it! Commit message should probably be

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/#review116928 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 20, 2016,

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

> On Jan. 29, 2016, 7:40 a.m., Timothy Chen wrote: > > docs/fetcher.md, line 119 > > > > > > then files with a recognized extension > > Bernd Mathiske wrote: > Soryy, I do not understand what you mean. Sorry,

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/#review116929 --- Fix it, then Ship it! Ship It! docs/fetcher.md (line 119)

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/#review116924 --- Ship it! Ship It! - Guangya Liu On Jan. 28, 2016, 6:17

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

> On Jan. 28, 2016, 11:40 p.m., Timothy Chen wrote: > > docs/fetcher.md, line 119 > > > > > > then files with a recognized extension Soryy, I do not understand what you mean. - Bernd

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 28, 2016, 5:59 p.m.) Review request for mesos, Alexander

Re: Review Request 42832: Added a status method to the Isolator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42832/#review116804 --- Ship it! Ship It! - Jie Yu On Jan. 28, 2016, 5:57 p.m.,

Re: Review Request 42810: Added the CgroupInfo protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42810/#review116805 --- Patch looks great! Reviews applied: [42810] Passed command:

Re: Review Request 42841: WIP: Introducing appc image fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/ --- (Updated Jan. 28, 2016, 7:10 p.m.) Review request for Jie Yu. Changes

Re: Review Request 42915: Check SlaveId when recover Docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42915/#review116807 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

> On Jan. 28, 2016, 10:08 p.m., Anand Mazumdar wrote: > > include/mesos/mesos.proto, line 1637 > > > > > > hmmm .. we have generally just used `name` as the field-name at other > > places for specifying the image

Review Request 42921: Fixed flaky MaxCompletedTasksPerFrameworkFlag test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42921/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-4518

Re: Review Request 42921: Fixed flaky MaxCompletedTasksPerFrameworkFlag test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42921/ --- (Updated Jan. 28, 2016, 10:56 p.m.) Review request for mesos, Anand Mazumdar

Review Request 42915: Check SlaveId when recover Docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42915/ --- Review request for mesos. Bugs: MESOS-3484

Re: Review Request 42915: Check SlaveId when recover Docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42915/ --- (Updated Jan. 28, 2016, 5:37 p.m.) Review request for mesos. Bugs:

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

> On Jan. 28, 2016, 5:49 p.m., Alexander Rukletsov wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, lines 1118-1119 > > > > > > I advocate the practice when each block wrapped in curly braces is > >

Re: Review Request 42921: Fixed flaky MaxCompletedTasksPerFrameworkFlag test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42921/#review116829 --- Looks great, just some minor comments below.

Re: Review Request 42921: Fixed flaky MaxCompletedTasksPerFrameworkFlag test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42921/#review116837 --- Patch looks great! Reviews applied: [42921] Passed command:

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42554/#review116822 --- Fix it, then Ship it! include/mesos/mesos.proto (line 1640)

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42554/#review116823 --- include/mesos/mesos.proto (line 1637)

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42554/#review116826 --- it's strange that this protobuf is exposed in Mesos API. Similar

Re: Review Request 40731: Added a fixture to test the floating point precision for CPU resource allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review116809 --- Bad patch! Reviews applied: [40731] Failed command:

Re: Review Request 42901: Fixed a few typos in the HA framework guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42901/#review116810 --- Ship it! Thank you! - Vinod Kone On Jan. 28, 2016, 7:26

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/#review116817 --- Patch looks great! Reviews applied: [42914] Passed command:

Re: Review Request 42773: Added utility function to compute SHA512 digest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/#review116820 --- src/common/command_utils.hpp (line 68)

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

> On Jan. 15, 2016, 12:03 a.m., Zhitao Li wrote: > > src/docker/docker.cpp, lines 410-420 > > > > > > (Sorry I just got time to come back to this). > > > > I don't exactly understand your suggestion about

Re: Review Request 42539: Support image specified Entrypoint and Cmd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42539/ --- (Updated Jan. 28, 2016, 12:28 p.m.) Review request for mesos, Jie Yu and

Review Request 42928: Updated docker_build.sh to generate xml output for all OSes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42928/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues.

Re: Review Request 42927: Deleted Dockerfile in favor of `support/docker_build.sh`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42927/#review116842 --- Ship it! Ship It! - Anand Mazumdar On Jan. 29, 2016, 12:05

Re: Review Request 42841: WIP: Introducing appc image fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/ --- (Updated Jan. 29, 2016, 12:58 a.m.) Review request for Jie Yu. Repository:

Re: Review Request 42866: Disabled the test RegistryClientTest.BadTokenServerAddress.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42866/#review116856 --- Ship it! Ship It! - Timothy Chen On Jan. 27, 2016, 8:38

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/ --- (Updated Jan. 29, 2016, 1:15 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

> On Jan. 29, 2016, 1:03 a.m., Anand Mazumdar wrote: > > support/verify_reviews.py, line 151 > > > > > > hmm .. what happens to the build_output file thereafter? Should we be > > cleaning it up too? This gets

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

> On Jan. 29, 2016, 1:10 a.m., Kevin Klues wrote: > > support/verify_reviews.py, line 140 > > > > > > To avoid using tee, you could just do: > > > > "%s > %s 2>&1" % (command, build_output) The above just

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116864 --- Ship it! You would need to update the Summary/Description

Re: Review Request 42773: Added utility function to compute SHA512 digest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/#review116863 --- Fix it, then Ship it! I'll fix the remaining issue for you.

Review Request 42927: Deleted Dockerfile in favor of `support/docker_build.sh`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42927/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues.

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of `shell.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40936/ --- (Updated Jan. 29, 2016, 12:04 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 42755: Added documentation for labeled reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/#review116846 --- Ship it! Ship It! - Qian Zhang On Jan. 26, 2016, 7:02 a.m.,

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42554/ --- (Updated Jan. 29, 2016, 12:56 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

> On Jan. 28, 2016, 10:12 p.m., Jie Yu wrote: > > it's strange that this protobuf is exposed in Mesos API. Similar to Docker, > > can we move this to include/mesos/appc/spec.proto? Will be working on a separate patch for moving this message to appc/spec.proto. - Jojy

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116858 --- support/verify_reviews.py (line 139)

Review Request 42929: Updated docker_build.sh to make build environment configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. Bugs:

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116847 --- Bad patch! Reviews applied: [42927, 42928, 42929] Failed

Re: Review Request 40731: Added a test case for floating point precision of resource allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 29, 2016, 12:42 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 42928: Updated docker_build.sh to generate xml output for all OSes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42928/#review116855 --- Ship it! Ship It! - Kevin Klues On Jan. 29, 2016, 12:06

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116850 --- LGTM. Just one minor query about what happens to the piped file

Re: Review Request 42928: Updated docker_build.sh to generate xml output for all OSes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42928/#review116844 --- Ship it! Can we also set up the Jenkins xUnit Plugin to find

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116848 --- Ship it! LGTM. Looks like the review bot vaidated that the

Re: Review Request 40731: Added a test case for floating point precision of resource allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 29, 2016, 12:45 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 42773: Added utility function to compute SHA512 digest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/ --- (Updated Jan. 29, 2016, 12:54 a.m.) Review request for mesos. Changes

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116854 --- Ship it! Ship It! - Kevin Klues On Jan. 29, 2016, 12:10

Re: Review Request 42927: Deleted Dockerfile in favor of `support/docker_build.sh`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42927/#review116859 --- Ship it! Ship It! - Kevin Klues On Jan. 29, 2016, 12:05

Re: Review Request 42755: Added documentation for labeled reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/#review116861 --- docs/reservation.md (lines 80 - 81)

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42554/ --- (Updated Jan. 29, 2016, 1:27 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/ --- (Updated Jan. 29, 2016, 1:32 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116865 --- Ship it! Ship It! - Anand Mazumdar On Jan. 29, 2016, 1:32

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116866 --- Ship it! Ship It! - haosdent huang On Jan. 28, 2016, 5:59

Re: Review Request 42673: Silenced two more GMock warnings about shutdown expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42673/#review116737 --- Ship it! Ship It! - Timothy Chen On Jan. 22, 2016, 11:38

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review116736 --- Bad patch! Reviews applied: [40731] Failed command:

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41892/#review116738 --- src/docker/docker.cpp (lines 20 - 29)

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

> On Jan. 15, 2016, 12:03 a.m., Zhitao Li wrote: > > src/docker/docker.cpp, lines 410-420 > > > > > > (Sorry I just got time to come back to this). > > > > I don't exactly understand your suggestion about

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/ --- (Updated Jan. 28, 2016, 1:12 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 42672: Explicitly checked for the absence of allocation.

> On Jan. 23, 2016, 6:31 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1494 > > > > > > remove the blank line? Which line do you mean? - Alexander

Review Request 42908: Fixed a flaky test in quota tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/ --- Review request for mesos, Michael Park and Qian Zhang. Bugs: MESOS-4542

Review Request 42910: Added a note about revocable resources beyond quota in the user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42910/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Repository:

Re: Review Request 42633: Corrected a comment in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/ --- (Updated Jan. 28, 2016, 1:07 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42658: Restructured comments in allocator tests for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42658/ --- (Updated Jan. 28, 2016, 1:11 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42672: Explicitly checked for the absence of allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42672/ --- (Updated Jan. 28, 2016, 1:22 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42657: Corrected a typo in allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42657/ --- (Updated Jan. 28, 2016, 1:08 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42636: Replaced term 'periodic allocation' for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42636/ --- (Updated Jan. 28, 2016, 1:08 p.m.) Review request for mesos and Ben Mahler.

Review Request 42911: Removed extra blank line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42911/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 42910: Added a note about revocable resources beyond quota in the user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42910/#review116769 --- docs/quota.md (line 279)

Re: Review Request 42901: Fixed a few typos in the HA framework guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42901/#review116758 --- Patch looks great! Reviews applied: [42901] Passed command:

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116757 --- Fix it, then Ship it!

Re: Review Request 42900: Fixed some typos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42900/#review116752 --- Patch looks great! Reviews applied: [42900] Passed command:

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

> On Jan. 27, 2016, 11:20 p.m., Anand Mazumdar wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, line 1112 > > > > > > Nit: Can we omit the part about not setting the authentication headers > > since

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116797 --- src/tests/persistent_volume_endpoints_tests.cpp (lines 1118 -

Re: Review Request 42810: Added the CgroupInfo protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42810/ --- (Updated Jan. 28, 2016, 5:32 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/#review116796 --- docs/fetcher.md (line 122)

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

> On Jan. 28, 2016, 5:49 p.m., Alexander Rukletsov wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, lines 1118-1119 > > > > > > I advocate the practice when each block wrapped in curly braces is > >

Re: Review Request 42832: Added a status method to the Isolator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42832/ --- (Updated Jan. 28, 2016, 5:57 p.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116803 --- Patch looks great! Reviews applied: [42530, 42362] Passed

Re: Review Request 40731: Added a fixture to test the floating point precision for CPU resource allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 28, 2016, 6 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 42773: Added utility function to compute SHA512 digest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/ --- (Updated Jan. 28, 2016, 6:44 p.m.) Review request for mesos. Changes ---

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

> On Jan. 29, 2016, 1:10 a.m., Kevin Klues wrote: > > support/verify_reviews.py, line 140 > > > > > > To avoid using tee, you could just do: > > > > "%s > %s 2>&1" % (command, build_output) > > Vinod Kone

  1   2   >