Re: Review Request 49071: Updated CNI test to verify the checkpointed CNI network config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49071/ --- (Updated June 23, 2016, 1:52 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 49122: Added a MAC parse function to stout.

> On June 23, 2016, 3:11 a.m., Jay Guo wrote: > > Also we need to strip whitespaces in `token`, since `strtoul` ignores > > leading whitespaces without generating any errors. For example, this test > > fails with current implementation: > > `EXPECT_ERROR(net::MAC::parse(" 2:34:56:78:9a:bc"));`

Re: Review Request 49130: Helper function for approver creation in master::http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49130/#review139212 --- Could you refactor `_tasks()`, `stateSummary()` to use this

Re: Review Request 48841: Add Agent protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/ --- (Updated 六月 23, 2016, 5:13 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 49131: Fixed failed authorization of '/files/*' endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49131/ --- Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-5685

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/#review139211 --- Patch looks great! Reviews applied: [45958, 45959, 48616, 45960,

Re: Review Request 48841: Add Agent protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/#review139151 --- include/mesos/master/master.proto (lines 283 - 285)

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On June 14, 2016, 10:50 p.m., Jiang Yan Xu wrote: > > A high level comment is that when we are making significant changes to the > > allocator we have to measure the performance implication both when clusters > > don't use this feature and when clusters do in benchmarks. +1. Will do. -

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On June 14, 2016, 10:50 p.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, line 1773 > > > > > > Make sure we add this to the tests. > > > > So now the shared persistent volume could look like

Re: Review Request 49129: Allow requesting initial state upon subscribe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49129/ --- (Updated June 23, 2016, 3:55 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48751: Implement GetState response for master API.

> On June 22, 2016, 6:29 a.m., Jay Guo wrote: > > src/master/http.cpp, lines 1477-1500 > > > > > > I feel we can extract this logic to a common function since it's being > > used by getTasks as well. > > Zhitao

Review Request 49130: Helper function for approver creation in master::http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49130/ --- Review request for mesos, Anand Mazumdar, Jay Guo, and Vinod Kone. Bugs:

Re: Review Request 49122: Added a MAC parse function to stout.

> On June 23, 2016, 3:11 a.m., Jay Guo wrote: > > Also we need to strip whitespaces in `token`, since `strtoul` ignores > > leading whitespaces without generating any errors. For example, this test > > fails with current implementation: > > `EXPECT_ERROR(net::MAC::parse(" 2:34:56:78:9a:bc"));`

Re: Review Request 49090: Improved formatting of Slave::authorizeSandboxAccess for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49090/#review139205 --- Patch looks great! Reviews applied: [49089, 49090] Passed

Re: Review Request 49122: Added a MAC parse function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49122/#review139204 --- Also we need to strip whitespaces in `token`, since `strtoul`

Re: Review Request 49059: Fixed the test suite build for Apple clang-600.0.54.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49059/#review139203 --- Ship it! Ship It! - Till Toenshoff On June 22, 2016, 1:09

Re: Review Request 49122: Added a MAC parse function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49122/#review139202 --- 3rdparty/stout/include/stout/mac.hpp (lines 95 - 97)

Re: Review Request 49070: Used checkpointed CNI network config during cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49070/ --- (Updated June 23, 2016, 10:33 a.m.) Review request for mesos, Avinash

Re: Review Request 49069: Checkpointed CNI network config for container in the container dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49069/ --- (Updated June 23, 2016, 10:31 a.m.) Review request for mesos, Avinash

Re: Review Request 49070: Used checkpointed CNI network config during cleanup.

> On June 23, 2016, 6:01 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 1274 > > > > > > Can we add a VLOG here similar to what we did in `attach`? Sure we can. However

Re: Review Request 49127: Fix socket leak in SSL_ENABLE_DOWNGRADE code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49127/#review139200 --- Ship it! Ship It! - Benjamin Mahler On June 23, 2016, 2:07

Review Request 49127: Fix socket leak in SSL_ENABLE_DOWNGRADE code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49127/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan,

Re: Review Request 49118: Move allocator header and proto to own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49118/#review139199 --- Patch looks great! Reviews applied: [48902, 49118] Passed

Re: Review Request 49122: Added a MAC parse function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49122/#review139197 --- Fix it, then Ship it! Ship It!

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated June 23, 2016, 1:29 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45966: Offer shareable resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated June 23, 2016, 1:29 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated June 23, 2016, 1:28 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated June 23, 2016, 1:28 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated June 23, 2016, 1:27 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49095: Enabled fine-grained authorization in the master's frameworks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49095/#review139191 --- Patch looks great! Reviews applied: [49095] Passed command:

Re: Review Request 48751: Implement GetState response for master API.

> On June 22, 2016, 6:29 a.m., Jay Guo wrote: > > src/master/http.cpp, lines 1477-1500 > > > > > > I feel we can extract this logic to a common function since it's being > > used by getTasks as well. > > Zhitao

Re: Review Request 48989: Fixed broken cni isolator test on centos7.

> On June 22, 2016, 10:20 a.m., Qian Zhang wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 185 > > > > > > I just manually ran a Docker container from 'alpine' image in an RHEL > > 7.1 machine, and

Re: Review Request 49090: Improved formatting of Slave::authorizeSandboxAccess for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49090/#review139181 --- Ship it! Ship It! - Till Toenshoff On June 22, 2016, 4:27

Re: Review Request 49089: Removed a superfluous future repair invocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49089/#review139180 --- Ship it! Ship It! - Till Toenshoff On June 22, 2016, 4:26

Re: Review Request 49122: Added a MAC parse function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49122/ --- (Updated June 22, 2016, 11:56 p.m.) Review request for mesos, Avinash

Review Request 49122: Added a MAC parse function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49122/ --- Review request for mesos, Avinash sridharan and Gilbert Song. Repository:

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review139175 --- Ship it! Ship It! - haosdent huang On June 22, 2016, 6:19

Re: Review Request 49082: Enabled fine grained authorization in the Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49082/#review139171 --- Patch looks great! Reviews applied: [49083, 49082] Passed

Review Request 49118: Move allocator header and proto to own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49118/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs:

Re: Review Request 48988: Reduced test linux rootfs size.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48988/#review139166 --- Ship it! Ship It! - Jie Yu On June 22, 2016, 10:53 p.m.,

Re: Review Request 48994: Fixed portmapping isolator bind mount root non-existed case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48994/#review139165 --- Ship it! Ship It! - Jie Yu On June 22, 2016, 10:55 p.m.,

Re: Review Request 48995: Fixed portmapping isolator tests ContainerId.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48995/#review139164 --- Ship it! Ship It! - Jie Yu On June 22, 2016, 10:55 p.m.,

Re: Review Request 48992: Fixed memory pressure test cgroup statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48992/ --- (Updated June 22, 2016, 3:54 p.m.) Review request for mesos, Alexander

Re: Review Request 48996: Added space for ROOT_NC_HostToContainerUDP shell commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48996/ --- (Updated June 22, 2016, 3:55 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 48994: Fixed portmapping isolator bind mount root non-existed case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48994/ --- (Updated June 22, 2016, 3:55 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 48995: Fixed portmapping isolator tests ContainerId.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48995/ --- (Updated June 22, 2016, 3:55 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 48991: Added exception for etc hostname mount in cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48991/ --- (Updated June 22, 2016, 3:54 p.m.) Review request for mesos, Avinash

Re: Review Request 48993: Fixed memory pressure test cgroup slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48993/ --- (Updated June 22, 2016, 3:54 p.m.) Review request for mesos, Alexander

Re: Review Request 48989: Fixed broken cni isolator test on centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48989/ --- (Updated June 22, 2016, 3:54 p.m.) Review request for mesos, Avinash

Re: Review Request 49059: Fixed the test suite build for Apple clang-600.0.54.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49059/#review139161 --- Ship it! Ship It! - Jie Yu On June 22, 2016, 1:09 a.m.,

Re: Review Request 49063: Updating formatting of some lambda calls for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49063/#review139155 --- Patch looks great! Reviews applied: [49059, 49060, 49061, 49062,

Re: Review Request 49070: Used checkpointed CNI network config during cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49070/#review139153 --- Fix it, then Ship it!

Re: Review Request 49013: Updated cgroups/devices isolator's prepare() to directly return None().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49013/#review139149 --- Ship it! Ship It! - Benjamin Mahler On June 22, 2016, 9:51

Re: Review Request 49067: Added AFFILIATIONS.yml file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49067/#review139143 --- I'm wondering if we should just seed this list with Mesosphere

Re: Review Request 49109: Cherry-pick of MESOS-5330 to 0.28.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49109/#review139147 --- Ship it! Ship It! - Jie Yu On June 22, 2016, 9:33 p.m.,

Re: Review Request 49108: Cherry-pick of MESOS-5330 to 0.27.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49108/#review139146 --- Ship it! Ship It! - Jie Yu On June 22, 2016, 9:33 p.m.,

Review Request 49109: Cherry-pick of MESOS-5330 to 0.28.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49109/ --- Review request for mesos, David Robinson and Jie Yu. Bugs: MESOS-5330

Review Request 49108: Cherry-pick of MESOS-5330 to 0.27.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49108/ --- Review request for mesos, David Robinson and Jie Yu. Bugs: MESOS-5330

Re: Review Request 48994: Fixed portmapping isolator bind mount root non-existed case.

> On June 22, 2016, 6:19 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 1894 > > > > > > Hum, just realized an issue. If you do that, bindMountRoot is no longer > >

Re: Review Request 48995: Fixed portmapping isolator symlink existed failure.

> On June 22, 2016, 11:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 2587 > > > > > > Instead of doing that, can you use a uuid for container id in the > >

Re: Review Request 48995: Fixed portmapping isolator symlink existed failure.

> On June 22, 2016, 11:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 2587 > > > > > > Instead of doing that, can you use a uuid for container id in the > >

Re: Review Request 48906: Added helper function to get non-scarce resources.

> On June 21, 2016, 10:36 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 252-256 > > > > > > The Resources abstraction shouldn't need to know anything about scarce > > resources, you can just

Re: Review Request 48994: Fixed portmapping isolator bind mount root non-existed case.

> On June 22, 2016, 11:19 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 1894 > > > > > > Hum, just realized an issue. If you do that, bindMountRoot is no longer > >

Re: Review Request 48989: Fixed broken cni isolator test on centos7.

> On June 21, 2016, 7:20 p.m., Qian Zhang wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 185 > > > > > > I just manually ran a Docker container from 'alpine' image in an RHEL > > 7.1 machine, and

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/#review139126 --- Patch looks great! Reviews applied: [48926, 48927, 48938]

Re: Review Request 48988: Reduced test linux rootfs size.

> On June 22, 2016, 10:23 a.m., Jie Yu wrote: > > src/tests/containerizer/rootfs.hpp, line 142 > > > > > > I am not sure if this logic still applies. For instance, if `/lib64 -> > > /xxx/lib64`. > > > >

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

> On June 21, 2016, 12:36 a.m., Vinod Kone wrote: > > src/CMakeLists.txt, line 24 > > > > > > don't you need to change this? > > Zhitao Li wrote: > I'd like to address this in a separate patch, and I have some

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review139117 --- Ship it! Ship It! - Vinod Kone On June 22, 2016, 6:19 p.m.,

Re: Review Request 48988: Reduced test linux rootfs size.

> On June 22, 2016, 5:23 p.m., Jie Yu wrote: > > src/tests/containerizer/rootfs.hpp, line 142 > > > > > > I am not sure if this logic still applies. For instance, if `/lib64 -> > > /xxx/lib64`. > > > > The

Re: Review Request 48988: Reduced test linux rootfs size.

> On June 20, 2016, 8:09 p.m., haosdent huang wrote: > > src/tests/containerizer/rootfs.hpp, line 109 > > > > > > +1 for this, it would reduce a lot of test cases running time. > > @zhiwei may worry about

Re: Review Request 48988: Reduced test linux rootfs size.

> On June 22, 2016, 10:23 a.m., Jie Yu wrote: > > src/tests/containerizer/rootfs.hpp, line 142 > > > > > > I am not sure if this logic still applies. For instance, if `/lib64 -> > > /xxx/lib64`. > > > >

Re: Review Request 49015: Implemented GET_CONTAINERS Call in v1 Agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49015/#review139112 --- Patch looks great! Reviews applied: [49015] Passed command:

Re: Review Request 48991: Added exception for etc hostname mount in cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48991/#review139108 --- Fix it, then Ship it!

Re: Review Request 49040: Fixed containerizer.cpp break.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49040/#review139107 --- Ship it! Ship It! - Joseph Wu On June 22, 2016, 12:36 a.m.,

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

> On June 21, 2016, 12:36 a.m., Vinod Kone wrote: > > src/CMakeLists.txt, line 24 > > > > > > don't you need to change this? I'd like to address this in a separate patch, and I have some open question on how to

Re: Review Request 48994: Fixed portmapping isolator bind mount root non-existed case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48994/#review139103 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp

Re: Review Request 49037: Removed mesos-Containerizer-memory_test in Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49037/#review139101 --- Ship it! Built on a couple Linux boxes. src/CMakeLists.txt

Re: Review Request 48995: Fixed portmapping isolator symlink existed failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48995/#review139098 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp

Re: Review Request 48994: Fixed portmapping isolator bind mount root non-existed case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48994/#review139097 --- Ship it! Ship It! - Jie Yu On June 21, 2016, 2:46 a.m.,

Re: Review Request 48992: Fixed memory pressure test cgroup statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48992/#review139093 --- Ship it! Ship It! - Jie Yu On June 21, 2016, 2:46 a.m.,

Re: Review Request 48993: Fixed memory pressure test cgroup slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48993/#review139094 --- Ship it! Ship It! - Jie Yu On June 21, 2016, 2:46 a.m.,

Re: Review Request 48990: Added CGROUP namespace to ns helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48990/#review139092 --- Ship it! Ship It! - Jie Yu On June 21, 2016, 2:46 a.m.,

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/ --- (Updated June 22, 2016, 5:33 p.m.) Review request for mesos and Avinash

Re: Review Request 49054: Fix ContainerizerTest.ROOT_CGROUPS_BalloonFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49054/#review139091 --- Ship it! Ship It! - Jie Yu On June 22, 2016, midnight,

Re: Review Request 48989: Fixed broken cni isolator test on centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48989/#review139090 --- Ship it! Ship It! - Jie Yu On June 21, 2016, 2:46 a.m.,

Re: Review Request 48989: Fixed broken cni isolator test on centos7.

> On June 22, 2016, 2:20 a.m., Qian Zhang wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 185 > > > > > > I just manually ran a Docker container from 'alpine' image in an RHEL > > 7.1 machine, and

Re: Review Request 48988: Reduced test linux rootfs size.

> On June 21, 2016, 3:09 a.m., haosdent huang wrote: > > src/tests/containerizer/rootfs.hpp, line 109 > > > > > > +1 for this, it would reduce a lot of test cases running time. > > @zhiwei may worry about

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/#review139085 --- Can you rebase. the patch does not apply with the current trunk

Re: Review Request 48751: Implement GetState response for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/ --- (Updated June 22, 2016, 5 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 49041: Removed `launcher` from the Windows build.

> On June 22, 2016, 12:05 a.m., Joseph Wu wrote: > > src/launcher/CMakeLists.txt, lines 39-41 > > > > > > This results in: > > ``` > > CMake Error at src/launcher/CMakeLists.txt:57 (add_executable): > >

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/#review139083 --- Ship it! Ship It! - Avinash sridharan On June 22, 2016,

Re: Review Request 49071: Updated CNI test to verify the checkpointed CNI network config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49071/#review139082 --- Patch looks great! Reviews applied: [49069, 49070, 49071]

Re: Review Request 48751: Implement GetState response for master API.

> On June 22, 2016, 6:29 a.m., Jay Guo wrote: > > src/master/http.cpp, lines 1477-1500 > > > > > > I feel we can extract this logic to a common function since it's being > > used by getTasks as well. Sounds good

Re: Review Request 48751: Implement GetState response for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/#review139075 --- include/mesos/master/master.proto (line 314)

Review Request 49095: Enabled fine-grained authorization in the master's frameworks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49095/ --- Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff. Repository:

Re: Review Request 49041: Removed `launcher` from the Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49041/#review139069 --- Patch looks great! Reviews applied: [48056, 49037, 49038, 49039,

Review Request 49089: Removed a superfluous future repair invocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49089/ --- Review request for mesos, Joerg Schad and Till Toenshoff. Repository: mesos

Re: Review Request 49082: Enabled fine grained authorization in the Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49082/ --- (Updated June 22, 2016, 4:49 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 49082: Enabled fine grained authorization in the Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49082/ --- (Updated June 22, 2016, 4:49 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 49064: Implement v1 operator update weights API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49064/#review139065 --- src/master/master.hpp (lines 1113 - 1115)

  1   2   >