Re: Review Request 50693: Added a `createSlaveInfo()` overload that takes a `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50693/ --- (Updated 九月 3, 2016, 4:29 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51620: Removed two std::move in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51620/#review147716 --- Patch looks great! Reviews applied: [51620] Passed command:

Re: Review Request 51097: Added a `PortMapper` class.

> On Sept. 2, 2016, 11:46 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp, > > line 36 > > > > > > Should put before `using std::cout`; you mean

Re: Review Request 51620: Removed two std::move in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51620/#review147714 --- Ship it! Ship It! - Gilbert Song On Sept. 2, 2016, 5:25

Review Request 51620: Removed two std::move in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51620/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6118

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review147713 --- Patch looks great! Reviews applied: [51095, 51096, 51097]

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review147711 ---

Re: Review Request 50868: Using `OfferedResources` for benchmark test of `SuppressOffers`.

> On Aug. 25, 2016, 3:56 p.m., Jiang Yan Xu wrote: > > I don't know. Making such distinction feels like splitting hairs to me. > > Yeah there are subtle differences between the two concepts but to me: > > > > - `offerCallback` may not be the best name what we could have come up with > > even

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- (Updated Sept. 2, 2016, 10:33 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 50693: Added another function `createSlaveInfo` for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50693/#review147695 --- Ship it! Ship It! - Jiang Yan Xu On Sept. 2, 2016, 4:22

Re: Review Request 50693: Added another function `createSlaveInfo` for allocator benchmark test.

> On Sept. 1, 2016, 1:50 p.m., Jiang Yan Xu wrote: > > The rationale isn't clear to me: for the same test if we always parse the > > resources at the same place, isn't the measurement still accurate when you > > compare the benchmark results with vs. without certain patches or between > >

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review147674 --- Fix it, then Ship it! Modulo comments from others and I'll

Re: Review Request 50661: Documentation: fix broken links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50661/#review147679 --- Patch looks great! Reviews applied: [50661] Passed command:

Re: Review Request 51609: Updated formatting in HealthChecker for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51609/#review147673 --- Ship it! Ship It! - haosdent huang On Sept. 2, 2016, 4:44

Re: Review Request 51608: Extracted "curl" binary into HTTP_CHECK_COMMAND constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51608/#review147672 --- Ship it! Ship It! - haosdent huang On Sept. 2, 2016, 4:44

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/#review147671 --- src/CMakeLists.txt (lines 518 - 524)

Review Request 51608: Extracted "curl" binary into HTTP_CHECK_COMMAND constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51608/ --- Review request for mesos, Gastón Kleiman and haosdent huang. Bugs: MESOS-6117

Review Request 51609: Updated formatting in HealthChecker for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51609/ --- Review request for mesos, Gastón Kleiman and haosdent huang. Repository: mesos

Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51607/ --- Review request for mesos, Avinash sridharan, Benjamin Mahler, Gastón Kleiman,

Review Request 51605: Added "mesos-tcp-connect" binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/ --- Review request for mesos, Avinash sridharan, Benjamin Mahler, Gastón Kleiman,

Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51606/ --- Review request for mesos, Gastón Kleiman and haosdent huang. Bugs: MESOS-6119

Re: Review Request 50661: Documentation: fix broken links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50661/ --- (Updated Sept. 2, 2016, 4:35 p.m.) Review request for mesos, Dave Lester,

Re: Review Request 51603: Fixed remaining quoting issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51603/#review147670 --- Patch looks great! Reviews applied: [51603] Passed command:

Re: Review Request 51603: Fixed remaining quoting issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51603/#review147669 --- Ship it! Ship It! - Michael Park On Sept. 2, 2016, 3:17

Review Request 51603: Fixed remaining quoting issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51603/ --- Review request for mesos and Michael Park. Bugs: MESOS-4907

Re: Review Request 51359: Added unit test for provisioner helper findContainerDir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51359/#review147657 --- src/tests/containerizer/provisioner_paths_tests.cpp (lines 56 -

Re: Review Request 51359: Added unit test for provisioner helper findContainerDir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51359/#review147655 --- src/tests/containerizer/provisioner_paths_tests.cpp (line 39)

Re: Review Request 51358: Implemented recursive helper method findContainerDir for provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51358/#review147654 --- src/slave/containerizer/mesos/provisioner/paths.cpp (line 111)

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/#review147651 --- src/master/allocator/mesos/hierarchical.cpp (lines 686 - 689)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review147648 --- Jacob, can you please help rebase your patch due to some patches

Re: Review Request 51257: Add external process container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51257/ --- (Updated Sept. 2, 2016, 11:26 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50693: Added another function `createSlaveInfo` for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50693/ --- (Updated 九月 2, 2016, 11:22 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51476: Made the `TaskInfo` argument in `launchExecutor()` optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51476/ --- (Updated Sept. 2, 2016, 9:28 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51594: Properly quoted string in shell script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51594/#review147637 --- Ship it! Ship It! - Michael Park On Sept. 2, 2016, 8:09

Review Request 51594: Properly quoted string in shell script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51594/ --- Review request for mesos and Michael Park. Bugs: MESOS-4907

Re: Review Request 51592: Added a debug logging for a CHECK failure in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51592/#review147633 --- Ship it! Ship It! - Gilbert Song On Sept. 1, 2016, 6:11

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51477/#review147632 --- src/slave/slave.hpp (line 908)