Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

> On Oct. 19, 2016, 5:49 p.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 608 > > > > > > THis test will certainly break if nobody does not have access to my > > home dir where I

Review Request 53045: Fixed a typo in `executor.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53045/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 53044: Fixed a typo in the header files of stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53044/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/#review153347 --- 3rdparty/stout/include/stout/os/posix/xattr.hpp (line 24)

Re: Review Request 53018: Fixed a comment in `stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53018/#review153346 --- Ship it! Ship It! - Alex Clemmer On Oct. 19, 2016, 8:23

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review153345 --- Jacob, regaring the test failure of

Re: Review Request 53042: Added `FsTest.Xattr` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53042/ --- (Updated Oct. 20, 2016, 11:20 a.m.) Review request for mesos and Jie Yu.

Review Request 53042: Added `FsTest.Xattr` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53042/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6360

Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/ --- Review request for mesos. Bugs: MESOS-6360

Re: Review Request 51185: Removed the expired TODO about non-recursive version `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51185/ --- (Updated Oct. 20, 2016, 2:26 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/ --- (Updated Oct. 20, 2016, 2:26 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 53033: Improved agent re-registration log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53033/#review153340 --- Patch looks great! Reviews applied: [53033] Passed command:

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

> On Oct. 19, 2016, 5:49 p.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 608 > > > > > > THis test will certainly break if nobody does not have access to my > > home dir where I

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

> On Oct. 19, 2016, 5:49 p.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 608 > > > > > > THis test will certainly break if nobody does not have access to my > > home dir where I

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

> On Oct. 19, 2016, 5:49 p.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 608 > > > > > > THis test will certainly break if nobody does not have access to my > > home dir where I

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

> On Oct. 19, 2016, 5:49 p.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 608 > > > > > > THis test will certainly break if nobody does not have access to my > > home dir where I

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review153334 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line 608)

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review153282 --- Fix it, then Ship it! src/linux/cgroups.hpp (lines 214 - 215)

Re: Review Request 52803: Changed agent to send TASK_GONE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52803/#review153327 --- Ship it! Ship It! - Vinod Kone On Oct. 14, 2016, 4:02 p.m.,

Re: Review Request 53031: Failure in cleanup of non-existing cgroups is treated as success.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53031/#review153326 --- Patch looks great! Reviews applied: [53031] Passed command:

Re: Review Request 52801: Changed description of TASK_GONE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52801/#review153324 --- Ship it! Ship It! - Vinod Kone On Oct. 12, 2016, 7:35 p.m.,

Re: Review Request 52802: Added a new slave metric, "tasks_gone".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52802/#review153325 --- Ship it! Ship It! - Vinod Kone On Oct. 12, 2016, 7:35 p.m.,

Re: Review Request 53031: Failure in cleanup of non-existing cgroups is treated as success.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53031/#review153319 --- src/linux/cgroups.cpp (lines 329 - 335)

Re: Review Request 53036: Allow agents to recover slave state post a reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53036/ --- (Updated Oct. 19, 2016, 10:52 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 53033: Improved agent re-registration log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53033/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 53031: Failure in cleanup of non-existing cgroups is treated as success.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53031/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-6414

Re: Review Request 53024: Fixed 'ROOT_CGROUPS_ParentExit' multi-digit fd issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53024/#review153305 --- Ship it! Ship It! - Benjamin Mahler On Oct. 19, 2016, 5:48

Re: Review Request 53012: Fixed usage of 'evolve' in master http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53012/ --- (Updated Oct. 19, 2016, 6:48 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 53024: Fixed 'ROOT_CGROUPS_ParentExit' multi-digit fd issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53024/#review153302 --- Patch looks great! Reviews applied: [53024] Passed command:

Re: Review Request 52938: Added temporary disabled TEST_P macro for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52938/ --- (Updated Oct. 19, 2016, 6:34 p.m.) Review request for mesos, Joseph Wu and

Review Request 53024: Fixed 'ROOT_CGROUPS_ParentExit' multi-digit fd issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53024/ --- Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler,

Re: Review Request 52997: Improve Socket::connect error message.

> On Oct. 19, 2016, 5:32 a.m., Michael Park wrote: > > 3rdparty/libprocess/src/poll_socket.cpp, lines 133-141 > > > > > > Do we need to set these here...? If I understand correctly they already > > hold the correct

Re: Review Request 52976: Split mesos test helpers into 'internal' and 'v1' namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52976/#review153286 --- Fix it, then Ship it! Tbanks a ton on this cleanup!

Re: Review Request 53014: Removed unused tests helper macro 'DEFAULT_CONTAINER_ID'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53014/#review153285 --- Ship it! Ship It! - Jie Yu On Oct. 19, 2016, 4:47 a.m.,

Re: Review Request 53013: Removed extra 'evolve' implementation from 'api_tests.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53013/#review153284 --- Ship it! src/internal/evolve.hpp (line 59)

Re: Review Request 53012: Fixed usage of 'evolve' in master http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53012/#review153283 --- Ship it! Ship It! - Jie Yu On Oct. 19, 2016, 4:47 a.m.,

Re: Review Request 52600: Enable multiple field based authorization in the authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52600/#review153281 --- Patch looks great! Reviews applied: [52600] Passed command:

Re: Review Request 51185: Removed the expired TODO about non-recursive version `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51185/ --- (Updated Oct. 19, 2016, 3:46 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/ --- (Updated Oct. 19, 2016, 3:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 53018: Fixed a comment in `stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53018/#review153278 --- Patch looks great! Reviews applied: [53018] Passed command:

Re: Review Request 52746: Changed agent to send TASK_DROPPED for task launch failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52746/ --- (Updated Oct. 19, 2016, 1:39 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53016: Added test case for ranges less than or equal to operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53016/#review153274 --- Patch looks great! Reviews applied: [53016] Passed command:

Re: Review Request 53015: Documentation for the port-mapper CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53015/#review153268 --- Patch looks great! Reviews applied: [53015] Passed command:

Re: Review Request 52103: Implement quota update through `PUT` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52103/ --- (Updated Oct. 19, 2016, 11:28 a.m.) Review request for mesos, Alexander

Re: Review Request 52284: Implement more quota validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52284/ --- (Updated Oct. 19, 2016, 11:28 a.m.) Review request for mesos, Alexander

Re: Review Request 52284: Implement more quota validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52284/#review153267 --- Fix it, then Ship it! src/tests/master_quota_tests.cpp (lines

Re: Review Request 53017: Adding user Manuwela Kanade in contributors.yaml

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53017/#review153265 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 19, 2016,

Re: Review Request 52988: Fixed a typo in a comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52988/#review153261 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 18, 2016,

Re: Review Request 53019: Removed stray phrase in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53019/#review153260 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 19, 2016,

Review Request 53019: Removed stray phrase in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53019/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52783/#review153257 --- docs/linux_capabilities.md (lines 51 - 52)

Re: Review Request 52600: Enable multiple field based authorization in the authorizer interface.

> On Oct. 19, 2016, 12:22 a.m., Till Toenshoff wrote: > > Seems you got a lot more within this review than planned :) I didn't notice the rebase problems would happen if one only updates the metadata :/ - Alexander --- This is an

Re: Review Request 52600: Enable multiple field based authorization in the authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52600/ --- (Updated Oct. 19, 2016, 10:50 a.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53013: Removed extra 'evolve' implementation from 'api_tests.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53013/#review153252 --- Fix it, then Ship it! Ship It! src/internal/evolve.hpp (line

Re: Review Request 53017: Adding user Manuwela Kanade in contributors.yaml

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53017/ --- (Updated Oct. 19, 2016, 8:23 a.m.) Review request for mesos, haosdent huang

Review Request 53018: Fixed a comment in `stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53018/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 53017: Adding user details in contributors.yaml to be able to contribute to Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53017/ --- Review request for mesos, haosdent huang and Vinod Kone. Repository: mesos

Review Request 53016: Added test case for ranges less than or equal to operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53016/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 51033: Added validation benchmark test for resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51033/#review153249 --- After sort the `ranges` in `validate`, the elapse time was

Review Request 53015: Documentation for the port-mapper CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53015/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6411