> On Oct. 19, 2016, 12:22 a.m., Till Toenshoff wrote: > > Seems you got a lot more within this review than planned :)
I didn't notice the rebase problems would happen if one only updates the metadata :/ - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52600/#review153194 ----------------------------------------------------------- On Oct. 19, 2016, 10:50 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52600/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 10:50 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, and Till Toenshoff. > > > Bugs: MESOS-6401 > https://issues.apache.org/jira/browse/MESOS-6401 > > > Repository: mesos > > > Description > ------- > > Standarize the way in which authorization is perfomed by enabling > all actions suffixed with `_WITH_ROLE` and `_WITH_PRINCIPAL` to > perform authorization using whole protobuf messages instead of > forcing a single field from the message. > > While this change is still in the deprecation cycle, the original > value is also set. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > cb365c7d8d088f2810bde11b72dc20843a18fa51 > include/mesos/authorizer/authorizer.proto > b6a9f142eecbdfd59210872a92e3126f04de334c > src/authorizer/local/authorizer.cpp > f1dff65d973fc84f4171f68fd0391a2343a96965 > src/master/http.cpp bb9c87327dfe2161a6f1fd4cded72aa9a5ffaf66 > src/master/master.hpp 881f0d6127c4d6a7fccb1677fb3129310777f737 > src/master/master.cpp 3c6b18ead44cd5f2978093f5415e974cfcbfa714 > src/master/quota_handler.cpp d87d6c6266ba596c4e6bd36124f5a360428fe171 > src/master/weights_handler.cpp c240fb2980a7e957136d11ddd3f43ee4761a07dc > src/tests/authorization_tests.cpp 5d7e17b67821357b8cb538798acc883945c8f8fd > > Diff: https://reviews.apache.org/r/52600/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
