Re: Review Request 53974: Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53974/#review156552 --- Bad patch! Reviews applied: [53974, 53939, 53837, 53938, 53936,

Re: Review Request 53805: Updated libprocess test to use new 'Socket::shutdown' parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53805/ --- (Updated Nov. 22, 2016, 7:12 a.m.) Review request for mesos, Benjamin Mahler

Review Request 53975: Moved server socket deletion in 'process::finalize()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53975/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Bugs: MESOS-5966

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/ --- (Updated Nov. 22, 2016, 6:54 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53817: Added missing cleanup to libprocess 'finalize()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53817/ --- (Updated Nov. 22, 2016, 6:47 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 53974: Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53974/ --- Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 53837: Added a per container io switchboard server process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 22, 2016, 6:35 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53262: Added DNT to Powered by Mesos list.

> On 十一月 22, 2016, 1:33 a.m., Benjamin Mahler wrote: > > Ship It! > > Benjamin Mahler wrote: > One more thought, is it possible to have someone from DNT submit this as > a PR or review request? That helps us "vet" that the users indeed want to be > listed, and it helps them get authorship

Re: Review Request 53491: Disabled tests relying on filtering HTTP events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53491/#review156543 --- Patch looks great! Reviews applied: [53481, 53482, 53483, 53484,

Re: Review Request 53645: Added '--task' into mesos-execute.

> On Nov. 19, 2016, 5:23 p.m., Vinod Kone wrote: > > Ship It! > > Vinod Kone wrote: > Can you rebase the review? > > Vinod Kone wrote: > Do you have perms to commit these reviews yourself? If yes, do you want > to give it a shot? > > This is my typical commit workflow: >

Re: Review Request 53262: Added DNT to Powered by Mesos list.

> On Nov. 22, 2016, 1:33 a.m., Benjamin Mahler wrote: > > Ship It! One more thought, is it possible to have someone from DNT submit this as a PR or review request? That helps us "vet" that the users indeed want to be listed, and it helps them get authorship recognition. :) - Benjamin

Re: Review Request 53262: Added DNT to Powered by Mesos list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53262/#review156539 --- Ship it! Ship It! - Benjamin Mahler On Nov. 21, 2016, 10:06

Re: Review Request 53485: Introduced a `readAll()` helper on `http::Pipe::Reader`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53485/ --- (Updated Nov. 22, 2016, 12:35 a.m.) Review request for mesos and Benjamin

Re: Review Request 53487: Wired the libprocess code to use the streaming decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53487/ --- (Updated Nov. 22, 2016, 12:28 a.m.) Review request for mesos and Benjamin

Re: Review Request 53491: Disabled tests relying on filtering HTTP events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53491/ --- (Updated Nov. 22, 2016, 12:27 a.m.) Review request for mesos and Benjamin

Re: Review Request 53487: Wired the libprocess code to use the streaming decoder.

> On Nov. 21, 2016, 8:36 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 3657-3682 > > > > > > Can you add a TODO (in a separate patch) that we should handle > > discarded responses by

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/#review156518 --- Patch looks great! Reviews applied: [53885, 53886, 53887, 53888,

Re: Review Request 53490: Added a test for request streaming and GZIP compression.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53490/ --- (Updated Nov. 21, 2016, 10:43 p.m.) Review request for mesos and Benjamin

Re: Review Request 53486: Introduced a streaming request decoder in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53486/ --- (Updated Nov. 21, 2016, 10:39 p.m.) Review request for mesos and Benjamin

Re: Review Request 53762: CMake: Renamed MESOS_TARGET to MESOS_LIBS_TARGET.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53762/ --- (Updated Nov. 21, 2016, 2:15 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 53754: CMake: Added test modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53754/ --- (Updated Nov. 21, 2016, 2:13 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 53327: CMake: Added build variables for Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53327/ --- (Updated Nov. 21, 2016, 2:08 p.m.) Review request for mesos, Alex Clemmer and

Review Request 53961: CMake: Move test-specific variables into StoutTestsConfigure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53961/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53963: CMake: Use StoutTestsConfigure for test-specific variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53963/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53962: CMake: Remove test-specific variables from ProcessTestsConfigure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53962/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Re: Review Request 53262: Added DNT to Powered by Mesos list.

> On 十一月 21, 2016, 6 p.m., Benjamin Mahler wrote: > > Looks good, did they ask to be listed? Yes, they have a D-DCOS running on top of Mesos and asked me to add them to this list. - Guangya --- This is an automatically generated

Re: Review Request 53262: Added DNT to Powered by Mesos list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53262/ --- (Updated 十一月 21, 2016, 10:06 p.m.) Review request for mesos and Benjamin

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Nov. 21, 2016, 9:27 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53890: Tweaked usage of `getFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53890/ --- (Updated Nov. 21, 2016, 9:26 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53950: Avoided hardcoding ports in some tests.

> On Nov. 21, 2016, 8:01 p.m., Gastón Kleiman wrote: > > `src/tests/containerizer/port_mapping_tests.cpp` also uses a hard-coded > > port (they were the "inspiration" behind tht health check tests), I guess > > we should update those as well. Thanks for the pointer, these tests look indeed

Re: Review Request 53487: Wired the libprocess code to use the streaming decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53487/#review156500 --- Fix it, then Ship it! The structure of visit looks better now,

Re: Review Request 53950: Avoided hardcoding ports in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53950/#review156501 --- Patch looks great! Reviews applied: [53948, 53949, 53950]

Re: Review Request 53761: CMake: Add a target between MESOS_TARGET and MESOS_PROTOBUFs.

> On Nov. 17, 2016, 9:13 a.m., Alex Clemmer wrote: > > cmake/MesosConfigure.cmake, line 145 > > > > > > Hmm, can you explain the decision to add `ALL` here? It's not clear to > > me what the implications are. The

Re: Review Request 53929: Improved performance for `getQuotaRoleAllocatedResources` in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53929/#review156494 --- I pushed the change since this is cleaner and it looks like you

Re: Review Request 53759: CMake: Change libprocess to a shared library.

> On Nov. 17, 2016, 9:09 a.m., Alex Clemmer wrote: > > 3rdparty/libprocess/src/CMakeLists.txt, line 93 > > > > > > Seems like this should be using `MESOS_DEFAULT_LIBRARY_LINKAGE`? Nope, Mesos variables shouldn't be

Re: Review Request 53487: Wired the libprocess code to use the streaming decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53487/ --- (Updated Nov. 21, 2016, 7:25 p.m.) Review request for mesos and Benjamin

Re: Review Request 53756: CMake: Added logrotate container logger module to the build.

> On Nov. 17, 2016, 9:19 a.m., Alex Clemmer wrote: > > src/slave/container_loggers/CMakeLists.txt, line 25 > > > > > > For my own education, this must be shared, rather than > > `MESOS_DEFAULT_LIBRARY_LINKAGE`? Or

Re: Review Request 53929: Improved performance for `getQuotaRoleAllocatedResources` in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53929/#review156491 --- Ship it! Ship It! - Benjamin Mahler On Nov. 19, 2016, 2:44

Re: Review Request 53950: Avoided hardcoding ports in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53950/#review156489 --- `src/tests/containerizer/port_mapping_tests.cpp` also uses a

Re: Review Request 53327: CMake: Added build variables for Mesos tests.

> On Nov. 17, 2016, 8:56 a.m., Alex Clemmer wrote: > > src/tests/cmake/MesosTestsConfigure.cmake, lines 70-71 > > > > > > It's debatable, I think, whether we should be re-defining these for > > every test package.

Re: Review Request 53479: Perform GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/#review156481 --- Thanks for fixing this! It would be great to include some of the

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/ --- (Updated Nov. 21, 2016, 7:43 p.m.) Review request for mesos and Alexander

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/ --- (Updated Nov. 21, 2016, 7:40 p.m.) Review request for mesos and Alexander

Re: Review Request 53805: Updated libprocess test to use new 'Socket::shutdown' parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53805/#review156477 --- Ship it! 3rdparty/libprocess/src/tests/http_tests.cpp (line

Re: Review Request 53804: Added a parameter to 'Socket::shutdown' to specify 'how'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53804/#review156476 --- 3rdparty/libprocess/include/process/socket.hpp (lines 330 - 332)

Review Request 53948: Added missing include to test/utils.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53948/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 53949: Added test helper to obtain free port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-6618

Review Request 53950: Avoided hardcoding ports in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53950/ --- Review request for mesos, Alexander Rukletsov and haosdent huang. Bugs:

Re: Review Request 53262: Added DNT to Powered by Mesos list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53262/#review156473 --- Looks good, did they ask to be listed? - Benjamin Mahler On

Re: Review Request 53804: Added a parameter to 'Socket::shutdown' to specify 'how'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53804/#review156474 --- Fix it, then Ship it!

Re: Review Request 53957: Fix mesos-execute default content type flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53957/#review156472 --- Ship it! Ship It! - Vinod Kone On Nov. 21, 2016, 5:04 p.m.,

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/#review156471 --- Patch looks great! Reviews applied: [53885, 53886, 53887, 53888,

Re: Review Request 53645: Added '--task' into mesos-execute.

> On Nov. 19, 2016, 9:23 a.m., Vinod Kone wrote: > > Ship It! > > Vinod Kone wrote: > Can you rebase the review? Do you have perms to commit these reviews yourself? If yes, do you want to give it a shot? This is my typical commit workflow: $ git checkout master $ git pull origin $

Re: Review Request 53957: Fix mesos-execute default content type flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53957/ --- (Updated Nov. 21, 2016, 5:04 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 53624: Add a content type option to mesos-execute.

> On Nov. 21, 2016, 2:13 a.m., Qian Zhang wrote: > > src/cli/execute.cpp, line 807 > > > > > > I see the default value of `flags.content_type` is "json", so should we > > change this line to `mesos::ContentType

Review Request 53957: Fix mesos-execute default content type flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53957/ --- Review request for mesos, Qian Zhang and Vinod Kone. Repository: mesos

Re: Review Request 53837: Added a per container io switchboard server process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 21, 2016, 4:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53837: Added a per container io switchboard server process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 21, 2016, 4:30 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53541: Added authorization actions for debug API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- (Updated Nov. 21, 2016, 5:25 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Nov. 21, 2016, 4:21 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53574: Made `CommandExecutorTest.NoTransitionFromKillingToRunning` more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53574/#review156461 --- Patch looks great! Reviews applied: [53573, 53574] Passed

Re: Review Request 51431: Added health check support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51431/#review156456 --- src/cli/execute.cpp (lines 270 - 271)

Re: Review Request 51431: Added health check support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51431/ --- (Updated Nov. 21, 2016, 1:23 p.m.) Review request for mesos. Bugs:

Re: Review Request 53573: Added the kill policy test helper.

> On Nov. 19, 2016, 4:01 a.m., Alexander Rukletsov wrote: > > src/tests/kill_policy_test_helper.cpp, line 60 > > > > > > You don't use `os::sleep` on purpose? I thought that the nanosecond precision would be a bit

Re: Review Request 53574: Made `CommandExecutorTest.NoTransitionFromKillingToRunning` more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53574/ --- (Updated Nov. 21, 2016, 1 p.m.) Review request for mesos and Alexander

Re: Review Request 53573: Added the kill policy test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53573/ --- (Updated Nov. 21, 2016, 12:59 p.m.) Review request for mesos and Alexander

Re: Review Request 53573: Added the kill policy test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53573/ --- (Updated Nov. 21, 2016, 12:58 p.m.) Review request for mesos and Alexander

Re: Review Request 53939: Added implementation for containerizer 'attach()' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53939/#review156447 --- Bad patch! Reviews applied: [53939, 53837, 53938, 53936, 53704]

Re: Review Request 53938: Added helper to get the io switchboard server address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53938/ --- (Updated Nov. 21, 2016, 8:51 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53939: Added implementation for containerizer 'attach()' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53939/ --- (Updated Nov. 21, 2016, 8:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53837: Added a per container io switchboard server process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 21, 2016, 8:48 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156446 --- Patch looks great! Reviews applied: [53825] Passed command:

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Nov. 21, 2016, 8:11 a.m.) Review request for mesos, Greg Mann, Jie