Re: Review Request 55255: Added a test to check 'roles' is included in the `/state`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55255/ --- (Updated Jan. 16, 2017, 3:03 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 55253: Added 'roles' section in the response of `/state` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55253/ --- (Updated Jan. 16, 2017, 2:31 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 55254: Inserted `getRoles` to `getState`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55254/ --- (Updated Jan. 16, 2017, 2:31 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 55252: Refactored `roles()` and `getRoles()` to reuse common logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55252/ --- (Updated Jan. 16, 2017, 2:30 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 55554: Fixed a typo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review161680 --- Patch looks great! Reviews applied: [4] Passed command:

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review161678 --- I wonder how we deal with default role `*` in multi-role

Re: Review Request 55381: Added test for framework upgrading to multi-role capability.

> On Jan. 16, 2017, 12:37 p.m., Jay Guo wrote: > > src/tests/master_validation_tests.cpp, line 2559 > > > > > > I think this test is not valid since we currently don't have logic to > > check framework upgrade

Re: Review Request 55381: Added test for framework upgrading to multi-role capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55381/#review161676 --- src/tests/master_validation_tests.cpp (line 2559)

Review Request 55554: Fixed a typo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/ --- Review request for mesos, Benjamin Mahler and Guangya Liu. Repository: mesos

Re: Review Request 55548: Used `os::environment` instead of `os::raw::environment` in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55548/ --- (Updated Jan. 16, 2017, 2:25 a.m.) Review request for mesos, Andrew

Re: Review Request 55461: Made resource reservation validation multi-role aware.

> On Jan. 13, 2017, 4:17 p.m., Jay Guo wrote: > > When a resource with `*` is offered to a multi-role framework, how does the > > framework decide which role to reserve the resource for? > > Benjamin Bannier wrote: > Frameworks with default role cannot reserve resources; this is the first

Re: Review Request 55461: Made resource reservation validation multi-role aware.

> On Jan. 13, 2017, 4:15 p.m., Jay Guo wrote: > > src/master/master.cpp, lines 3944-3950 > > > > > > I think we explicitly disallow empyt role field? > >

Re: Review Request 55547: Windows: Standardize on win32 environment, transition away from CRT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55547/ --- (Updated Jan. 15, 2017, 9:44 p.m.) Review request for mesos, Andrew

Review Request 55550: Windows: Enabled health checker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/0/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Review Request 55549: Windows: Added health checker to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55549/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Review Request 55548: Used `os::environment` instead of `os::raw::environment` in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55548/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Review Request 55547: Windows: Standardize on win32 environment, transition away from CRT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55547/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Review Request 55546: Added platform-independent constants `DEV_NULL` and `TRUE_COMMAND`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55546/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

> On Dec. 24, 2016, 10:06 p.m., Daniel Pravat wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1611 > > > > > > This code was working before. you should not change it to make the > > taest work and

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55023/ --- (Updated Jan. 15, 2017, 10:46 a.m.) Review request for mesos, Andrew

Re: Review Request 55022: Windows: Cause errors to be correctly reported in `io::read`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55022/ --- (Updated Jan. 15, 2017, 10:23 a.m.) Review request for mesos, Andrew

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 15, 2017, 10:17 a.m.) Review request for mesos, Andrew

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/#review161660 --- Fix it, then Ship it! This is great. Could you make sure to

Re: Review Request 55489: Used CMake to generate the compilation database instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55489/#review161662 --- Ship it! - Benjamin Bannier On Jan. 14, 2017, 9:01 p.m.,

Re: Review Request 55544: Windows: Set `MAXHOSTNAMELEN` to an appropriate value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55544/#review161661 --- Bad patch! Reviews applied: [55544, 55543, 55328, 55327, 55314,

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 15, 2017, 9:22 a.m.) Review request for mesos, Andrew

Review Request 55543: Fail the build if %PreferredToolArchitecture% is not set to `x64`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55543/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Review Request 55544: Windows: Set `MAXHOSTNAMELEN` to an appropriate value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55544/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 15, 2017, 9:02 a.m.) Review request for mesos, Andrew

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 15, 2017, 9 a.m.) Review request for mesos, Andrew

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

> On Dec. 27, 2016, 2:12 p.m., Till Toenshoff wrote: > > src/slave/containerizer/mesos/launch.cpp, line 148 > > > > > > By not adding `syswow64` we are excluding 32bit runnables, is this > > intentional and

Re: Review Request 55030: CMake: Added source groups for libprocess build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55030/ --- (Updated Jan. 15, 2017, 8:47 a.m.) Review request for mesos, Andrew

Re: Review Request 55024: Windows: Start the socket stack in `process::initialize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55024/ --- (Updated Jan. 15, 2017, 8:46 a.m.) Review request for mesos, Andrew

Re: Review Request 55024: Windows: Start the socket stack in `process::initialize`.

> On Jan. 11, 2017, 2:19 a.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/process.cpp, line 1046 > > > > > > s/teard down/teardown/ > > > > `process::finalize` should probably perform the socket

Re: Review Request 55327: Windows: Fixed hanging symlink bug in `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55327/ --- (Updated Jan. 15, 2017, 8:40 a.m.) Review request for mesos, Andrew