----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review161678 -----------------------------------------------------------
I wonder how we deal with default role `*` in multi-role scenario? I remember that we require `*` to be explicitly specified for a multi-role framework, is that still true? src/master/master.cpp (line 2478) <https://reviews.apache.org/r/55271/#comment232995> I think we don't necessarily have `framework` here if framework information hasn't been reconstructed from agent failover yet. See https://github.com/apache/mesos/blob/master/src/master/master.cpp#L2563-L2571 I feel that we need to introduce a cross-checking validation that checks "new" frameworkInfo against "old" one if available. And this may be done in `updateFrameworkInfo`? src/master/master.cpp (lines 2491 - 2492) <https://reviews.apache.org/r/55271/#comment232996> Note that you could use `framework.capabilities` here since https://reviews.apache.org/r/55021/ is landed. - Jay Guo On Jan. 12, 2017, 11:32 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55271/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2017, 11:32 p.m.) > > > Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. > > > Bugs: MESOS-6631 > https://issues.apache.org/jira/browse/MESOS-6631 > > > Repository: mesos > > > Description > ------- > > We currently do not allow `MULTI_ROLE` frameworks to change their > roles. This restriction will be lifted later. > > > Diffs > ----- > > src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040 > src/tests/master_validation_tests.cpp > e5d55e03648cb218d42adc594d6fa7d40ea9bcbb > > Diff: https://reviews.apache.org/r/55271/diff/ > > > Testing > ------- > > Tested on various Linux configurations in internal CI. > > > Thanks, > > Benjamin Bannier > >
