Re: Review Request 57624: Modified an erroneous comment in the Master API proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57624/#review168968 --- Patch looks great! Reviews applied: [57624] Passed command:

Review Request 57631: Augmented a test to check protobuf::stripAllocationInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57631/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7048

Review Request 57630: Renamed `adjustOfferOperation` to `injectAllocationInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57630/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7048

Re: Review Request 57340: Remove adjustment code within Resources::apply.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/ --- (Updated March 15, 2017, 11:26 a.m.) Review request for mesos and Benjamin

Re: Review Request 57629: Fixed a webui bug where the maintenance tab is not shown as active.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57629/#review168966 --- Ship it! Ship It! - haosdent huang On March 15, 2017, 2:06

Review Request 57629: Fixed a webui bug where the maintenance tab is not shown as active.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57629/ --- Review request for mesos, haosdent huang and Joseph Wu. Repository: mesos

Re: Review Request 57622: Introduced a Roles tab in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/ --- (Updated March 15, 2017, 2:05 a.m.) Review request for mesos, Jay Guo, Michael

Re: Review Request 57427: Added authorization for PULL_CONTAINER_IMAGE agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57427/#review168963 --- Bad patch! Reviews applied: [57427, 57426, 57425] Failed

Re: Review Request 57535: Applied RegisterAgent ACL to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57535/ --- (Updated March 14, 2017, 6:09 p.m.) Review request for mesos, Adam B, Anindya

Re: Review Request 57535: Applied RegisterAgent ACL to the master.

> On March 14, 2017, 5:08 p.m., Anindya Sinha wrote: > > src/master/master.hpp > > Lines 686 (patched) > > > > > > nit: s/authorizeSlave/authorizeAgent? This is for the sake of consistency. The master

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

> On March 14, 2017, 4:05 p.m., Anindya Sinha wrote: > > include/mesos/authorizer/acls.proto > > Line 440 (original), 450 (patched) > > > > > > Not your change, but maybe move that down so the ids are in ascending

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/ --- (Updated March 14, 2017, 5:40 p.m.) Review request for mesos, Adam B, Anindya

Re: Review Request 57535: Applied RegisterAgent ACL to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57535/#review168951 --- include/mesos/authorizer/acls.proto Line 459 (original), 459

Re: Review Request 57622: Introduced a Roles tab in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/#review168958 --- src/webui/master/static/roles.html Lines 15 (patched)

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review168955 --- Ship it! Committing soon with the following minor edits.

Re: Review Request 57340: Remove adjustment code within Resources::apply.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/#review168954 --- Patch looks great! Reviews applied: [57340] Passed command:

Re: Review Request 53264: Added test for CNI port-mapper plugin.

> On Feb. 28, 2017, 4:42 a.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 1093-1097 (patched) > > > > > > Instead of that, can we use `__MESOS_TEST__2`? > > Avinash sridharan wrote:

Re: Review Request 53264: Added test for CNI port-mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53264/ --- (Updated March 14, 2017, 11:13 p.m.) Review request for mesos, Jie Yu and Qian

Review Request 57628: Added a utility function to get back non-loopback address on the host.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57628/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6022

Re: Review Request 57627: Modified CNI isolator to treat "__MESOST_TEST__*" as a test network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57627/ --- (Updated March 14, 2017, 11:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review168940 --- include/mesos/authorizer/acls.proto Line 440 (original), 450

Review Request 57627: Modified CNI isolator to treat "__MESOST_TEST__*" as a test network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57627/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 57623: Updated the maintenance tab in the webui to auto-refresh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57623/ --- Review request for mesos, haosdent huang and Joseph Wu. Repository: mesos

Review Request 57622: Introduced a Roles tab in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/ --- Review request for mesos, Jay Guo, Michael Park, and Neil Conway. Bugs:

Review Request 57624: Modified an erroneous comment in the Master API proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57624/ --- Review request for mesos and Zhitao Li. Repository: mesos Description

Re: Review Request 57167: Updated quota handler logic for hierarchical roles.

> On March 8, 2017, 10:38 a.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 78 (patched) > > > > > > The general pattern for `validate` I think is to return an > > `Option`. In this case, we could

Re: Review Request 56474: Added the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/ --- (Updated March 14, 2017, 9:36 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 57608: Augmented master api test to check `GetRoles` is included.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57608/#review168938 --- Patch looks great! Reviews applied: [55252, 55253, 57592, 57605,

Re: Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57491/#review168929 --- Ship it! I can fix those above nits before committing. -

Re: Review Request 57490: Windows: Add Glog patch for enabling stack trace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57490/#review168928 --- Ship it! LGTM! Verified a couple of artificially added CHECK

Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/#review168925 --- Patch looks great! Reviews applied: [56474, 56476, 56475]

Review Request 57535: Applied RegisterAgent ACL to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57535/ --- Review request for mesos, Adam B, Anindya Sinha, Greg Mann, and Vinod Kone.

Re: Review Request 56213: Added check tests for command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56213/#review168922 --- src/tests/check_tests.cpp Lines 74 (patched)

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/ --- (Updated March 14, 2017, 11:17 a.m.) Review request for mesos, Adam B, Anindya

Re: Review Request 57340: Remove adjustment code within Resources::apply.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/ --- (Updated March 15, 2017, 1:39 a.m.) Review request for mesos and Benjamin

Re: Review Request 53074: Updated pylint to rebuild 'virtualenv' when necessary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53074/#review168917 --- Ship it! Ship It! - Joseph Wu On March 12, 2017, 4:35 p.m.,

Re: Review Request 57340: Remove adjustment code within Resources::apply.

> On March 14, 2017, 7:03 a.m., Benjamin Mahler wrote: > > Looks good, the changes to resources.cpp were done how? Are they a direct > > reversion to the old code? Yes, I did a `git revert` and apply changes based on that. > On March 14, 2017, 7:03 a.m., Benjamin Mahler wrote: > >

Re: Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57491/#review168916 --- 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake Lines

Review Request 57607: Added `GetRoles` to `GetState` API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57607/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6855

Review Request 57608: Augmented master api test to check `GetRoles` is included.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57608/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6855

Review Request 57606: Extracted some logic from `getRoles` into `_getRoles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57606/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6855

Review Request 57605: Added `GetRoles` to `GetState` in master.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57605/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6855

Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/ --- (Updated March 14, 2017, 5:07 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56476/ --- (Updated March 14, 2017, 5:07 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56474: Added the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/ --- (Updated March 14, 2017, 5:07 p.m.) Review request for mesos, Alexander Rojas,

Review Request 57597: Added comments regarding exit status on Windows vs. Posix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57597/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Re: Review Request 56213: Added check tests for command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56213/ --- (Updated March 14, 2017, 2:09 p.m.) Review request for mesos, Gastón Kleiman

Review Request 57598: Added comment regarding exit status on Windows vs. Posix in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57598/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Re: Review Request 56212: Added support for general checks to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56212/ --- (Updated March 14, 2017, 2:09 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57150: Simplified task id procurement in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57150/ --- (Updated March 14, 2017, 2:08 p.m.) Review request for mesos, Gastón Kleiman

Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57596/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906

Re: Review Request 56210: Reused previous task status for health updates in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56210/ --- (Updated March 14, 2017, 2:07 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56211: Renamed health checker in command executor for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56211/ --- (Updated March 14, 2017, 2:07 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57149: Added a warning if command executor gets an unknown acknowledgement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57149/ --- (Updated March 14, 2017, 2:06 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56208: Updated checks library with general check support.

> On March 1, 2017, 8:23 p.m., Vinod Kone wrote: > > src/checks/checker.cpp > > Line 424 (original), 440 (patched) > > > > > > why are we sending WEXITSTATUS and not exit code? > > Alexander Rukletsov wrote: >

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated March 14, 2017, 2:05 p.m.) Review request for mesos, Gastón Kleiman

Review Request 57594: Added a helper for building a task status from scratch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57594/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Re: Review Request 57394: Overloaded `<<` for `CheckInfo::Type`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57394/ --- (Updated March 14, 2017, 2:05 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56016: Added a note about task status updates in scheduler and internal API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56016/ --- (Updated March 14, 2017, 2:05 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56017: Added a helper for building a task status from an existing one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/ --- (Updated March 14, 2017, 2:05 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57593: Sorted enum values in `authorizer.proto` by numerical order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57593/#review16 --- Ship it! Ship It! - Vinod Kone On March 14, 2017, 11:20

Re: Review Request 57593: Sorted enum values in `authorizer.proto` by numerical order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57593/#review168887 --- Ship it! Ship It! - Alexander Rukletsov On March 14, 2017,

Re: Review Request 57386: Introduced changes to the authz protos needed for RemoveNestedContainer.

> On March 13, 2017, 9:15 p.m., Jiang Yan Xu wrote: > > include/mesos/authorizer/authorizer.proto > > Lines 174 (patched) > > > > > > The comment above says > > > > ``` > > // NOTE: Values in this enum

Review Request 57593: Sorted enum values in `authorizer.proto` by numerical order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57593/ --- Review request for mesos, Alexander Rukletsov, Vinod Kone, and Jiang Yan Xu.

Re: Review Request 57560: Removed unnecessary curly braces wrapping case statements.

> On March 13, 2017, 8:28 p.m., Jiang Yan Xu wrote: > > What's the criteria for deeming such braces necessary or not? Some switch > > cases in authorizer.cpp are left with braces. These cases are long of > > course, but is this the critera used and "how long/complex is too > > long/complex"?

Review Request 57592: Augmented a master test to check `roles` in `/state` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57592/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6855

Re: Review Request 55253: Added `roles` to `/state` endpoint of master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55253/ --- (Updated March 14, 2017, 6:29 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 55252: Moved some logic from `Master::Http::_roles` into `filterRoles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55252/ --- (Updated March 14, 2017, 6:29 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 56208: Updated checks library with general check support.

> On March 1, 2017, 8:23 p.m., Vinod Kone wrote: > > src/checks/checker.cpp > > Line 424 (original), 440 (patched) > > > > > > why are we sending WEXITSTATUS and not exit code? > > Alexander Rukletsov wrote: >