Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/#review172581 --- Fix it, then Ship it! I think this is ready to go.

Re: Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57730/ --- (Updated April 20, 2017, 10:10 p.m.) Review request for mesos and Anindya

Re: Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL.

> On April 11, 2017, 2:11 a.m., Adam B wrote: > > src/tests/script.cpp > > Lines 161 (patched) > > > > > > We don't even enable agent authentication in most(/any?) tests, so I'd > > expect the agents to try to

Re: Review Request 57535: Applied RegisterAgent ACL to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57535/ --- (Updated April 20, 2017, 9:53 p.m.) Review request for mesos, Adam B, Anindya

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated April 21, 2017, 4:32 a.m.) Review request for mesos, Benjamin

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated April 21, 2017, 3:55 a.m.) Review request for mesos, Benjamin

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

> On April 20, 2017, 9:35 a.m., Michael Park wrote: > > src/master/allocator/sorter/drf/sorter.hpp > > Line 263 (original), 380 (patched) > > > > > > `s/DRFComparator/compare/`? > > > > We typically name

Re: Review Request 53840: Metric in the allocator to track latency between allocation cycles.

> On April 20, 2017, 6:04 p.m., James Peach wrote: > > If I understand this correctly, this is publishing a time series of the > > idle time between allocator runs. Is that correct? If so, what insight does > > this metric give and how should operators interpret it? Why is a simple > >

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58357/#review172551 --- Tested this out; works great!! Just a couple small things below.

Re: Review Request 53841: Added metrics for sorting of the sorters in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53841/#review172540 --- This also needs documentation added to the `docs/monitoring.md`.

Re: Review Request 53840: Metric in the allocator to track latency between allocation cycles.

> On April 20, 2017, 6:04 p.m., James Peach wrote: > > If I understand this correctly, this is publishing a time series of the > > idle time between allocator runs. Is that correct? If so, what insight does > > this metric give and how should operators interpret it? Why is a simple > >

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated April 20, 2017, 8:40 p.m.) Review request for mesos, Benjamin

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

> On April 20, 2017, 2:35 a.m., Michael Park wrote: > > src/master/allocator/sorter/drf/sorter.hpp > > Line 263 (original), 380 (patched) > > > > > > `s/DRFComparator/compare/`? > > > > We typically name

Re: Review Request 58512: Avoid a crash in HTTP decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/#review172532 --- Patch looks great! Reviews applied: [58580, 58512] Passed

Re: Review Request 58487: Fix allocation quantities when shared resources are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58487/#review172418 --- Do we need this? The method ``` virtual void update(

Re: Review Request 58584: Disabled support for setting quota on nested roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58584/ --- (Updated April 20, 2017, 6:18 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 58486: Fixed a race in `updateAllocation()` on DESTORY of a shared volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58486/#review172448 --- I feel the following may be more clear and general at high level.

Review Request 58584: Disabled support for quota on nested roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58584/ --- Review request for mesos, Benjamin Mahler, Jay Guo, and Michael Park.

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57516/ --- (Updated April 20, 2017, 6:14 p.m.) Review request for mesos, Benjamin

Re: Review Request 53840: Metric in the allocator to track latency between allocation cycles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53840/#review172526 --- If I understand this correctly, this is publishing a time series

Re: Review Request 58512: Avoid a crash in HTTP decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/ --- (Updated April 20, 2017, 5:40 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 58580: Mark decoder as failed when http parsing failed for any reason.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58580/ --- (Updated April 20, 2017, 5:40 p.m.) Review request for mesos and Anand

Re: Review Request 58512: Avoid a crash in HTTP decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/#review172520 --- Fix it, then Ship it! 3rdparty/libprocess/src/decoder.hpp

Re: Review Request 58580: Mark decoder as failed when http parsing failed for any reason.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58580/#review172519 --- Ship it! Ship It! - Anand Mazumdar On April 20, 2017, 5:18

Review Request 58580: Mark decoder as failed when http parsing failed for any reason.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58580/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 58512: Avoid a crash in HTTP decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/ --- (Updated April 20, 2017, 5:18 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 58512: Avoid a crash in HTTP decoder.

> On April 20, 2017, 4:06 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/src/decoder.hpp > > Lines 208 (patched) > > > > > > hmm, these seem not related to the review i.e., avoiding the crash. Can > > you

Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.

> On April 18, 2017, 8:19 p.m., Jeff Coffler wrote: > > Ship It! > > Andrew Schwartzmeyer wrote: > Hey, just wondering, why'd you give a "Ship It!" here, but then went back > to patches earlier in the chain and asked for test results (provided in the > patch previous to this)? > > Jeff

Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake.

> On April 18, 2017, 8:30 p.m., Jeff Coffler wrote: > > Big change, but important for us. > > > > I'd like you to comment on using cmake for zookeeper, specifically in terms > > of rolling that back to Zookeeper themselves for them to maintain it. > > > > Have you looked at contributing this

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

> On April 20, 2017, 9:35 a.m., Michael Park wrote: > > src/master/allocator/sorter/drf/sorter.hpp > > Line 263 (original), 380 (patched) > > > > > > `s/DRFComparator/compare/`? > > > > We typically name

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated April 20, 2017, 5:01 p.m.) Review request for mesos, Benjamin

Re: Review Request 58508: Introduced method `Resources::inheritable` to aggregate reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58508/ --- (Updated April 21, 2017, 12:18 a.m.) Review request for mesos and Michael

Re: Review Request 58512: Avoid a crash in HTTP decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/#review172504 --- 3rdparty/libprocess/src/decoder.hpp Lines 208 (patched)

Re: Review Request 58287: Print corresponding address when socket shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/#review172495 --- Patch looks great! Reviews applied: [58287] Passed command:

Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.

> On April 18, 2017, 8:19 p.m., Jeff Coffler wrote: > > Ship It! > > Andrew Schwartzmeyer wrote: > Hey, just wondering, why'd you give a "Ship It!" here, but then went back > to patches earlier in the chain and asked for test results (provided in the > patch previous to this)? I'd like

Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake.

> On April 18, 2017, 8:30 p.m., Jeff Coffler wrote: > > Big change, but important for us. > > > > I'd like you to comment on using cmake for zookeeper, specifically in terms > > of rolling that back to Zookeeper themselves for them to maintain it. > > > > Have you looked at contributing this

Re: Review Request 58561: Enabling automatic protobuf flag parsing (for mesos).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58561/#review172482 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 58557: Print failure reason when socket accept failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58557/#review172474 --- Patch looks great! Reviews applied: [58557] Passed command:

Re: Review Request 58196: Implemented TCP check support in command and default executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58196/#review172473 --- Fix it, then Ship it! src/checks/checker.cpp Lines 1104

Re: Review Request 58287: Print corresponding address when socket shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/ --- (Updated 四月 20, 2017, 11:34 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 58194: Hardened HTTP check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58194/#review172469 --- Ship it! Ship It! - Gastón Kleiman On April 19, 2017, 3:16

Review Request 58561: Enabling automatic protobuf flag parsing (for mesos).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58561/ --- Review request for mesos. Repository: mesos Description --- Enabling

Review Request 58560: Enabling automatic protobuf flag parsing (for stout).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58560/ --- Review request for mesos. Repository: mesos Description --- Enabling

Re: Review Request 58508: Introduced method `Resources::inheritable` to aggregate reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58508/#review172459 --- src/common/resources.cpp Lines 909 (patched)

Review Request 58557: Print failure reason when socket accept failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58557/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/#review172425 --- Overall, it's looking good! I think there are a few places where

Re: Review Request 58287: Print corresponding address when socket shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/ --- (Updated 四月 20, 2017, 9:09 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 58533: Added a benchmark test for hierarchical sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58533/#review172453 --- Bad review! Reviews applied: [58533, 57516, 57254, 58112, 58110,