Review Request 60258: Added runtime isolator environment test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60258/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7692

Re: Review Request 60254: Added missing `RESERVATION_REFINEMENT` capability to examples and tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60254/#review178446 --- Ship it! Ship It! - Neil Conway On June 20, 2017, 11:35

Re: Review Request 60253: Placed the `convertResourceFormat` calls after resource validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60253/#review178445 --- Ship it! These particular fixes seem fine (and I couldn't spot

Re: Review Request 60253: Placed the `convertResourceFormat` calls after resource validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60253/ --- (Updated June 20, 2017, 5:47 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 60038: Prevented allocating reservation refinements to non-capable frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60038/#review178444 --- FWIW, I find the commit message a bit confusing: "it's possible

Review Request 60255: Prevented reserve/create with refined reservation on non-capable agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60255/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Review Request 60253: Placed the `convertResourceFormat` calls after resource validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60253/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Re: Review Request 60253: Placed the `convertResourceFormat` calls after resource validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60253/ --- (Updated June 20, 2017, 4:35 p.m.) Review request for mesos and Neil Conway.

Review Request 60254: Added the `RESERVATION_REFINEMENT` capability to example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60254/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Review Request 60252: Fixed a bug that causes segfault in ProcessManager::finalize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60252/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Review Request 60250: Added the `RESERVATION_REFINEMENT` capability to `src/cli/execute.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60250/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7575

Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

> On June 20, 2017, 8:35 a.m., Benjamin Bannier wrote: > > I think this does not work as is since we would e.g., still reject commits > > where the commit summary is longer than 72 chars, e.g., the following > > commit summary should be considered formally okay, > > > > fixup fixup squash

Re: Review Request 60244: Tidied up lambda capture list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60244/#review178401 --- Ship it! Ship It! - Neil Conway On June 20, 2017, 2:22

Re: Review Request 60104: Added rebooted flag to RecoveryInfo and State.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60104/ --- (Updated June 20, 2017, 5:09 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60104: Added rebooted flag to RecoveryInfo and State.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60104/#review178394 --- src/slave/state.cpp Line 82 (original), 82 (patched)

Re: Review Request 60104: Added rebooted flag to RecoveryInfo and State.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60104/ --- (Updated June 20, 2017, 3:55 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60228: Linted support/apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60228/ --- (Updated June 20, 2017, 3:46 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 60227: Linted support/mesos-style.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60227/ --- (Updated June 20, 2017, 3:41 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 60103: Changed variable name _ack to statusUpdateAck.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60103/ --- (Updated June 20, 2017, 3:41 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60104: Added rebooted flag to RecoveryInfo and State.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60104/#review178320 --- src/slave/slave.hpp Lines 337 (patched)

Re: Review Request 60236: Linted support/verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60236/ --- (Updated June 20, 2017, 3:23 p.m.) Review request for mesos, Benjamin Bannier

Review Request 60244: Tidied up lambda capture list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60244/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Re: Review Request 60239: Fixed a signed / unsigned comparison in resources_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60239/#review178379 --- Ship it! - Andrei Budnik On June 20, 2017, 12:39 p.m., Jan

Re: Review Request 60124: Added a name to ballon framework to distinguish between instances.

> On June 15, 2017, 7:07 p.m., Armand Grillet wrote: > > src/examples/balloon_framework.cpp > > Line 464 (original), 469 (patched) > > > > > > Consistency wise, other tests have just `executor.set_name("Framework >

Re: Review Request 60123: Minor clean up of the balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60123/ --- (Updated June 20, 2017, 1:17 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 60239: Fixed a signed / unsigned comparison in resources_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60239/#review178376 --- Ship it! Ship It! - Till Toenshoff On June 20, 2017, 12:39

Re: Review Request 60239: Fixed a signed / unsigned comparison in resources_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60239/#review178375 --- Ship it! - Benjamin Bannier On June 20, 2017, 2:39 p.m., Jan

Re: Review Request 60227: Linted support/mesos-style.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60227/#review178374 --- support/mesos-style.py Line 90 (original), 115 (patched)

Re: Review Request 60228: Linted support/apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60228/#review178373 --- Fix it, then Ship it! support/apply-reviews.py Line 309

Review Request 60239: Fixed a signed / unsigned comparison in resources_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60239/ --- Review request for mesos, Andrei Budnik, Alexander Rukletsov, Michael Park, and

Re: Review Request 60236: Linted support/verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60236/#review178372 --- support/verify-reviews.py Lines 285-286 (patched)

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On Maj 11, 2017, 8:35 rano, Tomasz Janiszewski wrote: > > src/webui/master/static/browse.html > > Lines 17-20 (original), 17-20 (patched) > > > > > > How about usign `` here instead of list? Then `/` will be just

Re: Review Request 60236: Linted support/verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60236/#review178368 --- Fix it, then Ship it! support/verify-reviews.py Lines 64

Review Request 60236: Linted support/verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60236/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-6390

Review Request 60234: Linted support/push-commits.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60234/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-6390

Review Request 60235: Linted support/test-upgrade.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60235/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-6390

Review Request 60233: Linted support/post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60233/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-6390

Review Request 60231: Linted support/mesos-gtest-runner.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60231/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-6390

Review Request 60232: Linted support/mesos-split.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60232/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-6390

Review Request 60230: Linted support/jsonurl.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60230/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-6390

Review Request 60228: Linted support/apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60228/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-6390

Review Request 60229: Linted support/generate-endpoint-help.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60229/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-6390

Review Request 60227: Linted support/mesos-style.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60227/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-6390

Review Request 58380: CLI: Fixed 'threading' is not defined when invoking mesos-ps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58380/ --- Review request for mesos. Bugs: MESOS-7380

Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60216/#review178357 --- I think this does not work as is since we would e.g., still

Re: Review Request 60211: Added RESERVATION_REFINEMENT capability for example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60211/ --- (Updated June 20, 2017, 1:07 a.m.) Review request for mesos and Neil Conway.

Re: Review Request 60210: Disabled emitting unset fields with default values in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60210/ --- (Updated June 20, 2017, 1:04 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- (Updated June 20, 2017, 7:58 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58872/ --- (Updated June 20, 2017, 7:51 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58872/ --- (Updated June 20, 2017, 7:44 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 60169: Introduced a new agent flag 'cgroups_auto'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60169/#review178353 --- Ship it! Ship It! - haosdent huang On June 17, 2017, 4:58

Re: Review Request 60069: Adjusted the master to the new resources format [10/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60069/ --- (Updated June 20, 2017, 12:16 a.m.) Review request for mesos and Neil Conway.

Re: Review Request 60170: Supported 'cgroups_auto' flag in unified cgroup isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60170/#review178350 --- Ship it! Ship It! - haosdent huang On June 17, 2017, 4:58

Re: Review Request 60070: Adjusted the agent to the new resources format [11/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60070/#review178348 --- src/slave/paths.cpp Lines 478-481 (original), 479-482 (patched)

Re: Review Request 60069: Adjusted the master to the new resources format [10/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60069/#review178347 --- src/master/master.cpp Line 3613 (original), 3638 (patched)

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

> On May 9, 2017, 8:54 p.m., Benjamin Mahler wrote: > > Before you commit this, it would be great if you could test this (I can't > > tell how you tested this from the testing done section), e.g.: > > > > * Clicking on a link from the top level task page (state should already be > > loaded) >

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

> On May 9, 2017, 8:54 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js > > Lines 1016-1017 (patched) > > > > > > I'm a bit confused as to why we would want to set up the listener if we >