Review Request 62800: Created cgroups under systemd hierarchy in LinuxLauncher.

2017-10-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62800/ --- Review request for mesos, James Peach, Joris Van Remoortere, and Joseph Wu.

Review Request 62799: Fixed an issue for the I/O switchboard process lifetime.

2017-10-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62799/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: MESOS-8056

Review Request 62798: Added named cgroup hierarchy support.

2017-10-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62798/ --- Review request for mesos, James Peach and Joris Van Remoortere. Bugs:

Re: Review Request 60628: Enable fetcher_tests.cpp unit test module on Windows platform.

2017-10-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review187232 --- FAIL: Failed to apply the dependent review: 60292. Failed

Re: Review Request 60628: Enable fetcher_tests.cpp unit test module on Windows platform.

2017-10-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review187231 --- FAIL: Failed to apply the dependent review: 60292. Failed

Re: Review Request 60625: Normalize file separation characters on Windows when building path.

2017-10-05 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60625/ --- (Updated Oct. 6, 2017, 4:05 a.m.) Review request for mesos, Andrew

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-10-05 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/ --- (Updated Oct. 6, 2017, 4:04 a.m.) Review request for mesos, Andrew

Re: Review Request 60626: Eliminate os::shell calls from HDFS for Windows compatibility.

2017-10-05 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/ --- (Updated Oct. 6, 2017, 4:04 a.m.) Review request for mesos, Andrew

Re: Review Request 60623: Convert "file://" URI handling to use new uri function.

2017-10-05 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Oct. 6, 2017, 4:03 a.m.) Review request for mesos, Andrew

Re: Review Request 60624: Enable HDFS compilation and associated tests.

2017-10-05 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/ --- (Updated Oct. 6, 2017, 4:04 a.m.) Review request for mesos, Andrew

Re: Review Request 60628: Enable fetcher_tests.cpp unit test module on Windows platform.

2017-10-05 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/ --- (Updated Oct. 6, 2017, 4:04 a.m.) Review request for mesos, Andrew

Re: Review Request 60622: Add new stout functions for path normalizaiton and URI conversion.

2017-10-05 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/ --- (Updated Oct. 6, 2017, 4:03 a.m.) Review request for mesos, Andrew

Re: Review Request 60624: Enable HDFS compilation and associated tests.

2017-10-05 Thread Jeff Coffler
> On Aug. 15, 2017, 6:11 p.m., Andrew Schwartzmeyer wrote: > > src/launcher/fetcher.cpp > > Lines 267 (patched) > > > > > > This one is straight-forward. On Windows, there is no "executable > > permissions" so we

Re: Review Request 60621: Add new stout capability: os::copyfile.

2017-10-05 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/ --- (Updated Oct. 6, 2017, 4:03 a.m.) Review request for mesos, Andrew

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

2017-10-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/#review187225 --- src/slave/containerizer/mesos/containerizer.cpp Lines 1186-1202

Re: Review Request 62774: Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`.

2017-10-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62774/#review187218 --- Ship it! Ship It! - Vinod Kone On Oct. 4, 2017, 3:48 p.m.,

Re: Review Request 62327: Checked TASK_KILLED in the test `ROOT_INTERNET_CURL_PortMapper`.

2017-10-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62327/#review187217 --- Ship it! Ship It! - Vinod Kone On Sept. 14, 2017, 10:45

Re: Review Request 62214: Added JavaScript linter.

2017-10-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review187214 --- Patch looks great! Reviews applied: [62333, 62214] Passed

Re: Review Request 62287: Added Log::Reader::catchup() method.

2017-10-05 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62287/ --- (Updated Oct. 5, 2017, 1:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 62733: Organized configuration documentation.

2017-10-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62733/#review187210 --- FAIL: Failed to apply the dependent review: 62729. Failed

Re: Review Request 62733: Organized configuration documentation.

2017-10-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62733/#review187211 --- FAIL: Failed to apply the dependent review: 62729. Failed

Re: Review Request 62733: Organized configuration documentation.

2017-10-05 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62733/ --- (Updated Oct. 5, 2017, 12:01 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 62732: Added CMake documentation.

2017-10-05 Thread Andrew Schwartzmeyer
> On Oct. 2, 2017, 3:26 p.m., Joseph Wu wrote: > > docs/cmake.md > > Lines 42 (patched) > > > > > > Hm... The website's markdown generator is not super sophisticated, so > > I'm not sure if it will render this link

Re: Review Request 62732: Added CMake documentation.

2017-10-05 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62732/ --- (Updated Oct. 5, 2017, noon) Review request for mesos, Benjamin Bannier, Jeff

Re: Review Request 62793: Updated list of files excluded by Python linter.

2017-10-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62793/#review187208 --- PASS: Mesos patch 62793 was successfully built and tested.

Re: Review Request 62793: Updated list of files excluded by Python linter.

2017-10-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62793/#review187207 --- PASS: Mesos patch 62793 was successfully built and tested.

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

2017-10-05 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/#review187202 --- Fix it, then Ship it! This is fantastic, ship it!

Review Request 62793: Updated list of files excluded by Python linter.

2017-10-05 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62793/ --- Review request for mesos, Alexander Rukletsov and Kevin Klues. Repository:

Re: Review Request 62788: Added support/ to the list of the linted directories.

2017-10-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62788/#review187182 --- Ship it! Ship It! - Kevin Klues On Oct. 5, 2017, 2:01 p.m.,

Review Request 62788: Added support/ to the list of the linted directories.

2017-10-05 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62788/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6390

Re: Review Request 62214: Added JavaScript linter.

2017-10-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review187180 --- support/mesos-style.py Lines 356-361 (patched)

Re: Review Request 62214: Added JavaScript linter.

2017-10-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review187178 --- FAIL: Failed to apply the dependent review: 62333. Failed

Re: Review Request 62214: Added JavaScript linter.

2017-10-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review187176 --- FAIL: Failed to apply the dependent review: 62333. Failed

Re: Review Request 62777: Fixed build dependency for `protobuf_tests.proto`.

2017-10-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/#review187177 --- 3rdparty/stout/Makefile.am Line 218 (original), 219 (patched)

Re: Review Request 62333: Added helper functions for linters using a virtual environment.

2017-10-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62333/#review187174 --- Ship it! Ship It! - Kevin Klues On Sept. 29, 2017, 1:23

Re: Review Request 62333: Added helper functions for linters using a virtual environment.

2017-10-05 Thread Kevin Klues
> On Oct. 5, 2017, 1:31 p.m., Kevin Klues wrote: > > Ship It! I made a change locally to remove the `super(Pytlint, self)` calls where unnecessary. - Kevin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 62777: Fixed build dependency for `protobuf_tests.proto`.

2017-10-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/#review187173 --- 3rdparty/stout/Makefile.am Line 122 (original), 122 (patched)