Re: Review Request 63200: Added ContainerMountInfo to avoid pre_exec_commands for mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63200/ --- (Updated Oct. 21, 2017, 4:50 a.m.) Review request for mesos, Gilbert Song,

Review Request 63200: Added ContainerMountInfo to avoid pre_exec_commands for mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63200/ --- Review request for mesos, Gilbert Song, James Peach, and Joseph Wu.

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

> On Oct. 19, 2017, 6:38 p.m., Benjamin Mahler wrote: > > Thanks Yan! I will dig in soon. > > > > Just some quick questions: > > > > (1) I thought during the meeting you said it was taking a minute, but > > looking at all the benchmark timings they're all under a second? Is it only > > the

Re: Review Request 63190: Moved the search for the containerizer executable launch path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63190/#review188873 --- Ship it! Ship It! - Jie Yu On Oct. 20, 2017, 9:19 p.m.,

Re: Review Request 63191: Refactored entering the chroot in the container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63191/#review188872 --- Ship it! Ship It! - Jie Yu On Oct. 20, 2017, 9:20 p.m.,

Re: Review Request 63189: Refactored installing rlimits in the container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63189/#review188874 --- Ship it! Ship It! - Jie Yu On Oct. 20, 2017, 9:19 p.m.,

Re: Review Request 63183: Stopped awaiting the connected event in ports isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63183/#review188871 --- Patch looks great! Reviews applied: [63183] Passed command:

Review Request 63191: Refactored entering the chroot in the container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63191/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 63190: Moved the search for the containerizer executable launch path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63190/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 63189: Refactored installing rlimits in the container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63189/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 63018: Added filesystem layout for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63018/ --- (Updated Oct. 20, 2017, 8:28 p.m.) Review request for mesos, Jie Yu, Joseph

Re: Review Request 63021: Added functions to launch CSI plugin in storage local resource provider.

> On Oct. 20, 2017, 12:26 a.m., Jie Yu wrote: > > src/resource_provider/storage/provider.cpp > > Lines 237 (patched) > > > > > > I'd just use lambda here: > > ``` > > driver->send(evolve(call)) > >

Re: Review Request 63095: Added the Getting Started landing page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63095/#review188857 --- Ship it! Ship It! - Greg Mann On Oct. 18, 2017, 6:46 p.m.,

Re: Review Request 63177: Fixed 'SlaveRecoveryTest.RegisterDisconnectedSlave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63177/ --- (Updated Oct. 20, 2017, 4:58 p.m.) Review request for mesos and Alexander

Re: Review Request 63076: Windows: Fixed off-by-one error in long path support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63076/ --- (Updated Oct. 20, 2017, 9:57 a.m.) Review request for mesos, James Peach and

Re: Review Request 63177: Fixed 'SlaveRecoveryTest.RegisterDisconnectedSlave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63177/#review188850 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 20, 2017,

Re: Review Request 63076: Windows: Fixed off-by-one error in long path support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63076/#review188847 --- Fix it, then Ship it!

Re: Review Request 63183: Stopped awaiting the connected event in ports isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63183/#review188848 --- Ship it! Ship It! - Gaston Kleiman On Oct. 20, 2017, 9:27

Review Request 63183: Stopped awaiting the connected event in ports isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63183/ --- Review request for mesos, Alexander Rukletsov and Gaston Kleiman. Repository:

Re: Review Request 63104: Added a helper to extract resources from storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63104/#review188846 --- Ship it! Ship It! - Jie Yu On Oct. 20, 2017, 12:50 p.m.,

Re: Review Request 63107: Added operation feedback for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63107/#review188845 --- Bad patch! Reviews applied: [63107, 63106, 61947, 63105, 61946,

Re: Review Request 63177: Fixed 'SlaveRecoveryTest.RegisterDisconnectedSlave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63177/#review188839 --- PASS: Mesos patch 63177 was successfully built and tested.

Re: Review Request 63107: Added operation feedback for storage operations.

> On Oct. 19, 2017, 3:08 a.m., Jie Yu wrote: > > src/master/master.cpp > > Lines 7088-7089 (patched) > > > > > > This shouldn't be necessary. I need to update the allocator with updateSlave here to inform it about

Re: Review Request 63107: Added operation feedback for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63107/ --- (Updated Oct. 20, 2017, 2:56 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 61947: Implemented handling of resource provider offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61947/ --- (Updated Oct. 20, 2017, 2:54 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63105: Removed TODOs from storage operation 'apply' handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63105/ --- (Updated Oct. 20, 2017, 2:53 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 61810: Added a function to apply offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61810/ --- (Updated Oct. 20, 2017, 2:51 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63104: Added a helper to extract resources from storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63104/ --- (Updated Oct. 20, 2017, 2:50 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63094: Added resource version uuid for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/#review188829 --- src/messages/messages.proto Lines 613 (patched)

Re: Review Request 63177: Fixed 'SlaveRecoveryTest.RegisterDisconnectedSlave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63177/#review188828 --- Patch looks great! Reviews applied: [63177] Passed command:

Re: Review Request 63076: Windows: Fixed off-by-one error in long path support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63076/#review188827 --- PASS: Mesos patch 63076 was successfully built and tested.

Re: Review Request 63107: Added operation feedback for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63107/#review188826 --- src/master/master.cpp Lines 7088-7089 (patched)

Review Request 63177: Fixed 'SlaveRecoveryTest.RegisterDisconnectedSlave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63177/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63175/#review188824 --- PASS: Mesos patch 63175 was successfully built and tested.

Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63175/#review188823 --- Patch looks great! Reviews applied: [63175] Passed command:

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review188819 --- PASS: Mesos patch 63174 was successfully built and tested.

Re: Review Request 63076: Windows: Fixed off-by-one error in long path support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63076/#review188816 --- Patch looks great! Reviews applied: [63076] Passed command: