Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65311/#review196303 --- src/common/http.hpp Lines 38-39 (original), 39-44 (patched)

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196301 --- src/master/master.cpp Lines 5841-5850 (patched)

Re: Review Request 65000: Added an SLRP test for agent being registered with a new ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65000/ --- (Updated Jan. 25, 2018, 11:35 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65000: Added an SLRP test for agent being registered with a new ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65000/ --- (Updated Jan. 25, 2018, 11:27 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65000: Added an SLRP test for agent being registered with a new ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65000/ --- (Updated Jan. 25, 2018, 11:16 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 64297: Updated modules documentation with some more details.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64297/#review196296 --- PASS: Mesos patch 64297 was successfully built and tested.

Re: Review Request 65344: Updated the docs for agent ping timeout flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65344/#review196295 --- PASS: Mesos patch 65344 was successfully built and tested.

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65300/#review196291 --- docs/monitoring.md Lines 710-716 (patched)

Re: Review Request 64297: Updated modules documentation with some more details.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64297/#review196294 --- Ship it! Ship It! - Kapil Arya On Jan. 25, 2018, 5:16 p.m.,

Re: Review Request 64297: Updated modules documentation with some more details.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64297/ --- (Updated Jan. 25, 2018, 10:16 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 64297: Updated modules documentation with some more details.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64297/#review196293 --- docs/modules.md Lines 145 (patched)

Re: Review Request 65344: Updated the docs for agent ping timeout flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65344/#review196292 --- PASS: Mesos patch 65344 was successfully built and tested.

Re: Review Request 65032: Added a SLRP unit test for agent reboot.

> On Jan. 18, 2018, 6:49 p.m., Greg Mann wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1749 (patched) > > > > > > I'm curious why you place all expectations together in some tests, and >

Re: Review Request 64297: Updated modules documentation with some more details.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64297/ --- (Updated Jan. 25, 2018, 9:58 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 65062: Cleaned up endpoint directories after RP config agent API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65062/#review196287 --- src/tests/agent_resource_provider_config_api_tests.cpp Lines 202

Review Request 65344: Updated the docs for agent ping timeout flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65344/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Vinod Kone.

Re: Review Request 65294: Add revocable resources support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65294/#review196286 --- src/cli/execute.cpp Lines 1077-1082 (patched)

Re: Review Request 65061: Speeded up tests for resource provider config agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65061/#review196282 --- src/tests/agent_resource_provider_config_api_tests.cpp Line 222

Re: Review Request 65202: Adopted `DEFAULT_TEST_TIMEOUT` in Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/#review196283 --- FAIL: Some Mesos tests failed. Reviews applied: `['65201',

Re: Review Request 65223: Removed duplicated "/help" prefix in links in /help response.

> On Jan. 25, 2018, 2:53 a.m., Benjamin Mahler wrote: > > Hm.. I couldn't really follow from the ticket and desription here what the > > impact of the bug is, are there broken links? > > > > I just tested out /help on a cluster and the links are working, so is the > > issue something else?

Re: Review Request 65202: Adopted `DEFAULT_TEST_TIMEOUT` in Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/#review196278 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 65298: Split test flags into header and source files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65298/ --- (Updated Jan. 25, 2018, 7:29 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65333: Fixed errors in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65333/#review196277 --- Fix it, then Ship it!

Re: Review Request 65332: Tested that a CSI persistent volume can be used after recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65332/#review196276 --- Ship it! Ship It! - Greg Mann On Jan. 25, 2018, 1:56 a.m.,

Review Request 65343: Adopted `DEFAULT_TEST_TIMEOUT` in libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65343/ --- Review request for mesos, Benjamin Bannier and Gaston Kleiman. Bugs:

Re: Review Request 65000: Added an SLRP test for agent being registered with a new ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65000/#review196274 --- Fix it, then Ship it!

Re: Review Request 64574: Updated libprocess routing to treat trailing '/' as insignificant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64574/ --- (Updated Jan. 25, 2018, 7:03 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 64574: Updated libprocess routing to treat trailing '/' as insignificant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64574/ --- (Updated Jan. 25, 2018, 6:47 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

> On Jan. 24, 2018, 5:02 p.m., Michael Park wrote: > > I would prefer a more general, systematic approach to this situation. > > I really don't want to be deal with adding `string` and `const char []` > > overloads everywhere. Ideally, we'd have a `string_view` class that we > > could use

Re: Review Request 65314: Removed code which is not used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65314/#review196270 --- FAIL: Some Mesos tests failed. Reviews applied: `['65310',

Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

> On Jan. 22, 2018, 9:08 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/gtest.hpp > > Line 249 (original), 251 (patched) > > > > > > We don't really fully qualify the names here, but instead

Re: Review Request 65314: Removed code which is not used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65314/#review196265 --- FAIL: Some Mesos tests failed. Reviews applied: `['65310',

Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65322/ --- (Updated Jan. 25, 2018, 5:17 p.m.) Review request for mesos, Benno Evers, Till

Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65322/#review196262 --- PASS: Mesos patch 65322 was successfully built and tested.

Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65322/#review196260 --- Fix it, then Ship it! 3rdparty/stout/include/stout/numify.hpp

Re: Review Request 65310: Added lambda::zip.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65310/ --- (Updated Jan. 25, 2018, 4:34 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65322/#review196259 --- PASS: Mesos patch 65322 was successfully built and tested.

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65189/#review196258 --- Ship it! Ship It! - Till Toenshoff On Jan. 25, 2018, 8:40

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Oct. 31, 2017, 1:53 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/memory_profiler.hpp > > Lines 56-62 (patched) > > > > > > When I read 'dump' I think it will write some things to output

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196252 --- PASS: Mesos patch 65045 was successfully built and tested.

Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.

> On Jan. 25, 2018, 2:18 p.m., Benno Evers wrote: > > 3rdparty/stout/include/stout/numify.hpp > > Lines 34 (patched) > > > > > > Its not your comment, but this point sounds like a red herring to me: > > We're always

Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65322/ --- (Updated Jan. 25, 2018, 3:32 p.m.) Review request for mesos, Benno Evers, Till

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Nov. 10, 2017, 4:31 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 44-52 (patched) > > > > > > My gut feeling is that this will not fly on Windows. Is the plan to > >

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196244 --- PASS: Mesos patch 65045 was successfully built and tested.

Re: Review Request 65334: Added quota limit to the master API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/#review196242 --- include/mesos/quota/quota.proto Lines 38-50 (original), 30-34

Re: Review Request 65280: Fixed make clean without Python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65280/#review196241 --- Ship it! Ship It! - Benno Evers On Jan. 23, 2018, 4:08

Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65322/#review196239 --- Fix it, then Ship it! 3rdparty/stout/include/stout/numify.hpp

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Jan. 25, 2018, 2:10 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Jan. 25, 2018, 1:24 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/#review196237 --- PASS: Mesos patch 65246 was successfully built and tested.

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/ --- (Updated Jan. 25, 2018, 10:44 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Jan. 25, 2018, 11:36 a.m.) Review request for mesos, Benjamin

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65189/#review196231 --- Ship it! Ship It! - Armand Grillet On Jan. 25, 2018, 8:40

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65189/#review196229 --- PASS: Mesos patch 65189 was successfully built and tested.

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 24, 2018, 8:17 p.m., Gaston Kleiman wrote: > > src/master/http.cpp > > Line 3933 (original), 3961 (patched) > > > > > > Shouldn't we add a similar method: `Master:Http:OPERATIONS_HELP()`?

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65189/ --- (Updated Jan. 25, 2018, 9:40 a.m.) Review request for mesos, Armand Grillet

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65189/#review196221 --- support/apply-reviews.py Lines 274-275 (patched)