Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210021 --- src/tests/fetcher_tests.cpp Line 120 (original), 132 (patched)

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 11:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely

Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`.

> On Oct. 24, 2018, 5:22 p.m., Benjamin Mahler wrote: > > src/tests/allocator.hpp > > Lines 40-45 (patched) > > > > > > I think we some other create helpers lying around, e.g. createTask. Is > > this where these

Re: Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark.

> On Oct. 24, 2018, 5:20 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Line 234 (original), 234 (patched) > > > > > > Hm.. how were you able to change this while it remained

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review210017 --- PASS: Mesos patch 69110 was successfully built and tested.

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 4:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely

Re: Review Request 69149: Automatically remounted read-only bind mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69149/#review210014 --- PASS: Mesos patch 69149 was successfully built and tested.

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review210013 --- PASS: Mesos patch 68957 was successfully built and tested.

Re: Review Request 69110: Added task health check definitions to master API responses.

> On Oct. 23, 2018, 8:56 a.m., Alexander Rukletsov wrote: > > src/tests/health_check_tests.cpp > > Lines 460-466 (patched) > > > > > > What do you think about moving this blob to `AgentAPITest::GetState`? > > It

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 25, 2018, 12:51 a.m.) Review request for mesos, Alexander

Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69096/#review210010 --- Fix it, then Ship it! src/tests/allocator.hpp Lines 40-45

Re: Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69093/#review210007 --- src/tests/hierarchical_allocator_benchmarks.cpp Line 234

Re: Review Request 69095: Added `hierarchical_allocator_benchmarks.cpp` to `CMakeLists.txt`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69095/#review210009 --- Ship it! Ship It! - Benjamin Mahler On Oct. 20, 2018, 1:27

Re: Review Request 69094: Renamed one allocator benchmark to be more descriptive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69094/#review210008 --- Ship it! Ship It! - Benjamin Mahler On Oct. 20, 2018, 1:27

Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69092/#review210006 --- Hm.. I don't understand what this is doing. Is this setting

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210005 --- PASS: Mesos patch 69146 was successfully built and tested.

Review Request 69149: Automatically remounted read-only bind mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69149/ --- Review request for mesos, Gilbert Song, Ilya Pronin, Jie Yu, and Jiang Yan Xu.

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 24, 2018, 11:46 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 11:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/ --- (Updated Oct. 24, 2018, 11:46 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68953: Refactor allocator configuration into a struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/ --- (Updated Oct. 24, 2018, 11:46 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 4:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 11:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 4:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review21 --- Fix it, then Ship it! src/tests/fetcher_tests.cpp Lines

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/ --- (Updated Oct. 24, 2018, 4:12 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/ --- (Updated Oct. 24, 2018, 11:08 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 24, 2018, 11:08 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68953: Refactor allocator configuration into a struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/ --- (Updated Oct. 24, 2018, 11:08 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69085/ --- (Updated Oct. 24, 2018, 11:02 p.m.) Review request for mesos, Benjamin

Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`.

> On Oct. 24, 2018, 8:50 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/mkdir.hpp > > Lines 63 (patched) > > > > > > We need to reset `errno` before invoking `::mkdir` to make sure we > >

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209996 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/ --- Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Repository: mesos

Re: Review Request 68953: Refactor allocator configuration into a struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/ --- (Updated Oct. 24, 2018, 10:17 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 24, 2018, 10:17 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/ --- (Updated Oct. 24, 2018, 10:17 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209995 --- FAIL: Failed to apply the dependent review: 68956. Failed

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review209994 --- PASS: Mesos patch 69082 was successfully built and tested.

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

> On Oct. 23, 2018, 11:35 p.m., James Peach wrote: > > src/master/metrics.hpp > > Line 223 (original), 223 (patched) > > > > > > We don't need the `explicit` here anymore. Fixed. - Jacob

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

> On Oct. 24, 2018, 2:55 a.m., Greg Mann wrote: > > src/master/flags.cpp > > Lines 686-689 (patched) > > > > > > We generally use the same text here and in the markdown/html > > documentation. Could you update this

Re: Review Request 68953: Refactor allocator configuration into a struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/ --- (Updated Oct. 24, 2018, 9:38 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

> On Oct. 24, 2018, 2:45 a.m., Greg Mann wrote: > > Just a couple style nits below, sorry for the late review. Done. > On Oct. 24, 2018, 2:45 a.m., Greg Mann wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 268 (original), 269-272 (patched) > >

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 24, 2018, 9:38 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/ --- (Updated Oct. 24, 2018, 9:38 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68953: Refactor allocator configuration into a struct.

> On Oct. 24, 2018, 2:51 a.m., Greg Mann wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 188 (patched) > > > > > > Nit: indented too far. Fixed. > On Oct. 24, 2018, 2:51 a.m., Greg Mann wrote: > >

Re: Review Request 68957: Add documentation for per-framework metrics flag.

> On Oct. 23, 2018, 11:42 p.m., James Peach wrote: > > docs/configuration/master.md > > Lines 667 (patched) > > > > > > This should be in alphabetical order. Fixed. - Jacob

Re: Review Request 69109: Updated libprocess to log all socket errors consistently.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69109/#review209993 --- Ship it! Ship It! - Gastón Kleiman On Oct. 21, 2018, 4:40

Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69085/#review209984 --- 3rdparty/stout/include/stout/os/posix/mkdir.hpp Lines 63

Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`.

> On Oct. 22, 2018, 8:05 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/mkdir.hpp > > Lines 75 (patched) > > > > > > I am not sure we should abort on the first error here. Many documented >

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209982 --- Ship it! Ship It! - Benjamin Bannier On Oct. 18, 2018, 4:01

Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/ --- Review request for mesos, Chun-Hung Hsiao and Alex Clemmer. Repository: mesos

Re: Review Request 69138: Updated 'CLI_FILES' in 'cli_new/CmakeLists.txt'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69138/#review209977 --- Patch looks great! Reviews applied: [69138] Passed command:

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209976 --- We could probably do away with some of the double-negatives (i.e.

Re: Review Request 69132: Used mount(8) to make XFS loop device mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69132/#review209975 --- PASS: Mesos patch 69132 was successfully built and tested.

Re: Review Request 68812: Added example framework for inverse-offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68812/#review209970 --- Fix it, then Ship it! Please also add it to CMakeLists!

Re: Review Request 69132: Used mount(8) to make XFS loop device mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69132/ --- (Updated Oct. 24, 2018, 3:41 p.m.) Review request for mesos, Ilya Pronin,

Re: Review Request 69132: Used mount(8) to make XFS loop device mounts.

> On Oct. 24, 2018, 12:59 a.m., Ilya Pronin wrote: > > src/tests/containerizer/xfs_quota_tests.cpp > > Lines 147-152 (original), 147-164 (patched) > > > > > > The command looks the same in both cases, the only

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209962 --- PASS: Mesos patch 69140 was successfully built and tested.

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209956 --- 3rdparty/cmake/FindLIBARCHIVE.cmake Lines 19 (patched)

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209953 --- 3rdparty/CMakeLists.txt Line 998 (original), 998 (patched)

Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, James Peach,

Re: Review Request 69138: Updated 'CLI_FILES' in 'cli_new/CmakeLists.txt'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69138/#review209951 --- PASS: Mesos patch 69138 was successfully built and tested.

Review Request 69138: Updated 'CLI_FILES' in 'cli_new/CmakeLists.txt'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69138/ --- Review request for mesos, Benjamin Bannier and Kevin Klues. Bugs: MESOS-9350