Re: Review Request 69405: Refactored createAuthorizationCallbacks into common/authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69405/#review210698 --- PASS: Mesos patch 69405 was successfully built and tested.

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/#review210695 --- src/master/master.cpp Lines 8192-8201 (patched)

Review Request 69405: Refactored createAuthorizationCallbacks into common/authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69405/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Greg Mann.

Re: Review Request 69384: Introduced common/authorization and refactored collectAuthorizations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69384/ --- (Updated Nov. 20, 2018, 2:26 a.m.) Review request for mesos, Alexander

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69162/#review210694 --- include/mesos/scheduler/scheduler.proto Line 140 (original), 140

Re: Review Request 69403: Removed empty filters in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69403/#review210696 --- PASS: Mesos patch 69403 was successfully built and tested.

Re: Review Request 69157: Fixed handling for offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/#review210692 --- src/slave/slave.cpp Line 8017 (original), 8017 (patched)

Re: Review Request 69366: Used `OperationID` instead of `string` in test helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69366/#review210691 --- PASS: Mesos patch 69366 was successfully built and tested.

Review Request 69403: Removed empty filters in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69403/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/ --- (Updated Nov. 19, 2018, 11:35 p.m.) Review request for mesos, Benjamin Bannier

Review Request 69402: Fixed `CreateVolume` of the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69402/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-9275

Review Request 69400: Refactored the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69400/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-9275

Re: Review Request 69362: Checkpointed creation parameters for CSI volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69362/ --- (Updated Nov. 19, 2018, 11:30 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69356: Added valiadtion for `Offer.Operation.CreateDisk.target_profile`.

> On Nov. 16, 2018, 12:01 p.m., Benjamin Bannier wrote: > > src/master/validation.cpp > > Lines 2531-2535 (patched) > > > > > > I wonder whether performing this validation in the master is the right > > thing to

Re: Review Request 69356: Added valiadtion for `Offer.Operation.CreateDisk.target_profile`.

> On Nov. 16, 2018, 1:01 p.m., Benjamin Bannier wrote: > > src/master/validation.cpp > > Lines 2531-2535 (patched) > > > > > > I wonder whether performing this validation in the master is the right > > thing to

Re: Review Request 69377: Added blog post for Mesos Mini.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69377/#review210685 --- PASS: Mesos patch 69377 was successfully built and tested. All

Re: Review Request 69356: Added valiadtion for `Offer.Operation.CreateDisk.target_profile`.

> On Nov. 16, 2018, 12:01 p.m., Benjamin Bannier wrote: > > src/master/validation.cpp > > Lines 2531-2535 (patched) > > > > > > I wonder whether performing this validation in the master is the right > > thing to

Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/#review210610 --- This patch seems to contain at the same time 1) addition of the

Re: Review Request 69362: Checkpointed creation parameters for CSI volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69362/#review210600 --- This patch fails to compile without r/69363, could you move the

Re: Review Request 69362: Checkpointed creation parameters for CSI volumes.

> On Nov. 19, 2018, 9:48 p.m., Benjamin Bannier wrote: > > This patch fails to compile without r/69363, could you move the needed > > changes from there into this patch? Just reordered. Is that okay? > On Nov. 19, 2018, 9:48 p.m., Benjamin Bannier wrote: > > src/csi/state.proto > > Lines 46

Re: Review Request 69362: Checkpointed creation parameters for CSI volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69362/ --- (Updated Nov. 19, 2018, 9:29 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69366: Used `OperationID` instead of `string` in test helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69366/ --- (Updated Nov. 19, 2018, 9:51 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69366: Used `OperationID` instead of `string` in test helpers.

> On Nov. 16, 2018, 8:32 a.m., Benjamin Bannier wrote: > > The commit message talks about `profile` -- could you fix that? The description was accurate: if we passed in operation ID, then compiler will reject the following call: ``` CREATE_DISK(source, Resource::DiskInfo::Source::MOUNT,

Re: Review Request 69363: Cleaned up `include/mesos/type_utils.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69363/#review210682 --- Ship it! Ship It! - Benjamin Bannier On Nov. 19, 2018,

Re: Review Request 69363: Cleaned up `include/mesos/type_utils.hpp`.

> On Nov. 16, 2018, 3:28 p.m., Benjamin Bannier wrote: > > include/mesos/type_utils.hpp > > Lines 490 (patched) > > > > > > Not yours, just making an issue for visibility. Feel free to drop. > > > > Fits on

Re: Review Request 69363: Cleaned up `include/mesos/type_utils.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69363/ --- (Updated Nov. 19, 2018, 9:29 p.m.) Review request for mesos and Benjamin

Re: Review Request 69356: Added valiadtion for `Offer.Operation.CreateDisk.target_profile`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69356/ --- (Updated Nov. 19, 2018, 9:24 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69356: Added valiadtion for `Offer.Operation.CreateDisk.target_profile`.

> On Nov. 16, 2018, 12:01 p.m., Benjamin Bannier wrote: > > This patch breaks a number of tests. Could you make sure that they are > > updated with this patch or earlier? > > > > Please spell-check the commit message. Fixed the typo and the order. - Chun-Hung

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69359/ --- (Updated Nov. 19, 2018, 9:12 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69360: Rewrote test `ConvertPreExistingVolume` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69360/ --- (Updated Nov. 19, 2018, 9:19 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69357/ --- (Updated Nov. 19, 2018, 9:09 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

> On Nov. 16, 2018, 12:01 p.m., Benjamin Bannier wrote: > > Can you make sure that this patch does not produce any failing tests (might > > be triggered by earlier patch)? Done for most patches, except for r/69360 and r/69361. - Chun-Hung

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review210677 --- Patch looks great! Reviews applied: [68131] Passed command:

Re: Review Request 69377: Added blog post for Mesos Mini.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69377/ --- (Updated Nov. 19, 2018, 8:28 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 69377: Added blog post for Mesos Mini.

> On Nov. 19, 2018, 8:02 a.m., Joerg Schad wrote: > > site/source/blog/2018-11-19-mesos-mini.md > > Lines 12 (patched) > > > > > > s/Mesos/Mesos and Marathon ? Marathon is just an example framework. I mentioned

Re: Review Request 69356: Added valiadtion for `Offer.Operation.CreateDisk.target_profile`.

> On Nov. 16, 2018, 1:01 nachm., Benjamin Bannier wrote: > > src/master/validation.cpp > > Lines 2531-2535 (patched) > > > > > > I wonder whether performing this validation in the master is the right > > thing to

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

> On Nov. 16, 2018, 12:02 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Line 3899 (original), 3895 (patched) > > > > > > Before dereferencing `begin` we should

Re: Review Request 69360: Rewrote test `ConvertPreExistingVolume` for `CREATE_DISK`.

> On Nov. 16, 2018, 12:02 p.m., Benjamin Bannier wrote: > > This test does not pass for me, could you fix that? This modified test won't pass without the next patch. However, if we switch the order, the unmodified test won't pass. So no I cannot fix this, unfortunately :( - Chun-Hung

Re: Review Request 69386: Added test for ACCESS_MESOS_LOG authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69386/#review210672 --- Patch looks great! Reviews applied: [69368, 69369, 69384, 69385,

Re: Review Request 69356: Added valiadtion for `Offer.Operation.CreateDisk.target_profile`.

> On Nov. 16, 2018, 12:01 p.m., Benjamin Bannier wrote: > > src/master/validation.cpp > > Lines 2531-2535 (patched) > > > > > > I wonder whether performing this validation in the master is the right > > thing to

Re: Review Request 69398: Added validation for `FrameworkID`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69398/#review210666 --- PASS: Mesos patch 69398 was successfully built and tested.

Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69255/#review210664 --- Ship it! Ship It! - Kevin Klues On Nov. 5, 2018, 6:13

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/#review210662 --- src/python/cli_new/lib/cli/tests/task.py Lines 238 (patched)

Re: Review Request 69393: Displayed 'State' field when using 'mesos task list'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69393/ --- (Updated Nov. 19, 2018, 5:14 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 69393: Displayed 'State' field when using 'mesos task list'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69393/#review210660 --- src/python/cli_new/lib/cli/plugins/task/main.py Lines 125

Re: Review Request 69374: Updated new CLI test step to use binary created by PyInstaller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69374/#review210661 --- Ship it! I have made the changes listed above locally before

Review Request 69398: Added validation for `FrameworkID`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69398/ --- Review request for mesos and Meng Zhu. Bugs: MESOS-8470

Re: Review Request 69390: Added docs describing how to use the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69390/#review210659 --- docs/cli.md Lines 17 (patched)

Review Request 69397: Used high-level `FrameworkInfo` validation function in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69397/ --- Review request for mesos and Meng Zhu. Bugs: MESOS-8470

Re: Review Request 69381: Updated configuration docs describing how to build the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69381/#review210658 --- Ship it! Ship It! - Kevin Klues On Nov. 18, 2018, 5:58

Re: Review Request 69380: Added configuration docs describing how to use Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69380/#review210657 --- Ship it! Ship It! - Kevin Klues On Nov. 18, 2018, 5:58

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/#review210656 --- PASS: Mesos patch 69395 was successfully built and tested.

Re: Review Request 69374: Updated new CLI test step to use binary created by PyInstaller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69374/#review210655 --- src/Makefile.am Lines 2827 (patched)

Review Request 69395: Added '--all' flag to 'mesos task list'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9399

Review Request 69394: Updated 'mesos task list' to only display running tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69394/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9399

Review Request 69393: Displayed 'State' field when using 'mesos task list'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69393/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9399

Re: Review Request 69389: Added a test `ROOT_UNPRIVILEGED_USER_SandboxOwnership`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69389/#review210654 --- Ship it! Ship It! - Gilbert Song On Nov. 18, 2018, 11:33

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

> On Nov. 6, 2018, 12:19 p.m., Benno Evers wrote: > > src/tests/master_benchmarks.cpp > > Lines 616 (patched) > > > > > > Last time we tried running this benchmark, we discovered a dead-lock > > caused by the

Re: Review Request 69390: Added docs describing how to use the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69390/#review210651 --- PASS: Mesos patch 69390 was successfully built and tested.

Re: Review Request 69386: Added test for ACCESS_MESOS_LOG authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69386/#review210650 --- Ship it! Appreciate you cleaning up things around you even

Review Request 69390: Added docs describing how to use the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69390/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9333

Re: Review Request 69368: Added test reproducing crash on authorization failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69368/#review210649 --- src/tests/master_tests.cpp Line 10101 (original), 10101

Re: Review Request 69384: Introduced common/authorization and refactored collectAuthorizations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69384/#review210645 --- Fix it, then Ship it! src/master/weights_handler.cpp Lines 33

Re: Review Request 69385: Refactored createSubject and authorizeLogAccess to common/authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69385/#review210648 --- Fix it, then Ship it! src/common/http.cpp Lines 905-906

Re: Review Request 69389: Added a test `ROOT_UNPRIVILEGED_USER_SandboxOwnership`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69389/#review210647 --- PASS: Mesos patch 69389 was successfully built and tested.

Re: Review Request 69377: Added blog post for Mesos Mini.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69377/#review210643 --- site/source/blog/2018-11-19-mesos-mini.md Lines 12 (patched)

Re: Review Request 69377: Added blog post for Mesos Mini.

> On Nov. 19, 2018, 8:02 a.m., Joerg Schad wrote: > > Excited about this, just some nits! - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69377/#review210643