Re: Review Request 69818: Added offer filters to static framework configuration.

> On Jan. 29, 2019, 9:14 p.m., Benjamin Mahler wrote: > > src/common/resource_quantities.cpp > > Lines 82-90 (patched) > > > > > > Can we add some validation somewhere to ensure that negative value > > scalars are

Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69872/#review212476 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69871: Added more documentation for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69871/#review212475 --- PASS: Mesos patch 69871 was successfully built and tested.

Re: Review Request 69871: Added more documentation for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69871/#review212473 --- docs/high-availability-framework-guide.md Lines 254 (patched)

Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69872/#review212474 --- Fix it, then Ship it! src/slave/slave.cpp Lines 8119

Review Request 69872: Accounted for possible lack of OperationID in RP responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69872/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.

Re: Review Request 69869: [WIP] Added test for tearing down frameworks while creating disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69869/#review212472 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69866/#review212471 --- Patch looks great! Reviews applied: [69858, 69866] Passed

Review Request 69871: Added more documentation for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69871/ --- Review request for mesos, Benjamin Bannier, Gastón Kleiman, and James DeFelice.

Review Request 69869: [WIP] Added test for tearing down frameworks while creating disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69869/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs:

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69866/#review212469 --- PASS: Mesos patch 69866 was successfully built and tested.

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69866/ --- (Updated Jan. 30, 2019, 11:41 p.m.) Review request for mesos, Benjamin

Re: Review Request 69656: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69656/#review212468 --- Patch looks great! Reviews applied: [69656] Passed command:

Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69866/ --- Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.

Re: Review Request 69858: Persisted intentionally dropped operations in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69858/ --- (Updated Jan. 30, 2019, 10:35 p.m.) Review request for mesos, Benjamin

Re: Review Request 69858: Persisted intentionally dropped operations in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69858/#review212467 --- PASS: Mesos patch 69858 was successfully built and tested.

Re: Review Request 69863: Removed an unnecessary '.get()' from a master test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69863/#review212466 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69863: Removed an unnecessary '.get()' from a master test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69863/#review212465 --- Ship it! Ship It! - Joseph Wu On Jan. 30, 2019, 12:32 p.m.,

Re: Review Request 69863: Removed an unnecessary '.get()' from a master test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69863/#review212463 --- Ship it! Ship It! - Benjamin Bannier On Jan. 30, 2019, 9:32

Re: Review Request 69858: Persisted intentionally dropped operations in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69858/ --- (Updated Jan. 30, 2019, 8:32 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 69863: Removed an unnecessary '.get()' from a master test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69863/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Repository: mesos

Re: Review Request 69855: Added an example of Seccomp profile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69855/#review212459 --- Ship it! Ship It! - Gilbert Song On Jan. 29, 2019, 10:32

Re: Review Request 69820: Added containment check for `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69820/#review212458 --- Patch looks great! Reviews applied: [69861, 69818, 69819, 69820]

Re: Review Request 69820: Added containment check for `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69820/#review212457 --- PASS: Mesos patch 69820 was successfully built and tested.

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212456 --- PASS: Mesos patch 69821 was successfully built and tested.

Re: Review Request 69861: Declared `HierarchicalAllocatorProcess::allocatable` `const`.

> On Jan. 30, 2019, 5:09 p.m., Benjamin Mahler wrote: > > Thanks! Probably don't need the duplicate description in the commit message? > > Benjamin Bannier wrote: > The way we have our reviewboard interaction set up, not manually > adjusting a redundant description is actually the easier

Re: Review Request 69861: Declared `HierarchicalAllocatorProcess::allocatable` `const`.

> On Jan. 30, 2019, 4:09 p.m., Benjamin Mahler wrote: > > Thanks! Probably don't need the duplicate description in the commit message? > > Benjamin Bannier wrote: > The way we have our reviewboard interaction set up, not manually > adjusting a redundant description is actually the easier

Re: Review Request 69861: Declared `HierarchicalAllocatorProcess::allocatable` `const`.

> On Jan. 30, 2019, 5:09 p.m., Benjamin Mahler wrote: > > Thanks! Probably don't need the duplicate description in the commit message? The way we have our reviewboard interaction set up, not manually adjusting a redundant description is actually the easier way: During post-review it gets

Re: Review Request 69861: Declared `HierarchicalAllocatorProcess::allocatable` `const`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69861/#review212452 --- Ship it! Thanks! Probably don't need the duplicate description

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Jan. 30, 2019, 4:08 p.m.) Review request for mesos, Benjamin Mahler

Review Request 69862: Validated static framework offer filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69862/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9523

Re: Review Request 69818: Added offer filters to static framework configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/ --- (Updated Jan. 30, 2019, 4:04 p.m.) Review request for mesos, Benjamin Mahler

Review Request 69861: Declared `HierarchicalAllocatorProcess::allocatable` `const`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69861/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Repository: mesos

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212450 --- Patch looks great! Reviews applied: [69818, 69819, 69820, 69821]

Re: Review Request 69858: Persisted intentionally dropped operations in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69858/#review212448 --- PASS: Mesos patch 69858 was successfully built and tested.

Re: Review Request 69860: Disabled parallel test execution for reviewbot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69860/#review212442 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 30, 2019,

Review Request 69860: Disabled parallel test execution for reviewbot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69860/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository: