Re: Review Request 71080: Master should store the list of completed framework ids for lifecycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71080/#review216638 --- Bad patch! Reviews applied: [71080] Failed command: ['bash',

Re: Review Request 70887: Added `PendingFutureTracker` class for tracking pending futures.

> On July 15, 2019, 4:35 p.m., Qian Zhang wrote: > > src/common/future_track.hpp > > Lines 90 (patched) > > > > > > I'd suggest to use `Owned` instead of raw pointer. > > Andrei Budnik wrote: > I'd prefer to

Re: Review Request 70996: Implemented master endpoints for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70996/#review216636 --- Ship it! Ship It! - Greg Mann On July 15, 2019, 11:30 p.m.,

Re: Review Request 71069: Added end-to-end tests for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71069/#review216635 --- Patch looks great! Reviews applied: [70822, 70910, 70911, 70923,

Re: Review Request 70757: Added a NNP isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70757/ --- (Updated July 16, 2019, 1:57 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 71075: Windows: Fixed confusing name for command executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71075/#review216634 --- Ship it! Ship It! - Greg Mann On July 15, 2019, 6:59 p.m.,

Re: Review Request 71069: Added end-to-end tests for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71069/ --- (Updated July 16, 2019, 12:40 a.m.) Review request for mesos, Benno Evers and

Review Request 71080: Master should store the list of completed framework ids for lifecycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71080/ --- Review request for mesos, James Peach and Jiang Yan Xu. Bugs: MESOS-8636

Re: Review Request 71075: Windows: Fixed confusing name for command executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71075/#review216631 --- Patch looks great! Reviews applied: [71075] Passed command:

Re: Review Request 71008: Implemented transition from DRAINING to DRAINED in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71008/ --- (Updated July 15, 2019, 4:31 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70996: Implemented master endpoints for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70996/ --- (Updated July 15, 2019, 4:30 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 71073: Fixed /roles and GET_ROLES to expose all known roles.

> On July 15, 2019, 9:37 p.m., Meng Zhu wrote: > > Thanks for fixing this! > > > > The indentation of the bullet points in the commit message is a bit off. Seems to be reviewboard's rendering. > On July 15, 2019, 9:37 p.m., Meng Zhu wrote: > > src/master/master.cpp > > Lines 3531-3533

Re: Review Request 71008: Implemented transition from DRAINING to DRAINED in master.

> On July 15, 2019, 9:14 a.m., Benjamin Bannier wrote: > > src/master/master.cpp > > Lines 6255-6260 (patched) > > > > > > It seems we only do this check to make sure we can access the config > > below which

Re: Review Request 71008: Implemented transition from DRAINING to DRAINED in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71008/#review216626 --- src/master/master.cpp Lines 6271 (patched)

Re: Review Request 71077: Added a test to ensure that ancestor roles are exposed in /roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71077/#review216625 --- Ship it! Ship It! - Meng Zhu On July 15, 2019, 2:13 p.m.,

Re: Review Request 71078: Minor cleanups in role_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71078/#review216624 --- Ship it! Ship It! - Meng Zhu On July 15, 2019, 2:13 p.m.,

Re: Review Request 71074: Added a test to ensure that roles with only reservations are exposed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71074/#review216623 --- Ship it! Ship It! - Meng Zhu On July 15, 2019, 2:12 p.m.,

Re: Review Request 71035: Added test to verify that Docker executor can override kill policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71035/#review216622 --- Ship it! Ship It! - Joseph Wu On July 8, 2019, 11:28 a.m.,

Re: Review Request 71034: Enabled the Docker executor to accept kill policy overrides.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71034/#review216621 --- Fix it, then Ship it! src/docker/executor.cpp Lines 985-987

Re: Review Request 71073: Fixed /roles and GET_ROLES to expose all known roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71073/#review216617 --- Fix it, then Ship it! Thanks for fixing this! The indentation

Re: Review Request 71033: Moved the Docker executor declaration into a header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71033/#review216620 --- Fix it, then Ship it! src/Makefile.am Lines 1092 (patched)

Re: Review Request 71069: Added end-to-end test for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71069/#review216619 --- Bad patch! Reviews applied: [70822, 70910, 70911, 70923, 70956,

Review Request 71078: Minor cleanups in role_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71078/ --- Review request for mesos and Meng Zhu. Repository: mesos Description ---

Review Request 71077: Added a test to ensure that ancestor roles are exposed in /roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71077/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Bugs: MESOS-9890

Re: Review Request 71074: Added a test to ensure that roles with only reservations are exposed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71074/ --- (Updated July 15, 2019, 9:12 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71074: Updated a test to ensure that roles with only reservations are exposed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71074/#review216616 --- Actually, should instead add a separate test for this case (as

Review Request 71074: Updated a test to ensure that roles with only reservations are exposed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71074/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Bugs: MESOS-9888

Review Request 71073: Fixed /roles and GET_ROLES to expose all known roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71073/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Bugs: MESOS-9888 and

Re: Review Request 71008: Implemented transition from DRAINING to DRAINED in master.

> On July 15, 2019, 11:14 a.m., Benjamin Bannier wrote: > > src/master/master.cpp > > Lines 6255-6260 (patched) > > > > > > It seems we only do this check to make sure we can access the config > > below which

Review Request 71075: Windows: Fixed confusing name for command executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71075/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 71008: Implemented transition from DRAINING to DRAINED in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71008/ --- (Updated July 15, 2019, 11:19 a.m.) Review request for mesos, Benjamin

Re: Review Request 71008: Implemented transition from DRAINING to DRAINED in master.

> On July 15, 2019, 2:14 a.m., Benjamin Bannier wrote: > > src/master/master.cpp > > Lines 6255-6260 (patched) > > > > > > It seems we only do this check to make sure we can access the config > > below which

Re: Review Request 70959: Cleared agent drain state when draining is finished.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70959/#review216611 --- Ship it! Ship It! - Greg Mann On June 28, 2019, 9:27 a.m.,

Re: Review Request 71065: Implemented `FutureTrackTest` tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71065/#review216610 --- Patch looks great! Reviews applied: [70887, 70888, 70889, 70890,

Re: Review Request 70887: Added `PendingFutureTracker` class for tracking pending futures.

> On Июль 15, 2019, 8:35 д.п., Qian Zhang wrote: > > src/common/future_track.hpp > > Lines 90 (patched) > > > > > > I'd suggest to use `Owned` instead of raw pointer. I'd prefer to leave `Try` as it's more

Re: Review Request 70757: Added a NNP isolator.

> On Июль 15, 2019, 12:08 д.п., James Peach wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 1162 (patched) > > > > > > As per Andrei, if the message field is present, toggle the NNP flag > >

Re: Review Request 70757: Added a NNP isolator.

> On Июль 12, 2019, 5:46 п.п., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/linux/nnp.cpp > > Lines 71 (patched) > > > > > > What happens if a framework explicitly set `no_new_privileges` flag to

Re: Review Request 71008: Implemented transition from DRAINING to DRAINED in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71008/#review216605 --- src/master/master.cpp Lines 6238-6241 (patched)

Re: Review Request 70887: Added `PendingFutureTracker` class for tracking pending futures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70887/#review216603 --- src/Makefile.am Lines 1070 (patched)

Re: Review Request 71072: Renamed agent flag `--default_shm_size`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71072/#review216604 --- Patch looks great! Reviews applied: [71072] Passed command:

Review Request 71072: Renamed agent flag `--default_shm_size`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71072/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-9833