Re: Review Request 71341: Validated provider ID use in some resource provider calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71341/#review217420 --- Patch looks great! Reviews applied: [71339, 71340, 71341]

Re: Review Request 71343: Fixed out-of-order processing of terminal status updates in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71343/#review217419 --- Fix it, then Ship it! src/slave/slave.cpp Lines 10775-10776

Re: Review Request 71317: Added draining test for momentarily disconnected agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71317/#review217418 --- Fix it, then Ship it! Looks great! Just one small comment

Re: Review Request 71318: Added agent reactivations to the existing agent draining tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71318/ --- (Updated Aug. 23, 2019, 2:01 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 71318: Added agent reactivations to the existing agent draining tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71318/#review217416 --- Bad review! Reviews applied: [71318, 71317, 71316, 71315, 71314]

Re: Review Request 71357: Used boost `small_vector` in `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71357/#review217415 --- Fix it, then Ship it! include/mesos/resources.hpp Lines

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/#review217413 --- Fix it, then Ship it! src/common/resource_quantities.cpp

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/ --- (Updated Aug. 23, 2019, 12:44 p.m.) Review request for mesos and Benjamin

Re: Review Request 71357: Used boost `small_vector` in `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71357/ --- (Updated Aug. 23, 2019, 12:44 p.m.) Review request for mesos and Benjamin

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

> On Aug. 23, 2019, 11:38 a.m., Benjamin Mahler wrote: > > include/mesos/resource_quantities.hpp > > Lines 168-169 (patched) > > > > > > How will we know to update this if we have more first class resources? > >

Re: Review Request 71360: Optimized shrinkResources() by filtering before copying.

> On Aug. 23, 2019, 7:25 p.m., Benjamin Mahler wrote: > > src/common/resources_utils.cpp > > Line 915 (original), 915-917 (patched) > > > > > > It's not clear to me that this is less expensive, if every name is in

Re: Review Request 71360: Optimized shrinkResources() by filtering before copying.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71360/#review217410 --- src/common/resources_utils.cpp Line 915 (original), 915-917

Re: Review Request 71316: Added draining tests for empty agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71316/ --- (Updated Aug. 23, 2019, 12:22 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 71317: Added draining test for momentarily disconnected agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71317/ --- (Updated Aug. 23, 2019, 12:22 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 71360: Optimized shrinkResources() by filtering before copying.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71360/#review217409 --- src/common/resource_quantities.cpp Lines 183-197 (patched)

Re: Review Request 71179: WIP: Added a flag for running example framework with a list of roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71179/#review217407 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/#review217406 --- include/mesos/resource_quantities.hpp Lines 168-169 (patched)

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

> On Aug. 23, 2019, 6:24 p.m., Benjamin Mahler wrote: > > include/mesos/resource_quantities.hpp > > Lines 121-124 (original), 122-127 (patched) > > > > > > "small_vector is convertible to small_vector_base >

Re: Review Request 71355: Used boost `small_vector` in Resource Quantities and Limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/#review217404 --- include/mesos/resource_quantities.hpp Lines 121-124 (original),

Re: Review Request 71356: Updated the boost library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71356/#review217403 --- Ship it! Ship It! - Benjamin Mahler On Aug. 22, 2019, 11:58

Re: Review Request 71359: Optimized the allocation loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71359/#review217402 --- Ship it! Nice one!

Re: Review Request 71347: Optimized shrinkResources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71347/#review217401 --- Patch looks great! Reviews applied: [71353, 71354, 71347]

Re: Review Request 71178: Implemented displaying roles of multi-role frameworks as a tree.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71178/ --- (Updated Aug. 23, 2019, 5:34 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 71361: Added missing `return` statement in `Slave::statusUpdate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71361/#review217400 --- Ship it! Ship It! - Qian Zhang On Aug. 23, 2019, 8:57 p.m.,

Re: Review Request 71343: Fixed out-of-order processing of terminal status updates in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71343/#review217399 --- src/slave/slave.cpp Lines 6137-6138 (patched)

Review Request 71361: Added missing `return` statement in `Slave::statusUpdate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71361/ --- Review request for mesos, Gilbert Song, Greg Mann, and Qian Zhang. Repository:

Re: Review Request 71351: Sped up `ExampleTest.DiskFullFramework` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71351/ --- (Updated Aug. 23, 2019, 1:08 p.m.) Review request for mesos and Till

Re: Review Request 71350: Used `local` master in `ExampleTest.DiskFullFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71350/ --- (Updated Aug. 23, 2019, 1:08 p.m.) Review request for mesos and Till

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/#review217398 --- Patch looks great! Reviews applied: [71284, 71285] Passed

Re: Review Request 71351: Sped up `ExampleTest.DiskFullFramework` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71351/#review217396 --- Ship it! Ship It! - Jan Schlicht On Aug. 22, 2019, 3:17

Re: Review Request 71350: Used `local` master in `ExampleTest.DiskFullFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71350/#review217395 --- Fix it, then Ship it! src/tests/disk_full_framework_test.sh

Re: Review Request 71341: Validated provider ID use in some resource provider calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71341/#review217380 --- Ship it! Ship It! - Jan Schlicht On Aug. 22, 2019, 3:04

Re: Review Request 71335: Used cached cgroups for updating resources in Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71335/#review217394 --- Ship it! Ship It! - Gilbert Song On Aug. 21, 2019, 5:24

Re: Review Request 71318: Added agent reactivations to the existing agent draining tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71318/#review217393 --- Bad patch! Reviews applied: [71314, 71315, 71316, 71317, 71318]