Re: Review Request 68329: Windows: Made `libwinio` the default option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68329/#review207640 --- Ship it! Ship It! - Akash Gupta On Aug. 20, 2018, 10:11 p.m

Re: Review Request 68331: Windows: Made `libwinio` the default option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68331/#review207639 --- Ship it! Ship It! - Akash Gupta On Aug. 13, 2018, 10:35 p.m

Review Request 67832: Changed docker subprocess calls to use exec form.

CI for verification. On Linux, ran mesos-tests. Thanks, Akash Gupta

Re: Review Request 67685: Windows: Added `windows_to_unix_epoch` function.

7838bacabc4e2b9c92a5283f95543ee74b2d6505 3rdparty/stout/include/stout/windows/os.hpp 46cd667e88853fb0945ec5b14bd57319666895fc Diff: https://reviews.apache.org/r/67685/diff/2/ Changes: https://reviews.apache.org/r/67685/diff/1-2/ Testing --- Thanks, Akash Gupta

Re: Review Request 67391: Windows: Added CMake `ENABLE_LIBWINIO` flag for Windows IOCP backend.

, Akash Gupta

Re: Review Request 67390: Windows: Integrated libwinio with libprocess code.

/67390/diff/2/ Changes: https://reviews.apache.org/r/67390/diff/1-2/ Testing --- Thanks, Akash Gupta

Review Request 67685: Windows: Added `windows_to_unix_epoch` function.

075ad54ac694a11cb1e981a499e99c02cb734bc6 Diff: https://reviews.apache.org/r/67685/diff/1/ Testing --- Thanks, Akash Gupta

Re: Review Request 67388: Moved libprocess POSIX and Windows implementations to separate folders.

/diff/1-2/ Testing --- Thanks, Akash Gupta

Re: Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type.

://reviews.apache.org/r/67384/diff/2/ Changes: https://reviews.apache.org/r/67384/diff/1-2/ Testing --- Thanks, Akash Gupta

Re: Review Request 67587: Updated ZooKeeper retry logic to retry on `ENOENT` too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67587/#review205027 --- Ship it! Ship It! - Akash Gupta On June 13, 2018, 10:30 p.m

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

(patched) <https://reviews.apache.org/r/67394/#comment287066> Just curious but why is `forkImpl` needed instead of the old way? - Akash Gupta On May 31, 2018, 10:50 p.m., Radhika Jandhyala wrote: > > --- > This is a

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67287/#review204522 --- Ship it! Ship It! - Akash Gupta On May 24, 2018, 10:47 p.m

Re: Review Request 67286: White list fds that child processes can inherit in stout.

vector style is `const std::vector& whitelist_fds = {}` . - Akash Gupta On May 24, 2018, 10:47 p.m., Radhika Jandhyala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 67465: Windows: Log a fatal error if `WindowsFD(int)` is incorrectly used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67465/#review204502 --- Ship it! Ship It! - Akash Gupta On June 7, 2018, 9:59 p.m

Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

--- Thanks, Akash Gupta

Review Request 67456: Windows: Wrapped docker executor code in job object.

Diff: https://reviews.apache.org/r/67456/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 67455: Windows: Fixed incorrect return code for `os:kill`.

bdb83510b7f0529d41f8e895451a941dc22d21bb Diff: https://reviews.apache.org/r/67455/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 67395: Fixed socket creation bug in docker.cpp.

was confirmed to fix it. Thanks, Akash Gupta

Re: Review Request 67389: Windows: Implemented Windows IOCP async backend.

) <https://reviews.apache.org/r/67389/#comment286462> Radhika/Eric do you know a good number for this? I i was thinking of around $NCPUS. - Akash Gupta On May 30, 2018, 6:54 p.m., Akash Gupta wrote: > > --- > This is a

Re: Review Request 67389: Windows: Implemented Windows IOCP async backend.

) <https://reviews.apache.org/r/67389/#comment286460> Oops! Will delete this commented out code. - Akash Gupta On May 30, 2018, 6:54 p.m., Akash Gupta wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 67385: Windows: Added IOCP `HANDLE` to `WindowsFD`.

- 3rdparty/stout/include/stout/os/windows/dup.hpp 5bda095e676b038cdaea04f7be23ba2a1aca9015 3rdparty/stout/include/stout/os/windows/fd.hpp 5dbdff2680370d123579c5e3fdd9b0e0adaf512e Diff: https://reviews.apache.org/r/67385/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 67386: Added `io::prepare_async` and `io::is_async` functions for libprocess.

/libprocess/src/tests/subprocess_tests.cpp 568d77b94b3afef8c1ebdde71e14aa0b498da5c8 Diff: https://reviews.apache.org/r/67386/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 67387: Updated Mesos code to use `io::prepare_async`.

/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 67388: Moved: `io::internal::read/write` to separate file.

/src/io.cpp 97f2b17092fbd23528cf3220fee5927a1ec38aba 3rdparty/libprocess/src/io_internal.hpp PRE-CREATION 3rdparty/libprocess/src/poll_io.cpp PRE-CREATION Diff: https://reviews.apache.org/r/67388/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 67389: Windows: Implemented Windows IOCP async backend.

/libwinio_impl.hpp PRE-CREATION 3rdparty/libprocess/src/libwinio_impl.cpp PRE-CREATION Diff: https://reviews.apache.org/r/67389/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 67390: Windows: Integrated libwinio with libprocess code.

/libwinio_eventloop.cpp PRE-CREATION 3rdparty/libprocess/src/libwinio_io.cpp PRE-CREATION 3rdparty/libprocess/src/libwinio_socket.cpp PRE-CREATION Diff: https://reviews.apache.org/r/67390/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 67391: Windows: Added CMake `ENABLE_LIBWINIO` flag for Windows IOCP backend.

cf443dffd0663ecf02b7efd6f7094175b94aae19 cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d Diff: https://reviews.apache.org/r/67391/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 67392: Windows: Made PipeLargeOutput test work with IOCP backend.

--- Thanks, Akash Gupta

Review Request 67393: Windows: Ported io_tests.cpp.

--- Thanks, Akash Gupta

Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type.

the `HANDLE` type uniformly, so we need to be able to convert socket `int_fd` to `HANDLE`. Diffs - 3rdparty/stout/include/stout/os/windows/fd.hpp 5dbdff2680370d123579c5e3fdd9b0e0adaf512e Diff: https://reviews.apache.org/r/67384/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test.

/health_check_tests.cpp 7e8f86c903dfad73c2102eaf491fb2adcb7c11cf Diff: https://reviews.apache.org/r/67313/diff/1/ Testing --- Thanks, Akash Gupta

Re: Review Request 66962: Windows: Added tests for async IO functions.

--- Thanks, Akash Gupta

Re: Review Request 66961: Windows: Ported sendfile_tests.cpp.

/stout/tests/os/sendfile_tests.cpp 05966ae067ae3972598da3370eb16fdce5736c21 Diff: https://reviews.apache.org/r/66961/diff/2/ Changes: https://reviews.apache.org/r/66961/diff/1-2/ Testing --- Thanks, Akash Gupta

Re: Review Request 66960: Windows: Added async version of `os::sendfile`.

://reviews.apache.org/r/66960/diff/2/ Changes: https://reviews.apache.org/r/66960/diff/1-2/ Testing --- Thanks, Akash Gupta

Re: Review Request 66957: Windows: Enabled creating overlapped pipes with `os::pipe`.

/windows/pipe.hpp a3574fd6f2ff1608396b47cad8cbed88134a74ca Diff: https://reviews.apache.org/r/66957/diff/2/ Changes: https://reviews.apache.org/r/66957/diff/1-2/ Testing --- Thanks, Akash Gupta

Re: Review Request 66958: Windows: Fixed inheritance in subprocess_windows.cpp.

a1e6425faff01f816748f0b8b5307612b6dd8302 Diff: https://reviews.apache.org/r/66958/diff/2/ Changes: https://reviews.apache.org/r/66958/diff/1-2/ Testing --- Thanks, Akash Gupta

Re: Review Request 66956: Windows: Added overlapped support to `os::write`.

/66956/diff/2/ Changes: https://reviews.apache.org/r/66956/diff/1-2/ Testing --- Thanks, Akash Gupta

Re: Review Request 66955: Windows: Added overlapped support to `os::read`.

/66955/diff/2/ Changes: https://reviews.apache.org/r/66955/diff/1-2/ Testing --- Thanks, Akash Gupta

Re: Review Request 67243: Windows: Changed test image to custom nanoserver.

& 1803. Also, tested on Linux. Thanks, Akash Gupta

Review Request 67243: Windows: Changed test image to custom nanoserver.

/health_check_tests.cpp c4661b4f005c18a7cdc69ce05576bcccb79d5dee Diff: https://reviews.apache.org/r/67243/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 67208: Windows: Updated information on docker health checks.

c6f7144e9f62bf38799e1c66297f405be6fd5b30 Diff: https://reviews.apache.org/r/67208/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 67207: Windows: Changed health check image to be an environment variable.

7e484510b4fc2b94d4d4385dfa8f68bdd76e6093 src/tests/environment.cpp a30592ac6b0002dad0947086ecbfdf4e2db62da5 src/tests/health_check_tests.cpp c4661b4f005c18a7cdc69ce05576bcccb79d5dee Diff: https://reviews.apache.org/r/67207/diff/1/ Testing --- Thanks, Akash Gupta

Re: Review Request 66961: Windows: Ported sendfile_tests.cpp.

/sendfile_tests.cpp 05966ae067ae3972598da3370eb16fdce5736c21 Diff: https://reviews.apache.org/r/66961/diff/1/ Testing --- Thanks, Akash Gupta

Re: Review Request 66962: Windows: Added tests for async IO functions.

for the IOCP backend. These focus mainly on the stout changes. I'm currently cleaning up some libprocess code so that I can post the remaining half. - Akash Gupta On May 4, 2018, 5:27 p.m., Akash Gupta wrote: > > --- > This is an auto

Review Request 66962: Windows: Added tests for async IO functions.

- 3rdparty/stout/tests/os/filesystem_tests.cpp b17ab9aaa94ae14b6707a9ac7a54b9db38615f2a Diff: https://reviews.apache.org/r/66962/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 66954: Windows: Added overlapped aware io.hpp file for `os::read/write`.

, Akash Gupta

Review Request 66956: Windows: Added overlapped support to `os::write`.

` will do an overlapped write on an overlapped handle. Diffs - 3rdparty/stout/include/stout/os/windows/write.hpp 295c031c5824d13d74e2c9006e62c391d5020f69 Diff: https://reviews.apache.org/r/66956/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 66955: Windows: Added overlapped support to `os::read`.

` will do an overlapped read on an overlapped handle. Diffs - 3rdparty/stout/include/stout/os/windows/read.hpp e957da81e55867b260d356f035d98918b85d1965 Diff: https://reviews.apache.org/r/66955/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 66957: Windows: Enabled creating overlapped pipes with `os::pipe`.

--- Thanks, Akash Gupta

Review Request 66958: Windows: Fixed inheritance in subprocess_windows.cpp.

/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 66959: Windows: Fixed pipe inheritance in Mesos containerizer.

process should start running, so the pipe needs to be inheritable and not overlapped. Diffs - src/slave/containerizer/mesos/containerizer.cpp 01386ac3d36ec7a401b8d1be7834bc1f3fce55ef Diff: https://reviews.apache.org/r/66959/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 66960: Windows: Added async version of `os::sendfile`.

` function. The synchronous version simply calls the asynchronous version and waits. Diffs - 3rdparty/stout/include/stout/os/windows/sendfile.hpp 594d9c7beeff2766f59f16ba25986314f2f7ceb8 Diff: https://reviews.apache.org/r/66960/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 66961: Windows: Ported sendfile_tests.cpp.

` implementations, the tests are now ported. Diffs - 3rdparty/stout/tests/CMakeLists.txt 28674c9873b7bbccb6b990ec16b7e40a5bf4f9ec 3rdparty/stout/tests/os/sendfile_tests.cpp 05966ae067ae3972598da3370eb16fdce5736c21 Diff: https://reviews.apache.org/r/66961/diff/1/ Testing --- Thanks, Akash

Review Request 66953: Windows: Fixed dup to properly copy the overlapped WindowsFD.

/stout/include/stout/os/windows/dup.hpp af98054f1bd9c8e55c52b246fda8734e3ca96e21 Diff: https://reviews.apache.org/r/66953/diff/1/ Testing --- Thanks, Akash Gupta

Review Request 66952: Windows: Added overlapped field to WindowsFD.

--- Thanks, Akash Gupta

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/#review202138 --- Ship it! Ship It! - Akash Gupta On April 27, 2018, 4:17 a.m

Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66836/#review202137 --- Ship it! Ship It! - Akash Gupta On April 27, 2018, 4:22 a.m

Re: Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66835/#review202136 --- Ship it! Ship It! - Akash Gupta On April 27, 2018, 4:22 a.m

Re: Review Request 66834: Windows: Specialized `flags::parse`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/#review202135 --- Ship it! Ship It! - Akash Gupta On April 27, 2018, 4:22 a.m

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

/subprocess_tests.cpp Line 234 (original), 233 (patched) <https://reviews.apache.org/r/66790/#comment283769> I think the first half of this test could be out of the #ifdef. - Akash Gupta On April 24, 2018, 11:18 p.m., Andrew Schwartzmeyer

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

/stat.hpp Lines 186 (patched) <https://reviews.apache.org/r/66773/#comment283768> the comment should be `x / (10 * 1000 * 1000)` :) - Akash Gupta On April 27, 2018, 4:21 a.m., Andrew Schwartzmeyer

Re: Review Request 66641: Added `FsTest.Open` to cover `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66641/#review202129 --- Ship it! Ship It! - Akash Gupta On April 16, 2018, 8:24 p.m

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

ent283766> I guess you can try if you can set a valid socket to non blocking mode. - Akash Gupta On April 27, 2018, 4:20 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66431/#review200785 --- Ship it! Ship It! - Akash Gupta On April 9, 2018, 10:53 p.m

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

Lines 159 (patched) <https://reviews.apache.org/r/66440/#comment281617> There's also `ERROR_PATH_NOT_FOUND`. To be safe, you might want to check both. - Akash Gupta On April 6, 2018, 11:17 p.m., Andrew Schwartzmeyer

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/#review200763 --- Ship it! Ship It! - Akash Gupta On April 6, 2018, 11:15 p.m

Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66432/#review200762 --- Ship it! Ship It! - Akash Gupta On April 6, 2018, 11:14 p.m

Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `FileEndOfFileInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66455/#review200752 --- Ship it! Ship It! - Akash Gupta On April 6, 2018, 11:09 p.m

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/#review200749 --- Ship it! Ship It! - Akash Gupta On April 6, 2018, 10:52 p.m

Re: Review Request 66445: Windows: Cleaned up included CRT headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66445/#review200620 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 7:26 p.m

Re: Review Request 66444: Windows: Made `signals.hpp` compile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/#review200619 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:58 a.m

Re: Review Request 66443: Fixed `Subprocess::ChildHook::CHDIR()` to use `os::chdir()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66443/#review200618 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:58 a.m

Re: Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66442/#review200617 --- Ship it! Ship It! - Akash Gupta On April 5, 2018, 2:06 a.m

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

Line 155 (original), 155 (patched) <https://reviews.apache.org/r/66440/#comment281388> We might need to `#ifdef` here to handle the `GetLastError` on Windows and `errno` on Linux. - Akash Gupta On April 4, 2018, 5:57 a.m., Andrew Schwartzmeyer

Re: Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66439/#review200615 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:56 a.m

Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66438/#review200614 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 7:19 p.m

Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66433/#review200613 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 7:18 p.m

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

e the handle constructor here: `WindowsFD(int crt) : WindowsFD(INVALID_HANDLE_VALUE) { ... }` 3rdparty/stout/include/stout/os/windows/fd.hpp Line 85 (original), 84 (patched) <https://reviews.apache.org/r/66437/#comment281377> Same thing here with using the socket constructo

Re: Review Request 66436: Removed use of `fstat()` from `http.cpp` and `http_proxy.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66436/#review200604 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:54 a.m

Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`.

dparty/stout/include/stout/os/posix/stat.hpp Lines 133 (patched) <https://reviews.apache.org/r/66435/#comment281372> Ditto on `const int_fd& fd` - Akash Gupta On April 4, 2018, 5:52 a.m., Andrew Schwartzmeyer wrote: > > --

Re: Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66434/#review200602 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 7:18 p.m

Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`.

`errno` then? Since we aren't using the CRT anymore, we might need to map some Windows errors to errno... - Akash Gupta On April 4, 2018, 5:50 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

re, we might need to map some Windows errors to errno... - Akash Gupta On April 4, 2018, 7:13 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66430/#review200598 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:50 a.m

Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66429/#review200597 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 7:17 p.m

Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`.

iginal), 41 (patched) <https://reviews.apache.org/r/66455/#comment281365> ftruncate doesn't change the file offset, so make sure you store the original file offset and restore it. It's currently setting it to the eof of the new file. - Akash Gupta On April 4, 2018, 7:16 p.m.,

Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66428/#review200594 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:49 a.m

Re: Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66427/#review200590 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:48 a.m

Re: Review Request 66426: Windows: More constness in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66426/#review200589 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:48 a.m

Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66425/#review200588 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:47 a.m

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

_EXCL: case O_CREAT | O_EXCL | O_TRUNC : // Ignore O_TRUNC if we get O_CREAT | O_EXCL create = CREATE_NEW; break; case ...: } - Akash Gupta On April 4, 2018, 5:47 a.m., Andrew Schwartzmeyer wrote: > > --- >

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

_EXCL: case O_CREAT | O_EXCL | O_TRUNC : // Ignore O_TRUNC if we get O_CREAT | O_EXCL create = CREATE_NEW; break; case ...: } - Akash Gupta On April 4, 2018, 5:47 a.m., Andrew Schwartzmeyer wrote: > > --- >

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

_EXCL: case O_CREAT | O_EXCL | O_TRUNC : // Ignore O_TRUNC if we get O_CREAT | O_EXCL create = CREATE_NEW; break; case ...: } - Akash Gupta On April 4, 2018, 5:47 a.m., Andrew Schwartzmeyer wrote: > > --- >

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

_EXCL: case O_CREAT | O_EXCL | O_TRUNC : // Ignore O_TRUNC if we get O_CREAT | O_EXCL create = CREATE_NEW; break; case ...: } - Akash Gupta On April 4, 2018, 5:47 a.m., Andrew Schwartzmeyer wrote: > > --- >

Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66423/#review200576 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:47 a.m

Re: Review Request 66422: Windows: Included used `jobobject.hpp` stout header in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66422/#review200575 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:47 a.m

Re: Review Request 66421: Windows: Included used `jobobject.hpp` stout header in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66421/#review200573 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:47 a.m

Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66420/#review200572 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:46 a.m

Re: Review Request 65957: Updated Windows documentation.

piler that's in your `$PATH`, so it picked GCC for me. You should mention that you can fix that by setting CC and CXX environmental variables like `$env:CC=$(Get-Command).Source` and `$env:CXX=$(Get-Command cl).Source` - Akash Gupta On March 7, 2018, 8:58

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65720/#review198748 --- Ship it! Ship It! - Akash Gupta On March 6, 2018, 8:05 p.m

  1   2   3   4   >