to
'mcypark'.
Repository: mesos
Description
---
CMake: Added AppC spec protocol buffer to build.
Diffs
-
src/CMakeLists.txt 4a2954498efa48a4eb43f82827ff1d6f5f65d389
Diff: https://reviews.apache.org/r/43398/diff/
Testing
---
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
/diff/
Testing
---
Thanks,
Alex Clemmer
/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/43410/diff/
Testing
---
Thanks,
Alex Clemmer
/3rdparty/stout/tests/CMakeLists.txt
3c65d0422dc6e198180d53d1c9e6cb2839137434
3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp
27626ae28db090f1a002239ff5c674b82e8fc9a8
Diff: https://reviews.apache.org/r/43411/diff/
Testing
---
Thanks,
Alex Clemmer
: mesos
Description
---
Windows: Added `src/resource_estimator.cpp` to build.
Diffs
-
src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609
Diff: https://reviews.apache.org/r/43409/diff/
Testing
---
Thanks,
Alex Clemmer
/stout/tests/dynamiclibrary_tests.cpp
27626ae28db090f1a002239ff5c674b82e8fc9a8
Diff: https://reviews.apache.org/r/43411/diff/
Testing
---
Thanks,
Alex Clemmer
7f83dc84997d3b824d1f63012894bd9fc5284053
Diff: https://reviews.apache.org/r/43413/diff/
Testing
---
Thanks,
Alex Clemmer
: mesos
Description
---
CMake: Force GMock to build and link statically.
Diffs
-
3rdparty/libprocess/3rdparty/CMakeLists.txt
9b61376ea6aad304607c20c9823d9ef19013eca0
Diff: https://reviews.apache.org/r/43407/diff/
Testing
---
Thanks,
Alex Clemmer
Diff: https://reviews.apache.org/r/43410/diff/
Testing
---
Thanks,
Alex Clemmer
3c65d0422dc6e198180d53d1c9e6cb2839137434
3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp
27626ae28db090f1a002239ff5c674b82e8fc9a8
Diff: https://reviews.apache.org/r/43411/diff/
Testing
---
Thanks,
Alex Clemmer
Remoortere and Michael Park.
Repository: mesos
Description
---
Windows: Added `src/resource_estimator.cpp` to build.
Diffs
-
src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609
Diff: https://reviews.apache.org/r/43409/diff/
Testing
---
Thanks,
Alex Clemmer
Remoortere and Michael Park.
Repository: mesos
Description
---
CMake: Force GMock to build and link statically.
Diffs
-
3rdparty/libprocess/3rdparty/CMakeLists.txt
9b61376ea6aad304607c20c9823d9ef19013eca0
Diff: https://reviews.apache.org/r/43407/diff/
Testing
---
Thanks,
Alex
---
Thanks,
Alex Clemmer
/43414/diff/
Testing
---
Thanks,
Alex Clemmer
046388189823c0c41ce6cc135d5d3838e9131087
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp
9a592c4ec9f45fdd8ae8c724c3cab67876de72f5
Diff: https://reviews.apache.org/r/43417/diff/
Testing
---
Thanks,
Alex Clemmer
/Process3rdpartyConfigure.cmake
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673
Diff: https://reviews.apache.org/r/43415/diff/
Testing
---
Thanks,
Alex Clemmer
/43416/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/42981/diff/
Testing
---
Thanks,
Alex Clemmer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40851/#review116638
---
Ship it!
Ship It!
- Alex Clemmer
On Jan. 27, 2016, 10:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42016/#review116640
---
Ship it!
Ship It!
- Alex Clemmer
On Jan. 27, 2016, 10:29
> On Jan. 27, 2016, 3 a.m., Alex Clemmer wrote:
> > Aside from the relatively minor comments below, I have one major
> > suggestion: I'd like to point Windows builds at ZK commit
> > 06d3f3fa1bff258e62c0670309ad1849b1434bb1[1], (or _some_ commit later in the
> >
else (NOT EXISTS ${GNUWIN32_PATCH_EXECUTABLE})
...
endif(NOT EXISTS ${GNUWIN32_PATCH_EXECUTABLE})
```
Note that the `else` clause behaves the same as it did before, it's not an
`elseif` or anything like that.
CMakeLists.txt (lines 110 - 113)
<https://reviews.apac
://reviews.apache.org/r/39584/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
ated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review114644
-------
On Jan. 15, 2016, 1:58 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.or
return `int` like the ones below? or are they
> > supposed to return `bool`?
>
> Alex Clemmer wrote:
> Good catch, they are originally macros, but the expression they return is
> `bool`, so let's use that.
>
> Now that I think about it, let's also remove `S_ISLNK` because we
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
return `int` like the ones below? or are they
> > supposed to return `bool`?
>
> Alex Clemmer wrote:
> Good catch, they are originally macros, but the expression they return is
> `bool`, so let's use that.
>
> Now that I think about it, let's also remove `S_ISLNK` because we
15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Mesos. Can we just use
> > `std::shared_ptr`?
>
> Alex Clemmer wrote:
> Per our Slack conversation: (1) I'm all for judicious use of `typedef`,
> and in this case I would really prefer to keep `void *` out of the codebase
> where possible. In Windows we expect to make
ou meant, because that's what I did!
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review114796
-------
On
15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
lt` (which we aren't).
Still, it is convention elsewhere in the code, and I don't see any particular
reason why this isn't just good to have, so if you don't mind, I'd like to keep
it.
- Alex
---
This is an automatically genera
15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review114299
---
On Jan. 14, 2016, 10:08 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail.
;
`((mode) & S_IFMT) == S_IFDIR` rather than to remove the parens around the
`mode` symbol itself. Let me know if this is not correct.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://r
15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Mesos. Can we just use
> > `std::shared_ptr`?
>
> Alex Clemmer wrote:
> Per our Slack conversation: (1) I'm all for judicious use of `typedef`,
> and in this case I would really prefer to keep `void *` out of the codebase
> where possible. In Windows we expect to make
led only on certain
types of Linux.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42035/#review114246
-------
O
/os_tests.cpp
e0a898d91e3521d4b228621a81412e1dd5ddf63d
Diff: https://reviews.apache.org/r/39805/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/39019/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd
Diff: https://reviews.apache.org/r/39019/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/windows/direntsize.hpp
PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp
5b41344ead115d14dcee8c87a63ed647002f9aae
Diff: https://reviews.apache.org/r/39802/diff/
Testing
---
Thanks,
Alex Clemmer
/39019/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
lex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review113576
---
On Jan. 11, 2016, 10:03 p.m., Alex Clemmer wrote:
>
> ---
gt; d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd
>
> Diff: https://reviews.apache.org/r/39803/diff/
>
>
> Testing
> ---
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
to static_assert that _USE_32BIT_TIME_T is not defined.
> > Probably sound advice for _UNICODE and _MBCS as well. Perhaps these static
> > asserts should go in windows.hpp? If you put them there, add a comment
> > saying why the asserts are necessary (e.g. "Implementation of mtim
llocating one extra byte. My bad.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review113853
---
On Jan. 11, 2016, 11:24 a.m., Alex Clemmer wrote:
>
> --
/direntsize.hpp
PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp
5b41344ead115d14dcee8c87a63ed647002f9aae
Diff: https://reviews.apache.org/r/39802/diff/
Testing
---
Thanks,
Alex Clemmer
/39019/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/include/stout/os/windows/ls.hpp
5b41344ead115d14dcee8c87a63ed647002f9aae
Diff: https://reviews.apache.org/r/39802/diff/
Testing
---
Thanks,
Alex Clemmer
his is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review113835
-------
On Jan. 5, 2016, 12:12 a.m., Alex Clemmer wrote:
>
> ---
reply, visit:
https://reviews.apache.org/r/39019/#review113576
-------
On Dec. 23, 2015, 6:44 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-m
`free` is meant to be safe for `NULL/nullptr`.
> > Why not follow this pattern?
> > asserting `directory != NULL` seems like it might surprise people?
>
> Alex Clemmer wrote:
> Well, you are the C++ programmer, so I'll trust your judgement on the
> `assert`s here.
15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
just a second
> > instance of this antipattern, see the dropped issue on this function).
>
> Alex Clemmer wrote:
> Ok, sorry, it wasn't clear that we wanted to address this in this review.
>
> I'll update the review with a first cut at this problem.
I've fo
to static_assert that _USE_32BIT_TIME_T is not defined.
> > Probably sound advice for _UNICODE and _MBCS as well. Perhaps these static
> > asserts should go in windows.hpp? If you put them there, add a comment
> > saying why the asserts are necessary (e.g. "Implementation of mtim
/39019/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
ically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39802/#review113581
---
On Jan. 4, 2016, 11:20 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically
/stout/include/stout/os/windows/ls.hpp
5b41344ead115d14dcee8c87a63ed647002f9aae
Diff: https://reviews.apache.org/r/39802/diff/
Testing
---
Thanks,
Alex Clemmer
/39019/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
t:
https://reviews.apache.org/r/39802/#review113580
-------
On Jan. 4, 2016, 11:20 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39802/
> --
an invalid handle is not the best idea. At best it
> > will be a no-op.
>
> Alex Clemmer wrote:
> So, would you suggest checking if the handle is `INVALID_HANDLE_VALUE`
> and closing it only if that's not true?
>
> Alex Clemmer wrote:
> I bring this up mainly beca
--
>
> (Updated Jan. 8, 2016, 3:29 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van
> Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
>
>
> Repository: mesos
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
19c2996c4572b992030f8824380f3979ced7e526
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/42035/diff/
Testing
---
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
, and
Joris Van Remoortere.
Repository: mesos
Description
---
Windows: Added `slave/flags.cpp` to Windows build.
Diffs
-
src/CMakeLists.txt 81afdc6c3e9b062efb181b2f92a9185bdd4acfb1
Diff: https://reviews.apache.org/r/42036/diff/
Testing
---
Thanks,
Alex Clemmer
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/os_tests.cpp
e0a898d91e3521d4b228621a81412e1dd5ddf63d
Diff: https://reviews.apache.org/r/39805/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/path_tests.cpp
821dbb185f09e2f279d95fd354ce2168cddf1bac
Diff: https://reviews.apache.org/r/39834/diff/
Testing
---
Thanks,
Alex Clemmer
/os_tests.cpp
e0a898d91e3521d4b228621a81412e1dd5ddf63d
Diff: https://reviews.apache.org/r/39805/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/3rdparty/stout/include/stout/windows.hpp
d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd
Diff: https://reviews.apache.org/r/39803/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
n-us/library/14h5k7ff.aspx
This should not impact the Windows codebase, no. It is used only in one place,
the pid isolator, and we don't need that.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/stout/os/windows/ls.hpp
5b6fba13ce215af5801fd0867f6e774e100689ca
Diff: https://reviews.apache.org/r/39802/diff/
Testing
---
Thanks,
Alex Clemmer
/stout/include/stout/windows.hpp
1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39803/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Recommend using RAII pattern (e.g. std::unique_ptr) to eliminate
> > leaking of reparsePointData in the presense of exceptions or logic errors.
> >
> > Since this is C++ code, recommend using new [] instead of malloc/free.
>
> Alex Clemmer wrote:
> I am somewhat em
/stout/os/windows/ls.hpp
5b6fba13ce215af5801fd0867f6e774e100689ca
Diff: https://reviews.apache.org/r/39802/diff/
Testing
---
Thanks,
Alex Clemmer
/3rdparty/stout/include/stout/windows.hpp
d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd
Diff: https://reviews.apache.org/r/39803/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review112667
---
On Jan. 4, 2016, 11:26 p.m., Alex Clemmer wrote:
>
> ---
> This is
eviews.apache.org/r/39803/#review112686
---
On Jan. 4, 2016, 11:26 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To re
/3rdparty/stout/include/stout/windows.hpp
d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd
Diff: https://reviews.apache.org/r/39803/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/ comment why here (as well as on L139) we use
> > `ErrnoError`, yet elsewhere we use `WindowsError`?
>
> Alex Clemmer wrote:
> `errno` captures errors that have happened in the C standard library, and
> `ErrnoError` captures those errors and their messages and lifts t
on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
G? Is it possible for
> > both S_IFDIR and S_IFREG to be set? The windows documentation states, "the
> > _S_IFREG bit is set if path specifies an ordinary file or a device." What
> > happens if the path is "c:\". This is a device and
em unless you're really opposed to this.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review110391
-------
On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote:
>
> ---
e138>
> >
> > Consider using ::RemoveDirectory here, which will delete the directory
> > when the last handle is closed. Unless that's not the desired behavior...
I believe `rmdir` does the same thing, actually. In fact, I remember being
unaware of this
To reply, visit:
https://reviews.apache.org/r/39584/#review110385
-------
On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail.
ps://reviews.apache.org/r/39584/#review109681
-------
On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39584/
> -
at least one other distribution channel (such as
NuGet), and possibly many.
Can we add `alexnaparu` and `dpravat` to the review and get their feedback as
well?
- Alex Clemmer
On Dec. 22, 2015, 8:45 p.m., James Peach wrote
> On Dec. 23, 2015, 9:15 p.m., Alex Clemmer wrote:
> > Just as a short note here, `pkg-config` doesn't work well with the rest of
> > the Windows tool chain, so it's worth wondering what our distribution story
> > should be there.
> >
> > If the consumer is u
701 - 800 of 1228 matches
Mail list logo
