/containerizer/fetcher.cpp ea8eaa6371fc322c240e17b4bb9ba417c45ceaca
Diff: https://reviews.apache.org/r/53413/diff/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
r/53369/#review154512
---
On Nov. 2, 2016, 4:43 a.m., Anindya Sinha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
src/slave/slave.cpp d6c337345707993b0729e9eaf36b5a9ecc52dc72
Diff: https://reviews.apache.org/r/53369/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
---
All tests passed.
Thanks,
Anindya Sinha
-
>
> (Updated Oct. 17, 2016, 6:15 p.m.)
>
>
> Review request for mesos, (Disabled_DoNotUse) Anindya Sinha and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Explain read-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53208/#review154068
---
Ship it!
Ship It!
- Anindya Sinha
On Oct. 27, 2016, 7:06
Diff: https://reviews.apache.org/r/52071/diff/
Testing
---
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
tests in this RR passed.
Thanks,
Anindya Sinha
/slave/containerizer/mesos/isolators/gpu/allocator.cpp
2e722691475c84afae14009014ea70cc0fdd0e65
src/v1/resources.cpp 46cc00f2f453f5eb4ddc4b0b9b89be2bd89f05d9
Diff: https://reviews.apache.org/r/51879/diff/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
tructure in the above code block shared by different kinds of resources.
> > We can pass in the auto-detection methods like `systemMemAmount()` as an
> > argument.
> >
> > If not, the body of `Resources::resources()` still tells me the
> > workflow/algorith
gt;
> > Finally, we may not even need `isMountDisk()` or `isPathDisk` given how
> > /r/51879/ is going. It may make sense to not specially treat PATH disk
> > differently but let's disucss that in /r/51879/. With this review we can
> > just have a `bool isR
Diff: https://reviews.apache.org/r/52002/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
rom the `(` above or else you can:
> >
> > ```
> > ASSERT_TRUE(
> > Resources::isRootDisk(
> > createDiskResource("100", "role1", None(), None(;
> > ```
> >
> > Ditto for others which has two `(` in one li
passed.
Thanks,
Anindya Sinha
to make 1000 offers
Thanks,
Anindya Sinha
test framework for shared resources added.
Tests successful.
Thanks,
Anindya Sinha
led/disabled
> > via command-line flags. Especially since you add some nice new DESTROY
> > logic in the new framework; it would be great to have that change in the
> > existing one, and avoid duplicating a lot of code. What do you think?
>
> Anindya Sinha wrote:
> Agre
1475c8eb848ece2a093e8243b51e9ce08981dd7d
Diff: https://reviews.apache.org/r/53031/diff/
Testing
---
All existing tests passed.
Thanks,
Anindya Sinha
---
All existing tests passed.
Thanks,
Anindya Sinha
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52980/#review153155
-------
On Oct. 18, 2016, 7:43 a.m., Anindya Sinha wrote:
>
> ---
> This is an auto
that permissions _on
> Windows_ is a subtle issue in Mesos. My worry is rooted in the fact that this
> API also has to support Windows.
>
> Anindya Sinha wrote:
> So, er either extend `mkdir()` to include a `mode` (which as you
> indicated would need a change in the wind
: https://reviews.apache.org/r/46230/diff/
Testing
---
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
added tests).
Thanks,
Anindya Sinha
6bd9b49c3bbdb973a0d03552ae8fe55b33371083
src/v1/resources.cpp 46cc00f2f453f5eb4ddc4b0b9b89be2bd89f05d9
Diff: https://reviews.apache.org/r/46228/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
: https://reviews.apache.org/r/52980/diff/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
/r/46227/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45963/#review152538
---
On Oct. 13, 2016, 5:24 a.m., Anindya Sinha wrote:
>
> ---
> T
/diff/
Testing
---
Tests successful.
Thanks,
Anindya Sinha
ee to add that comment in https://reviews.apache.org/r/45962 so that it is
not forgotten.
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45963/#review151731
----
/shared-resources.md PRE-CREATION
Diff: https://reviews.apache.org/r/45967/diff/
Testing
---
Tests successful.
Thanks,
Anindya Sinha
://reviews.apache.org/r/45963/diff/
Testing
---
Tests successful.
Thanks,
Anindya Sinha
s version, we need to do a bind mount followed by a remount as
read-only. Post util-linux v2.27, a single bind mount as read-only should
suffice.
So, I moved this to a 2-stage mount.
- Anindya
---
This is an automaticall
() took 1.502953secs to make 1000 offers
round 50 allocate() took 1.520157secs to make 1000 offers
round 100 allocate() took 1.517221secs to make 1000 offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha
do that in the next update.
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/#review151822
---
On Sept. 28
/master/master.cpp c7e74df71aa31edb490f4f3bd95f2d5aa94b4324
src/tests/persistent_volume_tests.cpp
e10a79e9662530e143ccaa2aa2506a4d25158364
Diff: https://reviews.apache.org/r/52288/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
/master.cpp c7e74df71aa31edb490f4f3bd95f2d5aa94b4324
src/tests/.slave_recovery_tests.cpp.swp PRE-CREATION
src/tests/persistent_volume_tests.cpp
e10a79e9662530e143ccaa2aa2506a4d25158364
Diff: https://reviews.apache.org/r/52288/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
.
Thanks,
Anindya Sinha
/containerizer/common_containerizer_tests.cpp PRE-CREATION
src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a
Diff: https://reviews.apache.org/r/51880/diff/
Testing
---
All tests including the additional tests in this RR passed.
Thanks,
Anindya Sinha
2e722691475c84afae14009014ea70cc0fdd0e65
src/v1/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90
Diff: https://reviews.apache.org/r/51879/diff/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
://reviews.apache.org/r/52002/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
/containerizer/common_containerizer_tests.cpp PRE-CREATION
src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a
Diff: https://reviews.apache.org/r/51880/diff/
Testing
---
All tests including the additional tests in this RR passed.
Thanks,
Anindya Sinha
: https://reviews.apache.org/r/52071/diff/
Testing
---
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
62a644ebbd13cfc0862bd118ba16c43e0f6aaf90
Diff: https://reviews.apache.org/r/51879/diff/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
62a644ebbd13cfc0862bd118ba16c43e0f6aaf90
Diff: https://reviews.apache.org/r/52002/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
rrent version violates it. AFAICT, there is no specific rule for 2
"(" in the same line.
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52002/#review151126
a3f757
src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a
src/v1/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90
Diff: https://reviews.apache.org/r/51999/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
s.apache.org/r/51879/.
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51999/#review150800
---
On Sept. 28, 2016, 7:24 p.m., Ani
879/ since that is where the
change regarding validation lies.
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51999/#review150581
--------
: https://reviews.apache.org/r/52071/diff/
Testing
---
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
/containerizer/common_containerizer_tests.cpp PRE-CREATION
src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a
Diff: https://reviews.apache.org/r/51880/diff/
Testing
---
All tests including the additional tests in this RR passed.
Thanks,
Anindya Sinha
/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a
src/v1/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90
Diff: https://reviews.apache.org/r/51999/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
c1a87e9e5c07529bc1d077f68477108a40506806
src/v1/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90
Diff: https://reviews.apache.org/r/51879/diff/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
://reviews.apache.org/r/52002/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
place this is moved to.
> >
> > ```
> > /**
> >* Parses Resources from text in the form of a JSON array. If that
> > fails,
> >* text in the form "name(role):value;name:value;...". i.e, this
> > me
to make 1000 offers
Thanks,
Anindya Sinha
PRE-CREATION
Diff: https://reviews.apache.org/r/45967/diff/
Testing
---
Tests successful.
Thanks,
Anindya Sinha
/r/45963/diff/
Testing
---
Tests successful.
Thanks,
Anindya Sinha
resources added.
Tests successful.
Thanks,
Anindya Sinha
src/tests/persistent_volume_tests.cpp
2ab44d11d159162dfcac9d0791b651ed059b8164
src/tests/sorter_tests.cpp 1f17c011898836ea9159661dde7d544cb0d8ea83
Diff: https://reviews.apache.org/r/52295/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
2ab44d11d159162dfcac9d0791b651ed059b8164
Diff: https://reviews.apache.org/r/52288/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
to make 1000 offers
Thanks,
Anindya Sinha
PRE-CREATION
Diff: https://reviews.apache.org/r/45967/diff/
Testing
---
Tests successful.
Thanks,
Anindya Sinha
/r/45963/diff/
Testing
---
Tests successful.
Thanks,
Anindya Sinha
://reviews.apache.org/r/45962/diff/
Testing
---
New test framework for shared resources added.
Tests successful.
Thanks,
Anindya Sinha
t;
Kill this block if you consolidate the error handling for `chownOut` and
`chownErr`.
- Anindya Sinha
On Sept. 20, 2016, 11:32 p.m., Megha Sharma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
.
Thanks,
Anindya Sinha
c1a87e9e5c07529bc1d077f68477108a40506806
src/v1/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90
Diff: https://reviews.apache.org/r/51879/diff/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
/containerizer/common_containerizer_tests.cpp PRE-CREATION
src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a
Diff: https://reviews.apache.org/r/51880/diff/
Testing
---
All tests including the additional tests in this RR passed.
Thanks,
Anindya Sinha
://reviews.apache.org/r/52002/diff/
Testing (updated)
---
All tests passed.
Thanks,
Anindya Sinha
/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a
src/v1/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90
Diff: https://reviews.apache.org/r/51999/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
---
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
tests including the additional tests in this RR passed.
Thanks,
Anindya Sinha
/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90
Diff: https://reviews.apache.org/r/51879/diff/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
to look at
`gpus` a little more.
And ensured all existing call sites for `Resources::parse()` have the same
expectation as today, ie. returns a `Resources` object with no empty and
invalid resources.
- Anindya
---
62a644ebbd13cfc0862bd118ba16c43e0f6aaf90
Diff: https://reviews.apache.org/r/52002/diff/
Testing
---
Thanks,
Anindya Sinha
a3f757
src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a
src/v1/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90
Diff: https://reviews.apache.org/r/51999/diff/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
For this patch, I agreee that using a `Resourecs` object here would be fine.
However, if you look at https://reviews.apache.org/r/51879/ (which is in this
chain), we would need this to be a `vector`. So I would not modify it
here.
- Anindya
----------
condly, what are you implying by `role` validation? Would you please
elaborate?
- Anindya Sinha
On Sept. 26, 2016, 6:46 a.m., Anindya Sinha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
to make 1000 offers
Thanks,
Anindya Sinha
PRE-CREATION
Diff: https://reviews.apache.org/r/45967/diff/
Testing
---
Tests successful.
Thanks,
Anindya Sinha
framework for shared resources added.
Tests successful.
Thanks,
Anindya Sinha
/r/45963/diff/
Testing
---
Tests successful.
Thanks,
Anindya Sinha
quot; COUNTER=$[COUNTER+1];"
> > " sleep 2;"
> > "done");
> > ```
Ditto as above.
- Anindya
---
This is an automatically ge
; > static bool Resources::isMountDisk(const Resource& resource);
> > static bool Resources::isPathDisk(const Resource& resource);
> > ```
> >
> > ?
> >
> > We have already lost enumerability (or swtichability) given that t
source.disk().has_source() &&
> > resource.disk().source().type() ==
> > Resource::DiskInfo::Source::PATH;
> > }
> > ```
See my response above. I think having a single function to encapsulate all
source types is fine.
- Anindya
---
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
or textual formats
still results in an invalid resource.
Diffs (updated)
-
src/slave/containerizer/containerizer.cpp
d46882baa904fd439bffb23c324828b777228f1c
Diff: https://reviews.apache.org/r/51879/diff/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
478fb5ae01dbdf1a735680edf7c5f30867726e07
src/tests/containerizer/common_containerizer_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/51880/diff/
Testing
---
All tests including the additional tests in this RR passed.
Thanks,
Anindya Sinha
://reviews.apache.org/r/52002/diff/
Testing
---
Thanks,
Anindya Sinha
generated e-mail. To reply, visit:
https://reviews.apache.org/r/51999/#review149603
---
On Sept. 19, 2016, 10:42 p.m., Anindya Sinha wrote:
>
> ---
> This is an automaticall
-
All tests passed.
Thanks,
Anindya Sinha
or `Resources::parse()` with the additional parameter.
Another option we discussed is to expose another `Resources::parse()` that
returns `vecor` in a separate namespace which probably is cleaner but
would require refactor in other call sites.
For now, we would follow the approach specified
.apache.org/r/52001/#review149710
---
On Sept. 19, 2016, 10:43 p.m., Anindya Sinha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52001/
> -
ase, we return an
error. So, at this point, we type should contain valid values.
- Anindya
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52001/#review149611
--
for PATH disks since PATH disks can be carved into
smaller volumes.
Diffs
-
docs/attributes-resources.md 2caa44927d45c0ab13f8160794b50f4fde3711aa
Diff: https://reviews.apache.org/r/52071/diff/
Testing
---
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
formats
still results in an invalid resource.
Diffs (updated)
-
src/slave/containerizer/containerizer.cpp
d46882baa904fd439bffb23c324828b777228f1c
Diff: https://reviews.apache.org/r/51879/diff/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
/containerizer/common_containerizer_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/51880/diff/
Testing
---
All tests including the additional tests in this RR passed.
Thanks,
Anindya Sinha
ent that determine the disk size automatically a bit
> > nonintuitive.
> > Please update docs/attributes-resources.md if we have to use this way
> > eventually.
Docs updated in https://reviews.apache.org/r/52071/.
- Anindya
----------
7c4db44d4c31a8295cc16b0ce1ef5adf314e6ac6
Diff: https://reviews.apache.org/r/52002/diff/
Testing
---
Thanks,
Anindya Sinha
ttps://reviews.apache.org/r/52001/#review149490
---
On Sept. 19, 2016, 5:01 a.m., Anindya Sinha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
301 - 400 of 734 matches
Mail list logo
