---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71987/#review219235
---
Ship it!
Ship It!
- Benno Evers
On Jan. 13, 2020, 10:22 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71854/#review219228
---
Ship it!
Ship It!
- Benno Evers
On Dec. 3, 2019, 1:37 p.m
50b09cf3b0cf89568a45afd3fe89fa16c6a79222
src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7
Diff: https://reviews.apache.org/r/71977/diff/1/
Testing
---
Thanks,
Benno Evers
Diff: https://reviews.apache.org/r/71976/diff/1/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/71833/diff/4-5/
Testing
---
Thanks,
Benno Evers
3839a120446339fea8aa857f431a2dba28ed4002
Diff: https://reviews.apache.org/r/71816/diff/3/
Changes: https://reviews.apache.org/r/71816/diff/2-3/
Testing
---
Thanks,
Benno Evers
the new test.
Thanks,
Benno Evers
s an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71947/#review219127
---
On Jan. 10, 2020, 1:37 a.m., Benno Evers wrote:
>
> --
trigger.
Thanks,
Benno Evers
(updated)
-
3rdparty/stout/include/stout/attributes.hpp
54d438dca56d5346c58eb28eaeda7916a3a62076
Diff: https://reviews.apache.org/r/71971/diff/2/
Changes: https://reviews.apache.org/r/71971/diff/1-2/
Testing (updated)
---
Internal CI run.
Thanks,
Benno Evers
D __attribute__((deprecated))
#endif
What do you think?
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71971/#review219174
-----
: https://reviews.apache.org/r/71971/diff/1/
Testing
---
Internal unit test run in progress.
Thanks,
Benno Evers
: mesos
Description
---
Added deprecated absolute() function for backwards compatibility.
Diffs
-
3rdparty/stout/include/stout/path.hpp
ba1f665ce94b9636d88a7ecce8643c56758f7b5c
Diff: https://reviews.apache.org/r/71961/diff/1/
Testing
---
Thanks,
Benno Evers
: mesos
Description
---
Added support for the [[deprecated]] attribute to stout.
Diffs
-
3rdparty/stout/include/stout/attributes.hpp
a02ee79e39e90c2fd7f2e9b43949606559ce9ccb
Diff: https://reviews.apache.org/r/71960/diff/1/
Testing
---
Thanks,
Benno Evers
tps://reviews.apache.org/r/71538/#comment307231>
Why not just `--enable-nvml`/`--disable-nvml`?
- Benno Evers
On Sept. 24, 2019, 10:08 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71717/#review219131
---
Ship it!
Ship It!
- Benno Evers
On Jan. 6, 2020, 1:05 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71934/#review219129
---
Ship it!
Ship It!
- Benno Evers
On Dec. 20, 2019, 11:51 p.m
/
Testing
---
Ran existing unit tests and verified that the newly added `CHECK()` doesn't
trigger.
Thanks,
Benno Evers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71916/#review219036
---
Ship it!
Ship It!
- Benno Evers
On Dec. 16, 2019, 8:20 a.m
not a socket, we should end up with an error upon calling `bind()`.
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71833/#review218939
------
t:
https://reviews.apache.org/r/71866/#review218937
-------
On Dec. 3, 2019, 6:32 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e
479 (patched)
<https://reviews.apache.org/r/71878/#comment306969>
Why not store a `Path*` here? Then we would not need to have an extra copy
of `separator` in the iterator.
- Benno Evers
On Dec. 5, 2019, 12:48 p.m., Benjamin Bannier wrote:
>
> --
nes 590 (patched)
<https://reviews.apache.org/r/71882/#comment306966>
How about
the range of `base`
the `base` range
the range `[base.begin(), base.end())`
to avoid the awkward backtick-single-quote?
- Benno Evers
On Dec. 5, 2019
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71881/#review218975
---
Ship it!
Ship It!
- Benno Evers
On Dec. 5, 2019, 12:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71880/#review218974
---
Ship it!
Ship It!
- Benno Evers
On Dec. 5, 2019, 12:48 p.m
we're regularly doing similar refactorings in stout, feel free to drop
this issue.
- Benno Evers
On Dec. 5, 2019, 12:48 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
be you could add a link to the
cmake documentation in the commit message?
- Benno Evers
On Dec. 3, 2019, 1:12 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/docker.cpp 2a9b2ffcbd01ae916839ae43c8342285ac3e14a2
src/tests/containerizer/docker_containerizer_tests.cpp
689a7220a09f2a58dffdf0dc9fd9f0548600be0e
Diff: https://reviews.apache.org/r/71867/diff/1/
Testing
---
Thanks,
Benno Evers
,
Benno Evers
/stout/os/windows/chmod.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/71866/diff/1/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/71833/diff/3-4/
Testing
---
Thanks,
Benno Evers
/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222
src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002
Diff: https://reviews.apache.org/r/71816/diff/2/
Changes: https://reviews.apache.org/r/71816/diff/1-2/
Testing
---
Thanks,
Benno Evers
/diff/3/
Changes: https://reviews.apache.org/r/71815/diff/2-3/
Testing
---
Ran the new test.
Thanks,
Benno Evers
/http.hpp
0013850f07110d9b9dbdb9b0c8ac7001a82420d2
3rdparty/libprocess/src/http.cpp b487ce214128193a3443f4e62a5af24205cbd399
Diff: https://reviews.apache.org/r/71814/diff/2/
Changes: https://reviews.apache.org/r/71814/diff/1-2/
Testing
---
Thanks,
Benno Evers
tps://reviews.apache.org/r/71832/diff/3/
Changes: https://reviews.apache.org/r/71832/diff/2-3/
Testing
---
* Manual testing by using it in the subsequent patch.
* `./stout-tests`
Thanks,
Benno Evers
src/tests/cluster.cpp f7bc882a644ec65710ada3d15507e1d4c5ba06f7
src/tests/mock_slave.cpp 71be957884ea88258ef37e60649e3947e89b12d0
Diff: https://reviews.apache.org/r/71833/diff/3/
Changes: https://reviews.apache.org/r/71833/diff/2-3/
Testing
---
Thanks,
Benno Evers
/linux_filesystem_isolator_tests.cpp
2390902ce4dc6fb341ca836af95984a040e8e658
Diff: https://reviews.apache.org/r/71836/diff/1/
Testing
---
Thanks,
Benno Evers
src/tests/default_executor_tests.cpp 49c4e3b37bde848dc7a4fd02a1458c650a84a16f
Diff: https://reviews.apache.org/r/71815/diff/2/
Changes: https://reviews.apache.org/r/71815/diff/1-2/
Testing
---
Ran the new test.
Thanks,
Benno Evers
tps://reviews.apache.org/r/71816/#comment306740>
We also need to validate that the path is less than 108 characters long.
- Benno Evers
On Nov. 25, 2019, 5 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail.
cac9253323f5a9a99876a0e3bd6dd4acbc19d9c1
Diff: https://reviews.apache.org/r/71837/diff/1/
Testing
---
Created a commit containing the word `WIP` in the title.
Thanks,
Benno Evers
3839a120446339fea8aa857f431a2dba28ed4002
src/tests/cluster.cpp f7bc882a644ec65710ada3d15507e1d4c5ba06f7
src/tests/mock_slave.cpp 71be957884ea88258ef37e60649e3947e89b12d0
Diff: https://reviews.apache.org/r/71833/diff/2/
Changes: https://reviews.apache.org/r/71833/diff/1-2/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/71832/diff/1-2/
Testing (updated)
---
* Manual testing by using it in the subsequent patch.
* `./stout-tests`
Thanks,
Benno Evers
src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7
src/slave/slave.hpp 77b5bc0082c6bb73fbd48a2ebe812629921645cb
src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002
Diff: https://reviews.apache.org/r/71833/diff/1/
Testing
---
Thanks,
Benno Evers
: https://reviews.apache.org/r/71832/diff/1/
Testing
---
Manual testing by using it in the subsequent patch.
Thanks,
Benno Evers
3839a120446339fea8aa857f431a2dba28ed4002
Diff: https://reviews.apache.org/r/71816/diff/1/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/71815/diff/1/
Testing
---
Ran the new test.
Thanks,
Benno Evers
and fragment sections.
Diffs
-
3rdparty/libprocess/include/process/http.hpp
0013850f07110d9b9dbdb9b0c8ac7001a82420d2
3rdparty/libprocess/src/http.cpp b487ce214128193a3443f4e62a5af24205cbd399
Diff: https://reviews.apache.org/r/71814/diff/1/
Testing
---
Thanks,
Benno Evers
check`
Thanks,
Benno Evers
ted e-mail. To reply, visit:
https://reviews.apache.org/r/71805/#review218765
-------
On Nov. 22, 2019, 4:20 p.m., Benno Evers wrote:
>
> ---
> This is an
(patched)
<https://reviews.apache.org/r/71805/#comment306629>
FYI, since it isn't touched in the review: Here was the location of the
original leak.
- Benno Evers
On Nov. 22, 2019, 4:20 p.m., Benno Evers
.
Diffs
-
3rdparty/libprocess/src/openssl.cpp bd05866950e1043d9585a7c5fdc7b2147a233fd3
Diff: https://reviews.apache.org/r/71805/diff/1/
Testing
---
`make check`
Thanks,
Benno Evers
? I hope you're *not* using
that use-after-free bug for anything. :D
- Benno Evers
On Nov. 21, 2019, 9:42 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
`
Thanks,
Benno Evers
this example anyways.)
docs/operator-http-api.md
Lines 1957 (patched)
<https://reviews.apache.org/r/71741/#comment306584>
s/fall/for/
- Benno Evers
On Nov. 20, 2019, 2:17 p.m., Benjamin Bannier wrote:
>
> ---
> T
---
`./src/mesos-tests --gtest_filter="*ReservationUpdate*"`
Thanks,
Benno Evers
bddc9467c5b9fe6cdcbd84f1b110356a43b59ba0
Diff: https://reviews.apache.org/r/71787/diff/1/
Testing
---
`./src/mesos-tests --gtest_filter="*ReservationUpdate*"`
Thanks,
Benno Evers
/validation.cpp c5fbbdd55e4a217c756e2ece3f8fd6ed5e88048f
Diff: https://reviews.apache.org/r/71785/diff/1/
Testing
---
Thanks,
Benno Evers
tps://reviews.apache.org/r/71659/#comment306517>
s/encypts/encrypts/
Also, I know it isn't your sentence, but "the communication that Mesos uses
for communication" doesn't sound entirely correct either.
- Benno Evers
On Nov. 13, 2019, 7:01 p.m.,
Second, the class doesn *wrap* a Socket, it *is* a SocketImpl.
Finally, regarding the other implementations of `SocketImpl`, it seems like
`OpenSSLSocketImpl` would be a bit more consistent.
- Benno Evers
On Nov. 13, 20
che.org/r/71664/#comment306538>
Should this be `get_libprocess_BIO_METHOD()` for consistency?
- Benno Evers
On Oct. 31, 2019, 1:29 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71769/#review218669
---
Ship it!
Ship It!
- Benno Evers
On Nov. 14, 2019, 6:14 p.m
. Ideally, we'd
have a first example without `source` (i.e. the one we had before) and then a
second example using `source` to do an actual reservation update. (In your
commit message you use the word `rereservation`, do we use that anywhere else?)
- Benno Evers
On Nov. 8, 2019, 1:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71732/#review218663
---
Ship it!
Ship It!
- Benno Evers
On Nov. 6, 2019, 12:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71739/#review218662
---
Ship it!
Ship It!
- Benno Evers
On Nov. 8, 2019, 1:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71663/#review218660
---
Ship it!
Ship It!
- Benno Evers
On Oct. 23, 2019, 7:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71662/#review218659
---
Ship it!
Ship It!
- Benno Evers
On Oct. 23, 2019, 7:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71661/#review218657
---
Ship it!
Ship It!
- Benno Evers
On Oct. 23, 2019, 7:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71729/#review218579
---
Ship it!
Ship It!
- Benno Evers
On Nov. 8, 2019, 12:48 p.m
: https://reviews.apache.org/r/71735/diff/1-2/
Testing
---
Thanks,
Benno Evers
/unimplemented.hpp
ab6caa8fa9645bca66a3efcdc6d337f3fb0481d7
3rdparty/stout/include/stout/unreachable.hpp
d4b3bb0582eb9e64e6f150735d1e9f2956edbca6
Diff: https://reviews.apache.org/r/71734/diff/3/
Changes: https://reviews.apache.org/r/71734/diff/2-3/
Testing
---
Thanks,
Benno Evers
> On Nov. 6, 2019, 4:11 p.m., Benno Evers wrote:
> > src/master/master.cpp
> > Lines 3810 (patched)
> > <https://reviews.apache.org/r/71729/diff/1/?file=2171587#file2171587line3810>
> >
> > It doesn't seem ideal to have recursively nested calls
tes
void foo(args);
```
style of declaration, which looks pretty good to me.
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71734/#review218544
-----
/#comment306285>
Is this the same as `reserve.resources().reservations()`?
src/master/master.cpp
Lines 3834 (patched)
<https://reviews.apache.org/r/71729/#comment306279>
That look more like debug-statements rather than `INFO`-level logging?
- Benno Evers
On Nov. 6, 2019, 10:10 a.m.
,
Benno Evers
/diff/2/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/71725/diff/2/
Changes: https://reviews.apache.org/r/71725/diff/1-2/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/71690/diff/3-4/
Testing
---
Thanks,
Benno Evers
/master.cpp 2fdd6f7ddbb488d785c6f875c8b0c46c5f881d9d
Diff: https://reviews.apache.org/r/71687/diff/3/
Changes: https://reviews.apache.org/r/71687/diff/2-3/
Testing
---
Thanks,
Benno Evers
b8aef28e08f85c87bb78f25a64b0d7318f2727cc
Diff: https://reviews.apache.org/r/71735/diff/1/
Testing
---
Thanks,
Benno Evers
/71734/diff/1/
Testing
---
Thanks,
Benno Evers
reply, visit:
https://reviews.apache.org/r/71695/#review218519
-------
On Nov. 5, 2019, 1:25 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71695/
>
---
Added a new test to verify that reservations can be updated
using the operator API.
Diffs
-
src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a
Diff: https://reviews.apache.org/r/71725/diff/1/
Testing
---
Thanks,
Benno Evers
the `getResourcesConversion()` function to correctly
handle the `source` field in `RESERVE` operations.
Diffs
-
src/common/resources_utils.cpp 5e78997fb9673faec37f20566d06328fe347b7e1
Diff: https://reviews.apache.org/r/71719/diff/1/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/71690/diff/3/
Changes: https://reviews.apache.org/r/71690/diff/2-3/
Testing
---
Thanks,
Benno Evers
---
Make sure to print the actual error message after an assertion
failure in `Resources::pushReservations()`.
Diffs
-
src/common/resources.cpp bfa9f3ea7e8c3e2dc9b4c4f7c86ad29b0de81f24
Diff: https://reviews.apache.org/r/71722/diff/1/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/71695/diff/1-2/
Testing
---
Thanks,
Benno Evers
anks,
Benno Evers
: https://reviews.apache.org/r/71690/diff/1-2/
Testing
---
Thanks,
Benno Evers
: https://reviews.apache.org/r/71688/diff/1-2/
Testing
---
Thanks,
Benno Evers
/master/master.cpp 2fdd6f7ddbb488d785c6f875c8b0c46c5f881d9d
Diff: https://reviews.apache.org/r/71687/diff/2/
Changes: https://reviews.apache.org/r/71687/diff/1-2/
Testing
---
Thanks,
Benno Evers
/master.hpp dc45028d2ecfb61bf9ea82d90d2393af648a6023
src/master/master.cpp 2fdd6f7ddbb488d785c6f875c8b0c46c5f881d9d
Diff: https://reviews.apache.org/r/71699/diff/2/
Changes: https://reviews.apache.org/r/71699/diff/1-2/
Testing
---
Thanks,
Benno Evers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71709/#review218483
---
Ship it!
Ship It!
- Benno Evers
On Nov. 1, 2019, 3:12 p.m
a2f6dbbf84d80c269e20864cbcc439298f31
Diff: https://reviews.apache.org/r/71686/diff/1/
Testing
---
Thanks,
Benno Evers
/r/71687/diff/1/
Testing
---
Thanks,
Benno Evers
351823e69f14dbb5eb1ea2b108c42e93722f1eff
Diff: https://reviews.apache.org/r/71699/diff/1/
Testing
---
Thanks,
Benno Evers
---
Reject operator API calls that include reservation updates.
Diffs
-
src/master/http.cpp 60765c9b9d6903f6ed94fa8c614055698caad0da
Diff: https://reviews.apache.org/r/71688/diff/1/
Testing
---
Thanks,
Benno Evers
/common/resources.cpp bfa9f3ea7e8c3e2dc9b4c4f7c86ad29b0de81f24
src/tests/resources_tests.cpp b5854656b7e9ce7af9e1d8ecad708066512d814f
Diff: https://reviews.apache.org/r/71690/diff/1/
Testing
---
Thanks,
Benno Evers
-
src/master/http.cpp 60765c9b9d6903f6ed94fa8c614055698caad0da
src/master/master.hpp dc45028d2ecfb61bf9ea82d90d2393af648a6023
Diff: https://reviews.apache.org/r/71695/diff/1/
Testing
---
Thanks,
Benno Evers
src/master/validation.cpp a7ecefb8a1e186901301419feca75600d8de001b
Diff: https://reviews.apache.org/r/71696/diff/1/
Testing
---
Thanks,
Benno Evers
---
Updated `validateAndUpgradeResources()` to also validate the `source`
field in a reservation.
Diffs
-
src/common/resources_utils.cpp cbdad4b045ad957b2ab1fd09a6b9fb12bb4fb523
Diff: https://reviews.apache.org/r/71700/diff/1/
Testing
---
Thanks,
Benno Evers
1 - 100 of 867 matches
Mail list logo
