Re: Review Request 68225: Added 25th and 75th percentiles to `Statistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68225/#review206876 --- Ship it! Ship It! - Benno Evers On Aug. 6, 2018, 10:30 a.m

Review Request 68227: Updated git repository url.

--- With the move to gitbox, the canonical upstream url changed from `git-wip-us.apache.org` to `gitbox.apache.org`. Diffs - docs/building.md 2b9f61dca2235bfdf2e9c1f106110d83bd9a6ce8 Diff: https://reviews.apache.org/r/68227/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 68166: Moved around some functions definitions between files.

/diff/1-2/ Testing --- Thanks, Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

master.cpp 192fe8299777f68bf6f48d693ef79ff75fecfe00 Diff: https://reviews.apache.org/r/68141/diff/4/ Changes: https://reviews.apache.org/r/68141/diff/3-4/ Testing --- `make check` Thanks, Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

out-of-class definitions due to reasons (1) and (3) above. - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206788 -------

Review Request 68166: Moved around some functions definitions between files.

to the top of the file in `framework.cpp`. Diffs - src/master/framework.cpp PRE-CREATION src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 Diff: https://reviews.apache.org/r/68166/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

/ Changes: https://reviews.apache.org/r/68141/diff/2-3/ Testing --- `make check` Thanks, Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

eLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66 src/master/framework.cpp PRE-CREATION src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 Diff: https://reviews.apache.org/r/68141/diff/2/ Testing --- `make check` Thanks, Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

45ffedbc314941f44a5330e78cf7dd2e402c9116 Diff: https://reviews.apache.org/r/68141/diff/2/ Changes: https://reviews.apache.org/r/68141/diff/1-2/ Testing (updated) --- `make check` Thanks, Benno Evers

Review Request 68141: Moved Framework implementation into separate file.

PRE-CREATION src/master/master.hpp 0353d550308816f219aedb6afe15c643fc8bb340 Diff: https://reviews.apache.org/r/68141/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 68098: Fixed rapidjson make install directory structure.

message (`no_base` -> `nobase`, `strucutre` -> `structure`) - Benno Evers On July 29, 2018, 9:46 p.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 68082: Clarified instructions in docs.

--- The instructions for using libprocess memory profiling together with a custom libjemalloc.so had accidentally omitted a required condition. Diffs - docs/memory-profiling.md 0b829843943d686c0621054c798bb7b827f3432f Diff: https://reviews.apache.org/r/68082/diff/1/ Testing --- Thanks, Benno

Re: Review Request 68061: Eliminated unnecessary copy in DataEncoder constructor.

://reviews.apache.org/r/68061/diff/2/ Testing --- `make check` Thanks, Benno Evers

Re: Review Request 68061: Eliminated unnecessary copy in DataEncoder constructor.

://reviews.apache.org/r/68061/diff/2/ Changes: https://reviews.apache.org/r/68061/diff/1-2/ Testing --- `make check` Thanks, Benno Evers

Review Request 68061: Eliminated unnecessary copy in DataEncoder constructor.

--- `make check` Thanks, Benno Evers

Re: Review Request 67987: Added rapidjson to the mesos build.

-- On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67987/ > --- > > (Updated July 20, 2018, 3:38 a.m.) > > > Review r

Re: Review Request 67987: Added rapidjson to the mesos build.

) <https://reviews.apache.org/r/67987/#comment289266> This can be shortened a bit, since we already have the list stored in a variable: ``` $(nodist_rapidjson_HEADERS): $(RAPIDJSON)-stamp ``` - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler

Re: Review Request 67987: Added rapidjson to the mesos build.

> On July 20, 2018, 10:55 a.m., Benno Evers wrote: > > 3rdparty/Makefile.am > > Lines 517 (patched) > > <https://reviews.apache.org/r/67987/diff/1/?file=2061745#file2061745line517> > > > > What's the reason that we cannot use the same `DESTDIR=$(INS

Re: Review Request 67990: Fixed libprocess tests against rapidjson.

imply that users having written custom tooling to parse the response of `/metrics` might see their scripts break, right? - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > --- > This is an automatically generat

Re: Review Request 67989: Fixed issues with the JSON serialization tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67989/#review206278 --- Ship it! Ship It! - Benno Evers On July 20, 2018, 3:38 a.m

Re: Review Request 67988: Improved performance of jsonify by integrating with rapidjson.

mediately obvious that an empty object corresponds to the string "{}". - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > --- > This is an au

Re: Review Request 67987: Added rapidjson to the mesos build.

ng the jemalloc patches - if we modify upstreame tarballs, should we maybe gpg-sign the result? - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 67986: Added rapidjson to the libprocess build.

902 (patched) <https://reviews.apache.org/r/67986/#comment289180> Same issue as in the prior review. - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e

Re: Review Request 67985: Added rapidjson to the stout build.

gainst an unbundled version of rapidjson. - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 67991: Adjusted Mesos to compile against jsonify rapidjson changes.

for this. Maybe it would be possible to have an empty `std::string` member in `StringWriter` that can serve as a buffer and would be written in the destructor, so we can emulate `append()`? - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote

Re: Review Request 67993: Avoid resource copying while serving state json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67993/#review206275 --- Ship it! Ship It! - Benno Evers On July 20, 2018, 5:23 a.m

Re: Review Request 67992: Avoid performance cost of ostringstream in http::OK json constructors.

724 (original), 720 (patched) <https://reviews.apache.org/r/67992/#comment289177> Let's not use C-style casts. 3rdparty/libprocess/src/http.cpp Lines 729 (patched) <https://reviews.apache.org/r/67992/#comment289178> Ditto. - Benno Evers On July 20, 2018, 3:39 a.m., Ben

Re: Review Request 67632: Always define PICOJSON_USE_INT64.

://reviews.apache.org/r/67632/diff/2-3/ Testing --- Installed stout on my system and compiled an external program using stout's JSON processing functions. Thanks, Benno Evers

Review Request 67719: Fixed formatting in libprocess `README`.

columns were misaligned due to missing whitespace. Diffs - 3rdparty/libprocess/README.md d8b28fae4050a71b1a62fda3e13f2f27e176b121 Diff: https://reviews.apache.org/r/67719/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers.

target) - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67632/#review204946 --- On June 18, 2018, 3:53 p.m., Benno Evers w

Review Request 67633: Removed PICOJSON_USE_INT64 from libprocess build system.

--- It is no longer necessary, since the macro is now set directly within . Diffs - 3rdparty/libprocess/Makefile.am 8910416ce4313a0d70721cf1bb1d1453aaf691f9 Diff: https://reviews.apache.org/r/67633/diff/1/ Testing --- Thanks, Benno Evers

Review Request 67634: Removed PICOJSON_USE_INT64 from Mesos build system.

--- It is no longer needed, since the macro is now directly defined in json.hpp. Diffs - 3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 Diff: https://reviews.apache.org/r/67634/diff/1/ Testing --- Thanks, Benno Evers

Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers.

5b922af6cd58dc03c44aacf88637e89f6e289702 3rdparty/stout/include/stout/json.hpp 5e738cf6f72f32b852beb61a16787e48082dab14 Diff: https://reviews.apache.org/r/67632/diff/1/ Testing --- Thanks, Benno Evers

Review Request 67631: Added non-const accessor for JSON values.

, Benno Evers

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

ot using `process::http::Status::string()` > > https://github.com/apache/mesos/blob/2198b961d24b788564d36490cf52f78d7ec07655/3rdparty/libprocess/src/http.cpp#L176-L180 > > instead? > > > > Maybe then you can even put a single line into `Response` c-tor instead >

Review Request 67575: Changed operator API to notify subscribers on every status change.

54f84120728eea7995422b9c356ed67e5b054623 src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 Diff: https://reviews.apache.org/r/67575/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

/diff/3/ Changes: https://reviews.apache.org/r/67547/diff/2-3/ Testing --- `make check` Thanks, Benno Evers

Re: Review Request 67525: Removed static variable with non-constant initialization.

3rdparty/libprocess/src/tests/http_tests.cpp ca1ea116866b5ccd3d42e93dd5bd7fed2234df0d Diff: https://reviews.apache.org/r/67525/diff/2/ Changes: https://reviews.apache.org/r/67525/diff/1-2/ Testing --- `make check` Thanks, Benno Evers

Review Request 67547: Added check for API endpoints not supporting streaming responses.

, Benno Evers

Review Request 67546: Moved RecordIO documentation into separate file.

c0f20c00f27ac5c81d4b56f166ea4140b5305096 docs/recordio.md PRE-CREATION docs/scheduler-http-api.md bea8817e4cb275d21055eed501c7af0b4b056a9e Diff: https://reviews.apache.org/r/67546/diff/1/ Testing --- Nope. Thanks, Benno Evers

Re: Review Request 67525: Removed static variable with non-constant initialization.

, mark it as deprecated 2) Remove hashmap from the public API, but still define it in `http.cpp` to keep ABI compatibility; - Benno Evers On June 11, 2018, 12:36 p.m., Benno Evers wrote: > > --- > This is an automatically g

Review Request 67525: Removed static variable with non-constant initialization.

: https://reviews.apache.org/r/67525/diff/1/ Testing --- `make check` Thanks, Benno Evers

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/#review204313 --- On June 1, 2018, 3:14 p.m., Benno Evers wrote: > > -

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On May 31, 2018, 4:56 p.m., Benno Evers wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 205 (patched) > > <https://reviews.apache.org/r/67357/diff/2/?file=2033221#file2033221line205> > > > > To be more precise: "which compares either n

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On June 6, 2018, 11:58 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 213 (patched) > > > > > > To avoid conversions and integral promotions, does it make sense to say > > here > >

Re: Review Request 67403: Handled race condition when removing maintenance windows.

> On May 31, 2018, 4:41 p.m., Vinod Kone wrote: > > Can you add a unit test for this? > > Benno Evers wrote: > It's tricky because we need very precise control over the scheduling, and > I'm not sure our testing infrastructure provides it. But I'll look into it.

Review Request 67414: Added default message bodies to libprocess HTTP error responses.

/http.hpp 055447e13117c0a3ba79d0fc326ece657e8f064f Diff: https://reviews.apache.org/r/67414/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 67403: Handled race condition when removing maintenance windows.

> On May 31, 2018, 4:41 p.m., Vinod Kone wrote: > > Can you add a unit test for this? > > Benno Evers wrote: > It's tricky because we need very precise control over the scheduling, and > I'm not sure our testing infrastructure provides it. But I'll look into it.

Re: Review Request 67403: Handled race condition when removing maintenance windows.

linked ticket) Thanks, Benno Evers

Re: Review Request 67403: Handled race condition when removing maintenance windows.

- Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67403/#review204121 --- On May 31, 2018, 4:32 p.m., Benno Ev

Review Request 67403: Handled race condition when removing maintenance windows.

: https://reviews.apache.org/r/67403/diff/1/ Testing --- `make check` Set up the reproduction environment locally and ran `while :; python call.py; done` for about a minute. (see linked ticket) Thanks, Benno Evers

Re: Review Request 67401: Removed undefined behaviour in libprocess due to order-of-evaluation bug.

://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/3655 Thanks, Benno Evers

Review Request 67401: Fixed segfault in libprocess due to order-of-evaluation bug.

://reviews.apache.org/r/67401/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 64384: Added new 'any' setting for reconfiguration_policy flag.

r reviews. I'll try to get a patch out for this as soon as I find some time. - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64384/#review202713 ------- On Dec. 6, 2017, 4:22 p.m., Benno Evers wrote: >

Re: Review Request 67270: Fixed compilation issues in libprocess example.

(updated) - 3rdparty/libprocess/examples/example.cpp a97665ee6b75c5b31397b5a10002fa23a7fe370a Diff: https://reviews.apache.org/r/67270/diff/5/ Changes: https://reviews.apache.org/r/67270/diff/4-5/ Testing --- Compiled the `example.cpp` file. Thanks, Benno Evers

Review Request 67345: Removed unchecked access to an optional in checker process.

://reviews.apache.org/r/67345/diff/1/ Testing --- `make check` (Note that I don't know how to write a unit test for this; suggestions are welcome) Thanks, Benno Evers

Re: Review Request 67270: Fixed compilation issues in libprocess example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67270/#review203886 --- On May 24, 2018, 1:33 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 67280: Added libprocess example code to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67280/#review203857 --- Ship it! Ship It! - Benno Evers On May 24, 2018, 11:52 a.m

Re: Review Request 67270: Fixed compilation issues in libprocess example.

://reviews.apache.org/r/67270/diff/3-4/ Testing --- Compiled the `example.cpp` file. Thanks, Benno Evers

Re: Review Request 67270: Fixed various issues in libprocess example.

/example.cpp a97665ee6b75c5b31397b5a10002fa23a7fe370a Diff: https://reviews.apache.org/r/67270/diff/2/ Changes: https://reviews.apache.org/r/67270/diff/1-2/ Testing --- Compiled the `example.cpp` file. Thanks, Benno Evers

Re: Review Request 67270: Fixed compilation error in libprocess example.

ention here? Can you give an example of how "fixed" looks like? This way is consistent with the comments in the main function. - Benno --- This is an automatically generated e-mail. To reply, visit: https://

Review Request 67270: Fixed compilation error in libprocess example.

. Thanks, Benno Evers

Re: Review Request 67217: Ensured `SlaveRegisteredMessage`s trigger appropriate expectations.

/master_tests.cpp Line 8542 (original), 8538 (patched) <https://reviews.apache.org/r/67217/#comment285846> `Ensure` src/tests/partition_tests.cpp Lines 3328 (patched) <https://reviews.apache.org/r/67217/#comment285847> Missing space before `slave1`. (same for the same comment above) -

Review Request 67004: Added an option to keep downloaded patches to apply-reviews.py.

: https://reviews.apache.org/r/67004/diff/1/ Testing --- Ran `./support/apply-reviews.py` script with and without the new option. Thanks, Benno Evers

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

it not actually valid, so I'll update the review to add it as well. - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63367/#review202383 -----

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

/include/stout/strings.hpp 067a7923c02342bccd9be1136a981fd6b0e0e9b4 3rdparty/stout/tests/strings_tests.cpp 395540aad88c76a66a43a54edfe9ca1a2d46d3b4 Diff: https://reviews.apache.org/r/63367/diff/7/ Changes: https://reviews.apache.org/r/63367/diff/6-7/ Testing --- Thanks, Benno Evers

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

/diff/5-6/ Testing --- Thanks, Benno Evers

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

We don't need the full length of the prefix, as soon as we're at length `s.size()+1` we can abort. - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63367/#review200870

Re: Review Request 66776: Changed failure check for a call to os::system().

-8869 - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66776/#review202274 --- On April 24, 2018, 2:40 p.m., Benno Evers wrote: > > --- >

Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

://reviews.apache.org/r/66815/diff/1/ Testing --- `./src/mesos-tests --gtest_filter=MesosContainerizer/DefaultExecutorTest.TaskUsesExecutor/0 --gtest_repeat=500 --gtest_break_on_failure` Thanks, Benno Evers

Review Request 66405: Doc improvements (wip).

improvements (wip). Testing --- Thanks, Benno Evers

Re: Review Request 63371: Added unit test for new MemoryProfiler class.

/libprocess/src/tests/memory_profiler_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/63371/diff/4/ Changes: https://reviews.apache.org/r/63371/diff/3-4/ Testing --- Thanks, Benno Evers

Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'.

Diff: https://reviews.apache.org/r/66799/diff/1/ Testing --- `./src/mesos-tests --gtest_filter="*MasterAPITest*MasterFailover*" --gtest_repeat=100 --gtest_break_on_failure` Thanks, Benno Evers

Re: Review Request 63372: Added documentation for memory profiling.

sure how much the non-memory-profiling related use cases of jemalloc are relevant here. - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review201844 -----

Re: Review Request 63372: Added documentation for memory profiling.

://reviews.apache.org/r/63372/diff/9/ Changes: https://reviews.apache.org/r/63372/diff/8-9/ Testing --- Thanks, Benno Evers

Re: Review Request 66666: Added MemoryProfiler to CHANGELOG.

Rukletsov. Repository: mesos Description --- Added changelog entry for the MemoryProfiler class that was added to libprocess. Diffs - CHANGELOG 09fff1d50504de158b6c77f51bd7968746e31371 Diff: https://reviews.apache.org/r/6/diff/3/ Testing --- Thanks, Benno Evers

Re: Review Request 63372: Added documentation for memory profiling.

--------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review201770 --- On April 24, 2018, 2:40 p.m., Benno Evers wrote: > > --

Re: Review Request 63372: Added documentation for memory profiling.

://reviews.apache.org/r/63372/diff/8/ Changes: https://reviews.apache.org/r/63372/diff/7-8/ Testing --- Thanks, Benno Evers

Review Request 66776: Changed failure check for a call to os::system().

--- Thanks, Benno Evers

Re: Review Request 66666: Added MemoryProfiler to CHANGELOG.

Rukletsov. Repository: mesos Description --- Added changelog entry for the MemoryProfiler class that was added to libprocess. Diffs - CHANGELOG 09fff1d50504de158b6c77f51bd7968746e31371 Diff: https://reviews.apache.org/r/6/diff/3/ Testing --- Thanks, Benno Evers

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

dcc944840d4e4e611e8ed1b0110b8f1bb189bde9 Diff: https://reviews.apache.org/r/63370/diff/7/ Testing --- Thanks, Benno Evers

Re: Review Request 66711: Made 3rdparty jemalloc only build when enabled.

, i.e. cmake downloading and configuring third-party dependencies that are not going to be used. Am I correct in thinking that for a proper fix, we should wrap *every* third-party dependency into an analogous if-block? - Benno Evers On April 19, 2018, 2:12 a.m., Andrew Schwartzmeyer wrote

Review Request 66700: Changed call from os::shell() to os::system().

/ Testing --- Thanks, Benno Evers

Review Request 66699: Added include to stouts os.hpp header.

--- Thanks, Benno Evers

Re: Review Request 63366: Added jemalloc release tarball and build rules.

943e8f523f867e3dd4030f78eca7830500578faf Diff: https://reviews.apache.org/r/63366/diff/9/ Testing --- Thanks, Benno Evers

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

dcc944840d4e4e611e8ed1b0110b8f1bb189bde9 Diff: https://reviews.apache.org/r/63370/diff/7/ Testing --- Thanks, Benno Evers

Re: Review Request 63366: Added jemalloc release tarball and build rules.

943e8f523f867e3dd4030f78eca7830500578faf Diff: https://reviews.apache.org/r/63366/diff/9/ Testing --- Thanks, Benno Evers

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

9eb37465cd86f408d69f5f98fb76c4f4b93b9acd Diff: https://reviews.apache.org/r/63368/diff/12/ Testing --- Thanks, Benno Evers

Re: Review Request 66577: Enabled CSI proto compilation by default.

), 2369 (patched) <https://reviews.apache.org/r/66577/#comment282515> Will this library also get built when using `cmake`? src/Makefile.am Lines 2498 (patched) <https://reviews.apache.org/r/66577/#comment282513> This seems to be missing in the `CMakeLists.txt`? - Benno Evers

Review Request 66666: Added MemoryProfiler to CHANGELOG.

Description --- Added changelog entry for the MemoryProfiler class that was added in the previous commit. Diffs - CHANGELOG c02d56d6612c432bb079a15fde84cb30d7455971 Diff: https://reviews.apache.org/r/6/diff/1/ Testing --- Thanks, Benno Evers

Review Request 66643: WIP: Attribute filters.

dbb35befd612f4be1019293c1889d19296118d07 Diff: https://reviews.apache.org/r/66643/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

r either clean the state before > > starting a new run or disallow implicit, i.e., without id, download request > > if a profiling is running. Ok, added as a special case. - Benno --- This is an automatically generate

Re: Review Request 63372: Added documentation for memory profiling.

/5-6/ Testing --- Thanks, Benno Evers

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

e/main.cpp dcc944840d4e4e611e8ed1b0110b8f1bb189bde9 Diff: https://reviews.apache.org/r/63370/diff/6/ Changes: https://reviews.apache.org/r/63370/diff/5-6/ Testing --- Thanks, Benno Evers

Re: Review Request 63366: Added jemalloc release tarball and build rules.

://reviews.apache.org/r/63366/diff/7/ Testing --- Thanks, Benno Evers

Re: Review Request 65462: Used the new 'route()' overload from libprocess.

(updated) --- `make check` on Mac OS and some linux variants. Thanks, Benno Evers

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

Without this, and assuming the user doesn't manually link against jemalloc, all endpoints will just return an error message saying that jemalloc couldn't be detected. - Benno --- This is an automatically generated e-mail. To

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

-CREATION 3rdparty/libprocess/src/process.cpp 9eb37465cd86f408d69f5f98fb76c4f4b93b9acd Diff: https://reviews.apache.org/r/63368/diff/9/ Changes: https://reviews.apache.org/r/63368/diff/8-9/ Testing --- Thanks, Benno Evers

Re: Review Request 63366: Add jemalloc release tarball and build rules.

: https://reviews.apache.org/r/63366/diff/5-6/ Testing --- Thanks, Benno Evers

Re: Review Request 65462: Used the new 'route()' overload from libprocess.

/registrar.cpp a83514294010139117d983800d2819d65e8c2d9e Diff: https://reviews.apache.org/r/65462/diff/2/ Testing --- Thanks, Benno Evers

<    1   2   3   4   5   6   7   8   9   >