Re: Review Request 64247: Fixed a flaky test case in reservation tests.

=ResourceProviderCapability/ReservationTest.MasterFailover/1 --gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the background (on a 4 core machine) Thanks, Jan Schlicht

Re: Review Request 64247: Fixed a flaky test case in reservation tests.

=ResourceProviderCapability/ReservationTest.MasterFailover/1 --gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the background (on a 4 core machine) Thanks, Jan Schlicht

Review Request 64335: Made "agent_features" flag available on non-Linux systems.

0e49853fdf Diff: https://reviews.apache.org/r/64335/diff/1/ Testing --- make check Ran `src/mesos-agent --help` on macOS and checked that the `agent_feature` flag is listed there. Thanks, Jan Schlicht

Re: Review Request 64151: Added a V1 API call to list resource providers.

a4c19ca769e66110d9aba0bae4792df9db3fed01 Diff: https://reviews.apache.org/r/64151/diff/5/ Changes: https://reviews.apache.org/r/64151/diff/4-5/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63389: Added a mock resource provider manager.

m not opening an issue for that. - Jan Schlicht On Nov. 15, 2017, 3:46 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 64247: Fixed a flaky test case in reservation tests.

--gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the background (on a 4 core machine) Thanks, Jan Schlicht

Re: Review Request 64065: Allowed resubscription of resource providers.

--- make check Thanks, Jan Schlicht

Re: Review Request 64168: Introduced a 'OperationUUID' type.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64168/#review192230 ------- On Nov. 29, 2017, 6:07 p.m., Jan Schlicht wrote: > >

Re: Review Request 64151: Added a V1 API call to list resource providers.

-format 64b529c482db9be48e12242fd32832596b2ad883 Diff: https://reviews.apache.org/r/64151/diff/2/ Changes: https://reviews.apache.org/r/64151/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Review Request 64168: Introduced a 'OperationUUID' type.

/tests/resource_provider_validation_tests.cpp bf789a05771b7c25f2fc2a8a5b35d38519e4793b Diff: https://reviews.apache.org/r/64168/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 64158: Used helper functions instead of switches for resource extraction.

2a2e830354db4a2191fb8321beb8174b80f7ba7d src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 src/slave/slave.cpp e1566832f90cca372ad2f1cc13d1e7f76fa53285 Diff: https://reviews.apache.org/r/64158/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64151: Added an agent endpoint to list resource providers.

://reviews.apache.org/r/64151/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 64151: Added an agent endpoint to list resource providers.

394e91013dc11e0a79e2e00534864281cc74ad2f src/slave/slave.cpp e1566832f90cca372ad2f1cc13d1e7f76fa53285 src/tests/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45 Diff: https://reviews.apache.org/r/64151/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64054: Refactored offer operation handling for speculative operations.

53263e499d88b906b6406c24c0dfb737e589e813 src/slave/slave.cpp 6ed5c7887cf998b92cf3181b29cb6cf09cc73e61 Diff: https://reviews.apache.org/r/64054/diff/4/ Changes: https://reviews.apache.org/r/64054/diff/3-4/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64065: Allowed resubscription of resource providers.

/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45 src/tests/slave_tests.cpp a2274b691cf94b003c4bc15450d176a9c73517d5 Diff: https://reviews.apache.org/r/64065/diff/3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64065: Allowed resubscription of resource providers.

that. Never liked that reference/pointer here as well. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64065/#review191974 ------- On Nov. 28, 2017, 12:17 p.m., Jan Schlicht wrote: > > -

Re: Review Request 64065: Allowed resubscription of resource providers.

/64065/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64054: Refactored offer operation handling for speculative operations.

53263e499d88b906b6406c24c0dfb737e589e813 src/slave/slave.cpp 6ed5c7887cf998b92cf3181b29cb6cf09cc73e61 Diff: https://reviews.apache.org/r/64054/diff/3/ Changes: https://reviews.apache.org/r/64054/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64086: Removed currently unneeded 'AWAIT_READY's in 'MockResourceProvider'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64086/#review191891 --- Ship it! Ship It! - Jan Schlicht On Nov. 27, 2017, 4:18 p.m

Re: Review Request 64001: Made sure all true allocator agent updates return correct status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64001/#review191877 --- Ship it! Ship It! - Jan Schlicht On Nov. 24, 2017, 3:07 p.m

Re: Review Request 64056: Added a helper to extract consumed resources from offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64056/#review191836 --- Ship it! Ship It! - Jan Schlicht On Nov. 24, 2017, 10:31

Re: Review Request 64054: Refactored offer operation handling for speculative operations.

--- make check Thanks, Jan Schlicht

Review Request 64054: Refactored offer operation handling for speculative operations.

check Thanks, Jan Schlicht

Re: Review Request 64053: Fixed a flaky resource provider test.

- src/tests/resource_provider_manager_tests.cpp ce4335b4209caf39347bec516d4820a515dd9c1d Diff: https://reviews.apache.org/r/64053/diff/1/ Testing (updated) --- ./bin/mesos-tests.sh --gtest_filter=*ConvertResources* --gtest_repeat=200 --gtest_break_on_failure Thanks, Jan Schlicht

Review Request 64053: Fixed a flaky resource provider test.

/resource_provider_manager_tests.cpp ce4335b4209caf39347bec516d4820a515dd9c1d Diff: https://reviews.apache.org/r/64053/diff/1/ Testing --- ./bin/mesos-tests.sh --gtest_filter=*ConvertResources* --gtest_repeat=200 --gtest_break_on_failure Thanks, Jan Schlicht

Re: Review Request 63798: Added resource provider support for all offer operations.

/5/ Changes: https://reviews.apache.org/r/63798/diff/4-5/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

4> > > > > Can you add a comment about what that `bool` represents? Ditto in > > ReservationTest Changed it to an enumeration, as that is more clear than a boolean and can be named. - Jan --- This is an autom

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

To reply, visit: https://reviews.apache.org/r/63751/#review191109 ------- On Nov. 22, 2017, 1:11 p.m., Jan Schlicht wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

: https://reviews.apache.org/r/63751/diff/8/ Changes: https://reviews.apache.org/r/63751/diff/7-8/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63798: Added resource provider support for all offer operations.

Thanks, Jan Schlicht

Review Request 63986: Refactored 'MockResourceProvider' to include default functions.

://reviews.apache.org/r/63986/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

: https://reviews.apache.org/r/63751/diff/7/ Changes: https://reviews.apache.org/r/63751/diff/6-7/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 62502: Added an event to publish resources.

345b883a8c629bf5bed83e9236632c277f2eb0eb Diff: https://reviews.apache.org/r/62502/diff/3/ Changes: https://reviews.apache.org/r/62502/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63912: Changed agent (re-)registration to set resource versions.

://reviews.apache.org/r/63912/diff/2/ Changes: https://reviews.apache.org/r/63912/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

470f7341686e69d0a71fb234a26b277c45c29780 Diff: https://reviews.apache.org/r/63751/diff/6/ Changes: https://reviews.apache.org/r/63751/diff/5-6/ Testing --- make check Thanks, Jan Schlicht

Review Request 63912: Changed agent (re-)registration to set resource versions.

'. This created situations where the master would crash. Diffs - src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f Diff: https://reviews.apache.org/r/63912/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 63911: Bumped up the number of args allowed in some libprocess templates.

1540a78e52a90d4c1d4165c46be353caaad21bce Diff: https://reviews.apache.org/r/63911/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

acfeac16884b00581a3523607ff26f44f6dca53a src/tests/reservation_tests.cpp 470f7341686e69d0a71fb234a26b277c45c29780 Diff: https://reviews.apache.org/r/63751/diff/5/ Changes: https://reviews.apache.org/r/63751/diff/4-5/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63798: Added resource provider support for all offer operations.

d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0 src/tests/resource_provider_manager_tests.cpp ecfe2b4c0952838d6312df603f8eb2f458725175 Diff: https://reviews.apache.org/r/63798/diff/3/ Changes: https://reviews.apache.org/r/63798/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

470f7341686e69d0a71fb234a26b277c45c29780 Diff: https://reviews.apache.org/r/63751/diff/4/ Changes: https://reviews.apache.org/r/63751/diff/3-4/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63798: Added resource provider support for all offer operations.

://reviews.apache.org/r/63798/diff/2/ Changes: https://reviews.apache.org/r/63798/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

/ Changes: https://reviews.apache.org/r/63751/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63555: Publish resource provider resources before container launch or update.

> On Nov. 9, 2017, 1:52 p.m., Jan Schlicht wrote: > > src/slave/slave.hpp > > Lines 538 (patched) > > <https://reviews.apache.org/r/63555/diff/1/?file=1881011#file1881011line538> > > > > What's the motivation for this `extra` parameter? It isn't used

Re: Review Request 63732: Reconciled offer operations between agent and master.

erwise frameworks will receive no feedback for these operations. - Jan Schlicht On Nov. 13, 2017, 7:33 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 63730: Passed operations from resource provider to agent.

in `message.hpp` is already fixed in `master`. src/resource_provider/manager.cpp Line 477 (original), 477 (patched) <https://reviews.apache.org/r/63730/#comment268523> Remove the space after `resourceProvider`. - Jan Schlicht On Nov. 13, 2017, 7:33 p.m., Benjamin Bannier

Review Request 63799: Improved log messages of offer operations.

Thanks, Jan Schlicht

Review Request 63798: Added resource provider support for all offer operations.

to allow offer pipelining. Diffs - src/slave/slave.cpp d8bacebc74790e955490a158c37ac0d9e75fd6b5 src/tests/resource_provider_manager_tests.cpp ecfe2b4c0952838d6312df603f8eb2f458725175 Diff: https://reviews.apache.org/r/63798/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 63797: Changed resource checkpointing to no longer failover.

/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63767: Added a missing protobuf field to the unversioned definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63767/#review190923 --- Ship it! Ship It! - Jan Schlicht On Nov. 14, 2017, 12:17

Re: Review Request 63791: Handled the resource conversion for new operations in master.

Thanks, Jan Schlicht

Review Request 63791: Handled the resource conversion for new operations in master.

/master.cpp 59a533940736f5cfd5ec31e0ed924f0b2ab13f9c Diff: https://reviews.apache.org/r/63791/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63737: Handled the resource conversion for new operations in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63737/#review190860 --- Ship it! Ship It! - Jan Schlicht On Nov. 10, 2017, 6:55 p.m

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

470f7341686e69d0a71fb234a26b277c45c29780 Diff: https://reviews.apache.org/r/63751/diff/2/ Changes: https://reviews.apache.org/r/63751/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63622: Provided handling for offer operation updates.

://reviews.apache.org/r/63622/diff/6/ Changes: https://reviews.apache.org/r/63622/diff/5-6/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63751: Triggered 'ApplyOfferOperatioMessage' for agent local resources.

49dbaa979d692061a7b479b1db4511e8357b8baf src/slave/slave.cpp 7cb6661b55fb5437a1ffc447f974076aadd1eced src/tests/reservation_tests.cpp 470f7341686e69d0a71fb234a26b277c45c29780 Diff: https://reviews.apache.org/r/63751/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 63751: Triggered 'ApplyOfferOperatioMessage' for agent local resources.

/reservation_tests.cpp 470f7341686e69d0a71fb234a26b277c45c29780 Diff: https://reviews.apache.org/r/63751/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63625: Added a test for resource conversion using a resource provider.

://reviews.apache.org/r/63625/diff/3/ Changes: https://reviews.apache.org/r/63625/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

(patched) <https://reviews.apache.org/r/63689/#comment268307> This should be part of `Slave::apply`, as the exact same code is used again in `Slave::addOfferOperation`. - Jan Schlicht On Nov. 10, 2017, 2:24 a.m., Jie Yu

Re: Review Request 63622: Provided handling for offer operation updates.

--- make check Thanks, Jan Schlicht

Re: Review Request 63622: Provided handling for offer operation updates.

Diff: https://reviews.apache.org/r/63622/diff/4/ Changes: https://reviews.apache.org/r/63622/diff/3-4/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63555: Publish resource provider resources before container launch or update.

urces of all executor of all frameworks? Or am I missing something here? I'd expect that only the RP resources of the task/executor that's about to get started should be published. Hence `resourceProviderManager->publish(info.id(), executor->allocatedResources())` should be enough. - Jan Sc

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

Or we move the switch to `Master::_apply` so that `Slave::apply` is only called for `RESERVE`, `UNRESERVE`, `CREATE`, `DESTROY`. - Jan Schlicht On Nov. 9, 2017, 1:02 a.m., Jie Yu wrote: > > --- > This is an automatically g

Re: Review Request 63625: Added a test for resource conversion using a resource provider.

://reviews.apache.org/r/63625/diff/2/ Changes: https://reviews.apache.org/r/63625/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Review Request 63679: Added test helpers for storage operations.

Description --- See summary. Diffs - src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 Diff: https://reviews.apache.org/r/63679/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63622: Provided handling for offer operation updates.

> src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 > src/slave/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1 > src/tests/resource_provider_manager_tests.cpp > 4008b1c751d6227b99adef756e95174d7d8a62f2 > > > Diff: https://reviews.apache.org/r/63622/diff/3/ > > > Testing > --- > > make check > > > Thanks, > > Jan Schlicht > >

Re: Review Request 63622: Provided handling for offer operation updates.

/resource_provider_manager_tests.cpp 4008b1c751d6227b99adef756e95174d7d8a62f2 Diff: https://reviews.apache.org/r/63622/diff/3/ Changes: https://reviews.apache.org/r/63622/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63621: Added a devolve function for 'OfferOperationStatus'.

e05fcd4d0f423a2ba13bdcf6ba6561b43e31977d Diff: https://reviews.apache.org/r/63621/diff/2/ Changes: https://reviews.apache.org/r/63621/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63622: Provided handling for offer operation updates.

/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1 src/tests/resource_provider_manager_tests.cpp 4008b1c751d6227b99adef756e95174d7d8a62f2 Diff: https://reviews.apache.org/r/63622/diff/2/ Changes: https://reviews.apache.org/r/63622/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63620: Updated offer operation handling to set resource versions.

ee212c1a21b432d3aa8e90d748d12cb0a754d57c Diff: https://reviews.apache.org/r/63620/diff/2/ Changes: https://reviews.apache.org/r/63620/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63622: Provided handling for offer operation updates.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63622/#review190355 --- On Nov. 7, 2017, 3:20 p.m., Jan Schlicht wrote: > > ---

Review Request 63625: Added a test for resource conversion using a resource provider.

Description --- Added a test for resource conversion using a resource provider. Diffs - src/tests/resource_provider_manager_tests.cpp 4008b1c751d6227b99adef756e95174d7d8a62f2 Diff: https://reviews.apache.org/r/63625/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 63622: Provided handling for offer operation updates.

/resource_provider_manager_tests.cpp 4008b1c751d6227b99adef756e95174d7d8a62f2 Diff: https://reviews.apache.org/r/63622/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 63621: Added a devolve function for 'OfferOperationStatus'.

Description --- See summary. Diffs - src/internal/devolve.hpp 48d9c33fff376f7842f9b72bf84056482cefadcd src/internal/devolve.cpp e05fcd4d0f423a2ba13bdcf6ba6561b43e31977d Diff: https://reviews.apache.org/r/63621/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 63620: Updated offer operation handling to set resource versions.

--- make check Thanks, Jan Schlicht

Re: Review Request 63584: Added agent ID to offer operation protobuf helper.

/r/63584/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 63584: Added agent ID to offer operation protobuf helper.

da0a84eb828e2fb064ba466d9e525cd3a85fc43a src/common/protobuf_utils.cpp 4ce7021b01b9fb52ae1a8d95aa686c5b79164d67 src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28 Diff: https://reviews.apache.org/r/63584/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63107: Added operation feedback for storage operations.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63107/#review188618 ------- On Oct. 20, 2017, 2:56 p.m., Jan Schlicht wrote: > >

Re: Review Request 63107: Added operation feedback for storage operations.

aea1e948209c7c8945665915bc2f6d8eb47814ef src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac Diff: https://reviews.apache.org/r/63107/diff/2/ Changes: https://reviews.apache.org/r/63107/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 61947: Implemented handling of resource provider offer operations.

tps://reviews.apache.org/r/61947/diff/4/ Changes: https://reviews.apache.org/r/61947/diff/3-4/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63105: Removed TODOs from storage operation 'apply' handlers.

://reviews.apache.org/r/63105/diff/2/ Changes: https://reviews.apache.org/r/63105/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 61810: Added a function to apply offer operations.

Thanks, Jan Schlicht

Re: Review Request 63104: Added a helper to extract resources from storage operations.

/protobuf_utils.hpp c43ab75b5492320dfe19a7c723a72ac52b8ab722 src/common/protobuf_utils.cpp fd4858a64dfc136dd03cb1eef4c97d0f8d43bdae Diff: https://reviews.apache.org/r/63104/diff/2/ Changes: https://reviews.apache.org/r/63104/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63107: Added operation feedback for storage operations.

_provider/message.hpp Line 36 (original), 37 (patched) <https://reviews.apache.org/r/63107/#comment265825> I'll rebase on https://reviews.apache.org/r/62903/, it'll be `UPDATE_STATE` then. - Jan Schlicht On Oct. 18, 2017, 4:39 p.m., Jan

Re: Review Request 63106: Added a metric value for received offer operation updates.

64fc829ac3b58d95fc0bd074571a46518a80bbba Diff: https://reviews.apache.org/r/63106/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63107: Added operation feedback for storage operations.

4d7dc8e9a3901b00103031e24e5d6328d0f2e2ad Diff: https://reviews.apache.org/r/63107/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63105: Added 'apply' handlers for storage operations.

/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63104: Added a helper to extract resources from storage operations.

/protobuf_utils.cpp fd4858a64dfc136dd03cb1eef4c97d0f8d43bdae Diff: https://reviews.apache.org/r/63104/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 63107: Added operation feedback for storage operations.

src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521 src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef src/slave/slave.cpp 4d7dc8e9a3901b00103031e24e5d6328d0f2e2ad Diff: https://reviews.apache.org/r/63107/diff/1/ Testing --- make check Thanks, Jan

Review Request 63106: Added a metric value for received offer operation updates.

check Thanks, Jan Schlicht

Re: Review Request 61947: Implemented handling of resource provider offer operations.

://reviews.apache.org/r/61947/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Review Request 63105: Added 'apply' handlers for storage operations.

Description --- Added 'apply' handlers for storage operations. Diffs - src/common/resources.cpp 7ee4dae1389e037531aec533a3d235ee06443ea8 Diff: https://reviews.apache.org/r/63105/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 61946: Added validation of resource provider operations.

f4925752f20ae8ca4de1d9b4a3d5ffc394db9585 src/master/validation.cpp 01bc2e0ad4de0bad570453cdaafb260c61c511eb Diff: https://reviews.apache.org/r/61946/diff/2/ Changes: https://reviews.apache.org/r/61946/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 61810: Added a function to apply offer operations.

31fcb789f5ab907511e868c374c49f7457a33ed3 src/tests/resource_provider_manager_tests.cpp ca49e1f0203494fc8b4a4507c33e5a3885a14a59 Diff: https://reviews.apache.org/r/61810/diff/2/ Changes: https://reviews.apache.org/r/61810/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Review Request 63104: Added a helper to extract resources from storage operations.

/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

nt265283> Change the comment to `// See 'UpdateOperationStatus' below.` src/messages/messages.proto Lines 637-638 (patched) <https://reviews.apache.org/r/63001/#comment265313> Please correct the spacing here. - Jan Schlicht On Oct. 17,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

rom applying the operation have to be sent here as part of this operation. Otherwise the master won't be able to recover these resources and offer them to frameworks. Also the `operation` (or at least its resources) need to be included to be able to rollback resources in case of a failure. -

Re: Review Request 62502: Added events to publish and unpublish resources.

Thanks, Jan Schlicht

Re: Review Request 62502: Added events to publish and unpublish resources.

24d220e292bc1e137992e8f81484477b62bd0896 Diff: https://reviews.apache.org/r/62502/diff/2/ Changes: https://reviews.apache.org/r/62502/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 62502: Added PUBLISH and UNPUBLISH events.

Will update this patch accordingly. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review187703 ------- On

Re: Review Request 62842: Fixed 'operator==' for 'v1::Resource::DiskInfo::Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62842/#review187401 --- Ship it! Ship It! - Jan Schlicht On Oct. 9, 2017, 2:13 p.m

<    1   2   3   4   5   6   7   8   9   10   >