Re: Review Request 47161: Fixed replica log restore tests.

2016-05-10 Thread Tomasz Janiszewski
---------- On Maj 10, 2016, 5:50 po poĊ‚udniu, Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47161/ >

Re: Review Request 47161: Fixed replica log restore tests.

2016-05-10 Thread Tomasz Janiszewski
this patch all tests passed. Thanks, Tomasz Janiszewski

Re: Review Request 47161: Fixed replica log restore tests.

2016-05-10 Thread Tomasz Janiszewski
this patch all tests passed. Thanks, Tomasz Janiszewski

Re: Review Request 47161: Fixed replica log restore tests.

2016-05-10 Thread Tomasz Janiszewski
ps://reviews.apache.org/r/47161/#review132445 ------- On May 10, 2016, 9:02 a.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 47161: Fixed replica log restore tests.

2016-05-10 Thread Tomasz Janiszewski
ly generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/#review132388 ------- On May 10, 2016, 9:02 a.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e

Re: Review Request 47161: Fixed replica log restore tests.

2016-05-10 Thread Tomasz Janiszewski
` after this patch all tests passed. Thanks, Tomasz Janiszewski

Review Request 47161: Fixed replica log restore tests.

2016-05-10 Thread Tomasz Janiszewski
. Diffs - src/tests/log_tests.cpp 4cd6bc359d481c065d9647b3d5f0154cb5cb2503 Diff: https://reviews.apache.org/r/47161/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 46730: Cleanup syscalls logic.

2016-04-30 Thread Tomasz Janiszewski
ms without platform conditions. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review131253 --- On Kwi 29, 2016,

Re: Review Request 46730: Cleanup syscalls logic.

2016-04-29 Thread Tomasz Janiszewski
://reviews.apache.org/r/46730/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 46730: Cleanup syscalls logic.

2016-04-29 Thread Tomasz Janiszewski
condition for old glibc and thought it could be replaced with kernel macro. Reverted my change - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review130831 --- On April 29, 2016, 8:

Re: Review Request 46730: Cleanup syscalls logic.

2016-04-29 Thread Tomasz Janiszewski
/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 Diff: https://reviews.apache.org/r/46730/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 46730: Cleanup syscalls logic.

2016-04-27 Thread Tomasz Janiszewski
/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 Diff: https://reviews.apache.org/r/46730/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 46730: Cleanup syscalls logic.

2016-04-27 Thread Tomasz Janiszewski
not necessary but I think it will be consitent if all syscalls were taken from one place `` - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review130755 -----

Review Request 46730: Cleanup syscalls logic.

2016-04-27 Thread Tomasz Janiszewski
244a811b299c29b1dcd6652bd26e861e04df3f54 Diff: https://reviews.apache.org/r/46730/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

2016-04-24 Thread Tomasz Janiszewski
.c_str()); > ``` > > as well. And you need fill a ticket for this in > https://issues.apache.org/jira/browse/MESOS and find a shepherd by sending > email to dev mailing list. > > Tomasz Janiszewski wrote: > It looks like powerpc is properly handled with &g

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

2016-04-24 Thread Tomasz Janiszewski
-electrons.com/source/arch/powerpc/include/uapi/asm/unistd.h#L218) - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46610/#review130303 --------

Review Request 46610: Fix 'pivot_root is not available' error on ARM.

2016-04-24 Thread Tomasz Janiszewski
--- Fix 'pivot_root is not available' error on ARM. Diffs - src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f Diff: https://reviews.apache.org/r/46610/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 45482: Replace NULL with nullptr.

2016-03-31 Thread Tomasz Janiszewski
5482/diff/ Testing --- Thanks, Tomasz Janiszewski

Review Request 45480: Replace NULL with nullptr.

2016-03-30 Thread Tomasz Janiszewski
src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 src/zookeeper/group.cpp ca5e99d09825bf5ace7ba59c95266c51e246974f src/zookeeper/zookeeper.cpp 02fa158a37ddaf045bdf6403c134d03a02c74833 Diff: https://reviews.apache.org/r/45480/diff/ Testing --- Thanks, Tomasz Janiszewski

Review Request 45482: Replace NULL with nullptr.

2016-03-30 Thread Tomasz Janiszewski
che.org/r/45482/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 44843: Replace NULL with nullptr.

2016-03-28 Thread Tomasz Janiszewski
gt; `clang-tidy` magic, right? Exactly - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44843/#review125535 --- On March 28, 20

Re: Review Request 44843: Replace NULL with nullptr.

2016-03-28 Thread Tomasz Janiszewski
keeper/zookeeper.hpp 9191df50dd5b601491a86584f7184a31a6151ca5 src/zookeeper/zookeeper.cpp 02fa158a37ddaf045bdf6403c134d03a02c74833 Diff: https://reviews.apache.org/r/44843/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

2016-03-22 Thread Tomasz Janiszewski
/fetcher_tests.cpp 375e690ead4f954a66a6efc2f2daa7fb1f1a024d Diff: https://reviews.apache.org/r/45134/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

2016-03-22 Thread Tomasz Janiszewski
375e690ead4f954a66a6efc2f2daa7fb1f1a024d Diff: https://reviews.apache.org/r/45134/diff/ Testing --- Thanks, Tomasz Janiszewski

Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

2016-03-21 Thread Tomasz Janiszewski
://issues.apache.org/jira/browse/MESOS-4993 Repository: mesos Description --- Skip FetcherTest zip tests when `unzip` is uninstalled. Diffs - src/tests/fetcher_tests.cpp 375e690ead4f954a66a6efc2f2daa7fb1f1a024d Diff: https://reviews.apache.org/r/45134/diff/ Testing --- Thanks, Tomasz

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

2016-03-20 Thread Tomasz Janiszewski
fb47706eb90ae5808bafe13c681d609a808b0c8e Diff: https://reviews.apache.org/r/45057/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

2016-03-19 Thread Tomasz Janiszewski
fb47706eb90ae5808bafe13c681d609a808b0c8e Diff: https://reviews.apache.org/r/45057/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

2016-03-19 Thread Tomasz Janiszewski
fb47706eb90ae5808bafe13c681d609a808b0c8e Diff: https://reviews.apache.org/r/45057/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

2016-03-19 Thread Tomasz Janiszewski
he.org/r/45057/#review124380 --- On March 18, 2016, 10:29 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Review Request 45057: Made `unzip` overwrite existing files without prompting.

2016-03-18 Thread Tomasz Janiszewski
://reviews.apache.org/r/45057/diff/ Testing --- Thanks, Tomasz Janiszewski

Review Request 44843: Replace NULL with nullptr.

2016-03-15 Thread Tomasz Janiszewski
src/zookeeper/group.cpp 7aa95a7b7eafe0a2c49dc077b3a4abd688e5d8e8 src/zookeeper/zookeeper.cpp 02fa158a37ddaf045bdf6403c134d03a02c74833 Diff: https://reviews.apache.org/r/44843/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Tomasz Janiszewski
Yu, and Joris Van Remoortere. Repository: mesos Description --- Network monitoring metrics table has common style Diffs (updated) - docs/network-monitoring.md b266ae5 Diff: https://reviews.apache.org/r/39358/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Tomasz Janiszewski
ly, visit: https://reviews.apache.org/r/39358/#review104360 ------- On Oct. 29, 2015, 8:44 a.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Tomasz Janiszewski
, Tomasz Janiszewski

Review Request 39358: Network monitoring metrics table has common style

2015-10-15 Thread Tomasz Janiszewski
Description --- Network monitoring metrics table has common style Diffs - docs/network-monitoring.md b266ae59cd698ed11dc49ee1987efb868e2ef746 Diff: https://reviews.apache.org/r/39358/diff/ Testing --- Thanks, Tomasz Janiszewski

<    1   2   3