---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59014/#review174255
---
Ship it!
Ship It!
- Vinod Kone
On May 5, 2017, 8:30 p.m
/store.cpp
Line 235 (original), 243-244 (patched)
<https://reviews.apache.org/r/59013/#comment247383>
I'm assuming you need `config` here explicitly and cannot get it from
`image` below?
- Vinod Kone
On May 4, 2017, 11:22 p.m., Gilbert
gt;
> (Updated May 5, 2017, 11:16 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till
> Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
&g
t;
is the default needed here to avoid updating tests?
src/slave/containerizer/mesos/provisioner/store.hpp
Lines 64 (patched)
<https://reviews.apache.org/r/59012/#comment247381>
ditto.
- Vinod Kone
On May 5, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59011/#review174250
---
Ship it!
Ship It!
- Vinod Kone
On May 4, 2017, 11:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59010/#review174249
---
Ship it!
Ship It!
- Vinod Kone
On May 5, 2017, 8:30 p.m
tps://reviews.apache.org/r/58999/#comment247379>
If the pointer to resolver is only passed to the containerizer, how will
the agent get access to it to resolve executor auth token?
- Vinod Kone
On May 8, 2017, 10:19 p.m., Kapil Arya
.org/r/59000/#comment247378>
no need for `Times(1)`
- Vinod Kone
On May 8, 2017, 10:19 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59000/
> -
ched)
<https://reviews.apache.org/r/58999/#comment247366>
why is this introduced in this review?
src/slave/flags.cpp
Lines 963 (patched)
<https://reviews.apache.org/r/58999/#comment247359>
The name of the secret resolver to use for resolving enivornment and file
based secrets.
- Vinod Kone
(patched)
<https://reviews.apache.org/r/58760/#comment247355>
The comment about default resolver behavior in the previous review should
be here instead.
src/secret/resolver.cpp
Lines 72 (patched)
<https://reviews.apache.org/r/58760/#comment247356>
new line above.
- Vinod Kon
/reviews.apache.org/r/58759/#comment247353>
Do we typically talk about default implementations here?
include/mesos/secret/resolver.hpp
Lines 54 (patched)
<https://reviews.apache.org/r/58759/#comment247354>
s/to a/a/
- Vinod Kone
On May 8
ch version with "-dev"? Not sure if this
breaks our release scripts though.
- Vinod Kone
On May 8, 2017, 10:01 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vis
,
Vinod Kone
N format with
UTF-8 character encoding.
- Vinod Kone
On April 30, 2017, 11:23 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
tate.hpp
Lines 310 (patched)
<https://reviews.apache.org/r/56895/#comment246711>
s/hasRebooted/rebooted/
- Vinod Kone
On April 26, 2017, 6:16 p.m., Megha Sharma wrote:
>
> ---
> This is an automatically generated
_tests.cpp
cc8499a5ec05cf7b2283c075e47298918f50bd24
Diff: https://reviews.apache.org/r/58941/diff/1/
Testing
---
make check
Thanks,
Vinod Kone
_tests.cpp
1237d081d781948975f66a8240ae9bdb5e819a3b
Diff: https://reviews.apache.org/r/58940/diff/1/
Testing
---
make check
Thanks,
Vinod Kone
6 (patched)
<https://reviews.apache.org/r/58762/#comment246526>
I think these should return an error instead of crashing the agent.
src/slave/slave.cpp
Lines 7668 (patched)
<https://reviews.apache.org/r/58762/#comment246527>
Ditto. No await please.
- Vinod Kone
On April 28, 201
), 243-245 (patched)
<https://reviews.apache.org/r/58761/#comment246505>
why is this mentioned twice? what's the difference between "Secret fetcher"
and "SecretFetcher" ?
- Vinod Kone
On April 28, 20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/#review173515
---
Ship it!
Ship It!
- Vinod Kone
On April 28, 2017, 6:50 p.m
tps://reviews.apache.org/r/58759/#comment246504>
Should this be just called `Fetcher` since it is in the `secret` namespace
already? Looks like this is how URI, APPC etc fetchers are named.
- Vinod Kone
On April 28, 2017, 6:50 p.m., Kapil Arya
> On April 28, 2017, 8:49 p.m., Vinod Kone wrote:
> > Nice test.
Modulo Jie's comment.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263
atched)
<https://reviews.apache.org/r/58263/#comment246386>
s/, also/even/
- Vinod Kone
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To
tainerizer.proto
Lines 187 (patched)
<https://reviews.apache.org/r/58820/#comment246383>
s/the image/an image/
- Vinod Kone
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58819/#review173377
---
Ship it!
Ship It!
- Vinod Kone
On April 28, 2017, 4:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58818/#review173376
---
Ship it!
Nice test.
- Vinod Kone
On April 28, 2017, 4:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58817/#review173375
---
Ship it!
Thanks for fixing this!
- Vinod Kone
On April 28
gt;
s/access/accesses/ ?
- Vinod Kone
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58847/#review173368
---
Ship it!
LGTM modulo Jie's comments.
- Vinod Kone
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58810/#review173248
---
Ship it!
Ship It!
- Vinod Kone
On April 27, 2017, 7 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58764/#review173131
---
Ship it!
Ship It!
- Vinod Kone
On April 26, 2017, 11:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58765/#review173128
---
Ship it!
Ship It!
- Vinod Kone
On April 26, 2017, 11:32 p.m
.
- Vinod Kone
On April 20, 2017, 11:34 a.m., Andy Pang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58287/
> --
--
>
> (Updated April 25, 2017, 9:06 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-6782
> https://issues.apache.org/jira/browse/MESOS-6782
>
>
>
> On April 13, 2017, 12:45 a.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 1386-1389 (original), 1401-1404 (patched)
> > <https://reviews.apache.org/r/58262/diff/3/?file=1686498#file1686498line1404>
> >
> > Previous
Lines 521 (patched)
<https://reviews.apache.org/r/58718/#comment246185>
Move this to #548?
src/tests/check_tests.cpp
Lines 556-557 (patched)
<https://reviews.apache.org/r/58718/#comment246186>
Why does one take a ref and other a copy?
- Vinod Kone
On April 25, 20
), 950-954 (patched)
<https://reviews.apache.org/r/58557/#comment245889>
how about
```
} else {
LOG(ERROR) << "Failed to accept socket: "
<< (socket.isFailed() ? socket.failure() : "future discarded");
}
```
- Vi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58506/#review172865
---
Ship it!
Ship It!
- Vinod Kone
On April 18, 2017, 2:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58421/#review172864
---
Ship it!
Ship It!
- Vinod Kone
On April 18, 2017, 2 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58635/#review172852
---
Ship it!
Ship It!
- Vinod Kone
On April 21, 2017, 10:02 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58626/#review172851
---
Ship it!
Ship It!
- Vinod Kone
On April 21, 2017, 10:03 p.m
mind committing it separately?
Will do.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58683/#review172841
---
On Apri
/r/58683/diff/1/
Testing
---
Used the following expression (from
https://chromium.googlesource.com/chromium/src/+/master/styleguide/gender_neutral_code.md)
to catch the offending lines.
git grep -wiEI \ '(he)|(she)|(his)|(hers)|(him)|(her)|(guy)|(guys)'
Thanks,
Vinod Kone
626/#comment245766>
Do you want to add some blurb to `upgrades.md` regarding the disruption and
link it from here?
Also would be nice to link the authentication and authorization docs here.
- Vinod Kone
On April 21, 2017, 7:16 p.m., Greg Mann
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58625/#review172712
---
Ship it!
Ship It!
- Vinod Kone
On April 21, 2017, 7:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58624/#review172711
---
Ship it!
Nice test.
- Vinod Kone
On April 21, 2017, 8:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58428/#review172687
---
Ship it!
Ship It!
- Vinod Kone
On April 19, 2017, 6:48 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58255/#review172686
---
Ship it!
Ship It!
- Vinod Kone
On April 19, 2017, 12:34 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58458/#review172296
---
Ship it!
Ship It!
- Vinod Kone
On April 14, 2017, 4:08 p.m
he.org/r/58428/#comment245400>
don't need terminate/wait slave here like the above test?
- Vinod Kone
On April 14, 2017, 9:18 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58258/#review172292
---
Ship it!
Ship It!
- Vinod Kone
On April 13, 2017, 8:19 p.m
tps://reviews.apache.org/r/58255/#comment245395>
Can you make the response status codes consistent or add a comment on why
they are inconsistent?
- Vinod Kone
On April 18, 2017, 7:58 p.m., Greg Mann wrote:
>
> ---
> This is an automati
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58254/#review172279
---
Ship it!
Ship It!
- Vinod Kone
On April 14, 2017, 9:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58507/#review172278
---
Ship it!
Ship It!
- Vinod Kone
On April 18, 2017, 3:19 p.m
), 249-250 (patched)
<https://reviews.apache.org/r/57815/#comment245193>
Hmm, I was hoping that we could re-use the `Call::Suppress` message here
instead of re-defining it. That way any changes to suppress would be in sync.
- Vinod Kone
On April 15, 2017, 6:40 a.m., Anindya Sinha
> On April 7, 2017, 1:58 a.m., Vinod Kone wrote:
> > src/checks/checker.cpp
> > Lines 1166-1169 (patched)
> > <https://reviews.apache.org/r/58196/diff/1/?file=1684610#file1684610line1166>
> >
> > It's a bit unfortunate that the `errno` returned by
> On April 7, 2017, 1:58 a.m., Vinod Kone wrote:
> > src/checks/checker.cpp
> > Lines 1081 (patched)
> > <https://reviews.apache.org/r/58196/diff/1/?file=1684610#file1684610line1081>
> >
> > Does this work even when executor is running with its own file
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58464/#review172105
---
Ship it!
Ship It!
- Vinod Kone
On April 17, 2017, 4:23 p.m
(patched)
<https://reviews.apache.org/r/58464/#comment245105>
Can you add a comment here for posterity on why you take a copy instead of
passing `authenticator`? Maybe reference MESOS-7065?
- Vinod Kone
On April 14, 2017, 11:22 p.m., Greg Mann
> On April 13, 2017, 12:21 a.m., Vinod Kone wrote:
> > src/master/allocator/mesos/allocator.hpp
> > Line 70 (original), 70-71 (patched)
> > <https://reviews.apache.org/r/57817/diff/3/?file=1684648#file1684648line70>
> >
> > This is making me think whet
: 1
No Python files to lint
```
- Vinod Kone
On April 13, 2017, 12:44 p.m., Andy Pang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58287/
> ---
13, 2017, 12:44 p.m., Andy Pang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58287/
> ---
>
> (Updated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58287/#review172017
---
Ship it!
Ship It!
- Vinod Kone
On April 13, 2017, 12:44 p.m
one arg per line.
src/master/detector/zookeeper.cpp
Lines 269 (patched)
<https://reviews.apache.org/r/58421/#comment245059>
one arg per line.
- Vinod Kone
On April 13, 2017, 3:44 p.m., Ilya Pronin wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58374/#review171960
---
Ship it!
Ship It!
- Vinod Kone
On April 12, 2017, 9:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58370/#review171959
---
Ship it!
Ship It!
- Vinod Kone
On April 12, 2017, 9:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58369/#review171958
---
Ship it!
Ship It!
- Vinod Kone
On April 13, 2017, 8:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58373/#review171955
---
Ship it!
Ship It!
- Vinod Kone
On April 12, 2017, 9:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58368/#review171954
---
Ship it!
Ship It!
- Vinod Kone
On April 12, 2017, 9:20 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58328/#review171953
---
Ship it!
Ship It!
- Vinod Kone
On April 13, 2017, 8:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58327/#review171952
---
Ship it!
Ship It!
- Vinod Kone
On April 13, 2017, 8:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58195/#review171834
---
Ship it!
Ship It!
- Vinod Kone
On April 4, 2017, 10:24 p.m
> On April 7, 2017, 1:09 a.m., Vinod Kone wrote:
> > include/mesos/mesos.proto
> > Lines 1773 (patched)
> > <https://reviews.apache.org/r/58195/diff/1/?file=1684601#file1684601line1773>
> >
> > `succeeded` seems a bit weird, can we call it `st
> On April 7, 2017, 12:31 a.m., Vinod Kone wrote:
> > src/tests/check_tests.cpp
> > Line 837 (original), 839 (patched)
> > <https://reviews.apache.org/r/58194/diff/1/?file=1684600#file1684600line839>
> >
> > Does this mean the test runs for atleast 1
(patched)
<https://reviews.apache.org/r/58263/#comment244848>
Can you elaborate how it is different?
src/slave/containerizer/mesos/containerizer.cpp
Lines 1492 (patched)
<https://reviews.apache.org/r/58263/#comment244849>
don't you need to checkpoint/recover this?
- Vinod
is empty at this point.
src/slave/containerizer/mesos/containerizer.cpp
Lines 1386-1389 (original), 1401-1404 (patched)
<https://reviews.apache.org/r/58262/#comment244846>
Previously debug containers had this set in the env as well? But not
anymore?
- Vinod Kone
On April
ve" and "offersSuppressed" booleans as far as the allocator is concerned.
Thoughts?
- Vinod Kone
On April 11, 2017, 11:10 p.m., Anindya Sinha wrote:
>
> ---
> This is an
tps://reviews.apache.org/r/57816/#comment244590>
i would name it "suppress_offers_on_registration"
src/sched/sched.cpp
Lines 826 (patched)
<https://reviews.apache.org/r/57816/#comment244591>
s/offersSuppressed/suppressOffers/
- Vinod Kone
On April 3, 2017, 10:34 p.m
)
<https://reviews.apache.org/r/57815/#comment244584>
Can we use an active word here, say "suppress_offers" or "suppress",
because our calls use active verbs? The way I see it, this is just a way of
sending SUBSCRIBE and SUPRESS calls atomically.
- Vinod Kone
O
Lines 6041-6042 (patched)
<https://reviews.apache.org/r/58320/#comment244572>
why is one a ref and not the other?
- Vinod Kone
On April 11, 2017, 4:46 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58321/#review171617
---
Ship it!
Ship It!
- Vinod Kone
On April 10, 2017, 8:40 p.m
)
<https://reviews.apache.org/r/58287/#comment244566>
can we do
```
<< "Failed to shutdown socket with fd " << socket.get()
<< ", address " << stringify(socket.address.get())
<< ": " << shutdown.error()
> On April 11, 2017, 12:27 a.m., Vinod Kone wrote:
> > src/authorizer/local/authorizer.cpp
> > Lines 725 (patched)
> > <https://reviews.apache.org/r/58254/diff/2/?file=1686563#file1686563line725>
> >
> > Is this based on the assumption that claims sub
src/tests/slave_authorization_tests.cpp
Lines 566 (patched)
<https://reviews.apache.org/r/58258/#comment244554>
why do you need to configure this?
- Vinod Kone
On April 7, 2017, 3:46 a.m., Greg Mann wrote:
>
> ---
> This is an automat
ws.apache.org/r/58255/#comment244547>
ditto. see above.
- Vinod Kone
On April 7, 2017, 3:45 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To re
well.
src/authorizer/local/authorizer.cpp
Lines 725 (patched)
<https://reviews.apache.org/r/58254/#comment29>
Is this based on the assumption that claims subjects only come from
executors and not operators? What guarantees that?
- Vinod Kone
On April 7, 2017, 11:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58253/#review171480
---
Ship it!
Ship It!
- Vinod Kone
On April 7, 2017, 3:33 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58252/#review171478
---
Ship it!
Ship It!
- Vinod Kone
On April 7, 2017, 11:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58251/#review171477
---
Ship it!
Ship It!
- Vinod Kone
On April 7, 2017, 3:26 a.m
6/#comment244202>
`has_succeeded` sounds weird here :) more reason to change the field name.
src/tests/check_tests.cpp
Lines 1913 (patched)
<https://reviews.apache.org/r/58196/#comment244203>
ditto.
- Vinod Kone
On April 4, 2017, 10:25 p.m., Alexander Rukletsov wrote:
>
nk.com/Documentation/Nexthink/V5.3/GlossaryAndReferences/StatusofTCPconnections
?
src/checks/checker.cpp
Line 341 (original)
<https://reviews.apache.org/r/58195/#comment244186>
why no space?
- Vinod Kone
On April 4, 2017, 10:24 p.m., Alexander Ruk
way? Maybe a
while loop that checks that the server is up or something?
- Vinod Kone
On April 4, 2017, 10:24 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57933/#review171300
---
Ship it!
Ship It!
- Vinod Kone
On April 5, 2017, 10:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58193/#review171297
---
Ship it!
Ship It!
- Vinod Kone
On April 4, 2017, 10:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58192/#review171296
---
Ship it!
Ship It!
- Vinod Kone
On April 4, 2017, 10:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58191/#review171295
---
Ship it!
Ship It!
- Vinod Kone
On April 4, 2017, 10:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58190/#review171294
---
Ship it!
Ship It!
- Vinod Kone
On April 4, 2017, 10:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57667/#review171293
---
Ship it!
Ship It!
- Vinod Kone
On April 5, 2017, 10:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57925/#review171292
---
Ship it!
Ship It!
- Vinod Kone
On April 5, 2017, 10:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57663/#review171032
---
Ship it!
Ship It!
- Vinod Kone
On March 23, 2017, 10:43 p.m
501 - 600 of 3244 matches
Mail list logo
