Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review112991 --- Ship it! - Joris Van Remoortere On Jan. 5, 2016, 6:25 p.m.,

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Dec. 22, 2015, 10:19 a.m.) Review request for mesos, Alexander

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Dec. 22, 2015, 9:40 a.m.) Review request for mesos, Alexander

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review111597 --- src/tests/master_quota_tests.cpp (line 578)

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review111508 --- Looks good. Some high-level comments: - You use `const`

Re: Review Request 39614: Quota: Added Status Validation Tests.

> On Dec. 22, 2015, 10:43 a.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 578 > > > > > > The ReviewBot is failing because `quotaResources` must be flattened. > > > > Also, why

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Dec. 22, 2015, 12:18 p.m.) Review request for mesos, Alexander

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review111612 --- Patch looks great! Reviews applied: [39492, 39614] Passed

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Dec. 21, 2015, 2:49 p.m.) Review request for mesos, Alexander

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Dec. 21, 2015, 5:13 p.m.) Review request for mesos, Alexander

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review108008 --- Please adjust the JIRA ticket: MESOS-4013. - Alexander Rukletsov

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Nov. 20, 2015, 10:05 a.m.) Review request for mesos, Alexander

Re: Review Request 39614: Quota: Added Status Validation Tests.

> On Oct. 25, 2015, 3:51 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, line 705 > > > > > > I see that most of the test cases are not using xx_xx to name the test > > function, can we rename

Re: Review Request 39614: Quota: Added Status Validation Tests.

> On Nov. 19, 2015, 1:55 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 724 > > > > > > I can't understand, why `quota` and not `guarantees`. What am I missing? The updated review :-).

Re: Review Request 39614: Quota: Added Status Validation Tests.

> On Nov. 6, 2015, 1:13 a.m., Joseph Wu wrote: > > src/tests/master_quota_tests.cpp, lines 732-734 > > > > > > Have you considered merging this test with > > `AvailableResourcesMultipleAgents`? > > Joerg Schad

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review107313 --- src/tests/master_quota_tests.cpp (line 482)

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review107187 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913,

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Nov. 19, 2015, 4:05 p.m.) Review request for mesos, Alexander

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review107181 --- src/tests/master_quota_tests.cpp (line 435)

Re: Review Request 39614: Quota: Added Status Validation Tests.

> On Nov. 19, 2015, 3:34 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 521 > > > > > > `protobuf::parse()` does not compile? No. - Joerg

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Nov. 19, 2015, 2:48 p.m.) Review request for mesos, Alexander

Re: Review Request 39614: Quota: Added Status Validation Tests.

> On Nov. 6, 2015, 1:13 a.m., Joseph Wu wrote: > > src/tests/master_quota_tests.cpp, lines 732-734 > > > > > > Have you considered merging this test with > > `AvailableResourcesMultipleAgents`? > > Joerg Schad

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review107169 --- src/tests/master_quota_tests.cpp (line 724)

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review107159 --- src/tests/master_quota_tests.cpp (line 701)

Re: Review Request 39614: Quota: Added Status Validation Tests.

> On Nov. 6, 2015, 1:13 a.m., Joseph Wu wrote: > > src/tests/master_quota_tests.cpp, lines 732-734 > > > > > > Have you considered merging this test with > > `AvailableResourcesMultipleAgents`? In my opinion it is

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review107203 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913,

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review105343 --- src/tests/master_quota_tests.cpp (lines 723 - 726)

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Oct. 24, 2015, 7:40 p.m.) Review request for mesos, Alexander

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review103907 --- Patch looks great! Reviews applied: [39317, 38218, 36913, 38059,

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review103933 --- src/tests/master_quota_tests.cpp (line 705)

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review103890 --- Patch looks great! Reviews applied: [39317, 38218, 36913, 38059,