Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 三月 11, 2016, 9:10 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2016-01-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 一月 16, 2016, 4:36 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2016-01-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 一月 8, 2016, 12:41 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 一月 7, 2016, 11:03 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2016-01-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/#review113154 --- Ship it! LGTM. - Joseph Wu On Jan. 1, 2016, 5:17 p.m., Guangya

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2016-01-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/#review113188 --- Ship it! Ship It! - Klaus Ma On Jan. 2, 2016, 9:17 a.m.,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2016-01-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/#review113189 --- please help to rebase :). - Klaus Ma On Jan. 2, 2016, 9:17

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2016-01-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 一月 2, 2016, 1:17 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十二月 30, 2015, 7:03 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated Dec. 14, 2015, 6:05 a.m.) Review request for mesos, Artem

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-11 Thread Joseph Wu
> On Dec. 3, 2015, 1:19 p.m., Joseph Wu wrote: > > It would be a good idea to start writing tests for each of these changes. > > You should probably do so in a new `master__test.cpp` file. > > > > We have tests for master flags like this: > >

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十二月 9, 2015, 1:05 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十二月 8, 2015, 11:53 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十二月 8, 2015, 11:55 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十二月 9, 2015, 3:23 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十二月 7, 2015, 2:54 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-06 Thread Guangya Liu
> On 十二月 3, 2015, 9:19 p.m., Joseph Wu wrote: > > It would be a good idea to start writing tests for each of these changes. > > You should probably do so in a new `master__test.cpp` file. > > > > We have tests for master flags like this: > >

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-03 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/#review108885 --- It would be a good idea to start writing tests for each of these

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated Dec. 3, 2015, 1:05 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-02 Thread Guangya Liu
> On Dec. 1, 2015, 1:03 a.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, line 96 > > > > > > Suggestion: rename the variable to `enableReservationOversubscription`. Done. > On Dec. 1, 2015, 1:03

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated Dec. 3, 2015, 1:01 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十二月 3, 2015, 4:35 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十二月 3, 2015, 2:33 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-11-30 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/#review108428 --- include/mesos/master/allocator.hpp (line 96)

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-11-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/#review108462 --- Bad patch! Reviews applied: [40339] Failed command: export

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-11-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十一月 24, 2015, 5:40 a.m.) Review request for mesos, Artem Harutyunyan,