Re: Review Request 41444: Cleaned up Authorizer interface.

> On Dec. 21, 2015, 3:20 p.m., Greg Mann wrote: > > include/mesos/authorizer/authorizer.hpp, lines 129-131 > > > > > > Though I know what you're saying here, this one sounds a bit confusing > > to me. I wonder if

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review112523 --- Ship it! Looks good enough to me. I'll fix these little things

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111867 --- Patch looks great! Reviews applied: [41444] Passed command:

Re: Review Request 41444: Cleaned up Authorizer interface.

> On Dec. 18, 2015, 12:42 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.hpp, line 144 > > > > > > s/reserve particular resources/reserve resources/ since the only values > > currently allowed for

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111845 --- Ship it! Awesome! Few minor tweaks and we can ship it!

Re: Review Request 41444: Cleaned up Authorizer interface.

> On Dec. 24, 2015, 10:47 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.hpp, line 42 > > > > > > "checked"? You mean, "the request could not be completed"? or "made" or > > "authorized"? I like

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/ --- (Updated Dec. 24, 2015, 3:32 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41444: Cleaned up Authorizer interface.

> On Dec. 24, 2015, 10:47 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.hpp, line 133 > > > > > > where did `framework_principal` come from? YOu only talk about "the > > framework principal" prior to

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111614 --- Patch looks great! Reviews applied: [41444] Passed command:

Re: Review Request 41444: Cleaned up Authorizer interface.

> On Dec. 21, 2015, 11:20 p.m., Greg Mann wrote: > > include/mesos/authorizer/authorizer.hpp, lines 129-131 > > > > > > Though I know what you're saying here, this one sounds a bit confusing > > to me. I wonder if

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/ --- (Updated Dec. 22, 2015, 1:53 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41444: Cleaned up Authorizer interface.

> On Dec. 21, 2015, 11:20 p.m., Greg Mann wrote: > > Thanks, this is a big improvement! Just a few small nits below: - Greg --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111542 --- Patch looks great! Reviews applied: [41444] Passed command:

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111528 --- Thanks, this is a big improvement!

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/ --- (Updated Dec. 21, 2015, 4:04 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41444: Cleaned up Authorizer interface.

> On Dec. 18, 2015, 8:42 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.hpp, line 66 > > > > > > s/on/of/ killed the entire phrase. - Alexander

Re: Review Request 41444: Cleaned up Authorizer interface.

> On Dec. 18, 2015, 8:42 a.m., Adam B wrote: > > Thank you for cleaning this up. It looked like an overwhelming amount of > > documentation for what is not really that complex of an API. It still looks > > a bit verbose/repetitive, so I've made some suggestions of what else to cut > > out. >

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/ --- (Updated Dec. 21, 2015, 3:42 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review59 --- Patch looks great! Reviews applied: [41444] Passed command:

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review42 --- Thank you for cleaning this up. It looked like an overwhelming