Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-24 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/ --- (Updated March 24, 2016, 8:35 a.m.) Review request for mesos and Adam B.

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-24 Thread Adam B
> On March 21, 2016, 1:35 a.m., Adam B wrote: > > Need to get rid of the unnecessary stringify/atof translation, but I like > > the new low-level registry Operation test. > > Yongqiao Wang wrote: > Adam, cloud you help to review and commit this patch firstly, then I will > update the all

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-24 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review125225 --- Fix it, then Ship it! Looks great! I'd move the weightInfo

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-22 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/ --- (Updated March 22, 2016, 7:22 a.m.) Review request for mesos and Adam B.

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review124531 --- Bad patch! Reviews applied: [44511, 41790, 44512, 43863, 41681]

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review124511 --- Need to get rid of the unnecessary stringify/atof translation,

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-14 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/ --- (Updated March 14, 2016, 1:51 p.m.) Review request for mesos and Adam B.

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-14 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/ --- (Updated March 14, 2016, 1:52 p.m.) Review request for mesos and Adam B.

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review123381 --- I like the test you have here as a higher-level integration test.

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review122722 --- Patch looks great! Reviews applied: [41681, 43863, 44512, 41790,

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-09 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/ --- (Updated March 9, 2016, 10:03 a.m.) Review request for mesos and Adam B.

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review122698 --- Can you please describe in your "Testing Done" section what the

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/ --- (Updated March 9, 2016, 6:34 a.m.) Review request for mesos and Adam B.

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review122528 --- Patch looks great! Reviews applied: [41681, 43863, 41790, 44511]