Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review154663 --- Ship it! Ship It! - Benjamin Mahler On Nov. 2, 2016, 7:26

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review154662 --- Ship it! Ship It! - Kevin Klues On Nov. 2, 2016, 7:26 a.m.,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated Nov. 2, 2016, 7:26 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated Nov. 1, 2016, 6:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated Oct. 31, 2016, 7:09 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated Oct. 24, 2016, 4:57 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 21, 2016, 9:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 21, 2016, 6:27 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 20, 2016, 10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review153020 --- src/slave/containerizer/docker.hpp (line 76)

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 14, 2016, 9:55 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 13, 2016, 10:13 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

> On 十月 12, 2016, 5:52 a.m., Guangya Liu wrote: > > src/tests/mock_docker.hpp, line 40 > > > > > > include `components.hpp` is good enough. Thanks! I'll test in my mac soon. - Yubo

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

> On 十月 9, 2016, 10:16 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.hpp, line 76 > > > > > > This will cause build failed on Mac OS as `NvidiaGpuAllocator` was only > > defined in linux > >

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review152273 --- I think that for `NvidiaGpuAllocator`, we can add `#ifdef` as

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review152132 --- Did you build on mac os? I think that the test will continue to

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 11, 2016, 8:16 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review151936 --- src/slave/containerizer/docker.hpp (line 76)

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 九月 22, 2016, 6:09 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 九月 20, 2016, 9:21 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 九月 19, 2016, 7:16 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

> On 八月 25, 2016, 5:29 p.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, lines 1275-1289 > > > > > > This should probably just be moved into the next patch since it doesn't > > really do much here

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review146814 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 20-25 > > > > > > What does adding all of these headers have to do with this patch? They > > may be needed, but I don't

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 八月 25, 2016, 9:38 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 20-25 > > > > > > What does adding all of these headers have to do with this patch? They > > may be needed, but I don't

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 20-25 > > > > > > What does adding all of these headers have to do with this patch? They > > may be needed, but I don't

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review146724 --- src/slave/containerizer/docker.hpp (lines 20 - 25)

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 八月 22, 2016, 10:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review146300 --- Fix it, then Ship it! src/tests/mesos.cpp (line 65)

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 八月 16, 2016, 10:17 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review145746 --- src/slave/containerizer/docker.cpp (line 1279)

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 八月 15, 2016, 7:24 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 八月 10, 2016, 10:34 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review145049 --- src/slave/containerizer/docker.hpp (line 283)

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 八月 5, 2016, 9:47 a.m.) Review request for mesos, Benjamin Mahler,