Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/ --- (Updated July 31, 2017, 2:37 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181813 --- Fix it, then Ship it! include/mesos/mesos.proto Line 2918

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/ --- (Updated July 29, 2017, 4:58 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181683 --- include/mesos/mesos.proto Lines 2920 (patched)

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/ --- (Updated July 25, 2017, 11:18 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181419 --- include/mesos/mesos.proto Lines 2921-2922 (patched)

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/ --- (Updated July 25, 2017, 6:01 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181195 --- Ship it! Ship It! - Qian Zhang On July 21, 2017, 7:57 a.m.,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 20, 2017, 6:43 p.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Line 2843 (original), 2922 (patched) > > > > > > Why is `value` an optional field? I think there have to a value for any > >

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 21, 2017, 1:43 a.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Line 2843 (original), 2922 (patched) > > > > > > Why is `value` an optional field? I think there have to a value for any > >

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 21, 2017, 1:43 a.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Line 2843 (original), 2922 (patched) > > > > > > Why is `value` an optional field? I think there have to a value for any > >

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 21, 2017, 1:43 a.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Line 2843 (original), 2922 (patched) > > > > > > Why is `value` an optional field? I think there have to a value for any > >

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 20, 2017, 8:27 a.m., Qian Zhang wrote: > > include/mesos/v1/mesos.proto > > Lines 2815 (patched) > > > > > > Why do we need this? I see `Entry.op` is a required field rather than > > an optional field,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 21, 2017, 9:43 a.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Line 2843 (original), 2922 (patched) > > > > > > Why is `value` an optional field? I think there have to a value for any > >

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 20, 2017, 1:27 a.m., Qian Zhang wrote: > > include/mesos/v1/mesos.proto > > Lines 2815 (patched) > > > > > > Why do we need this? I see `Entry.op` is a required field rather than > > an optional field,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 20, 2017, 6:43 p.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Line 2843 (original), 2922 (patched) > > > > > > Why is `value` an optional field? I think there have to a value for any > >

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 20, 2017, 4:27 p.m., Qian Zhang wrote: > > include/mesos/v1/mesos.proto > > Lines 2815 (patched) > > > > > > Why do we need this? I see `Entry.op` is a required field rather than > > an optional field,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181087 --- include/mesos/mesos.proto Line 2843 (original), 2922 (patched)

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/ --- (Updated July 20, 2017, 4:57 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 20, 2017, 4:27 p.m., Qian Zhang wrote: > > include/mesos/v1/mesos.proto > > Lines 2815 (patched) > > > > > > Why do we need this? I see `Entry.op` is a required field rather than > > an optional field,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 20, 2017, 1:27 a.m., Qian Zhang wrote: > > include/mesos/v1/mesos.proto > > Lines 2815 (patched) > > > > > > Why do we need this? I see `Entry.op` is a required field rather than > > an optional field,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181023 --- include/mesos/v1/mesos.proto Lines 2815 (patched)

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/ --- (Updated July 19, 2017, 5:17 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 19, 2017, 12:41 a.m., Qian Zhang wrote: > > I think you also need to make the change to `include/mesos/v1/mesos.proto`. good catch! - Gilbert --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 19, 2017, 12:02 p.m., Jie Yu wrote: > > include/mesos/mesos.proto > > Lines 1298 (patched) > > > > > > Can we re-use the existing `Device` in mesos.proto. I think we should > > make `path` optional. > >

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 18, 2017, 6:31 a.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Lines 2955 (patched) > > > > > > If we introduce a field like this, does that mean we will fill it in > >

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 19, 2017, 2:11 a.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Lines 1525 (patched) > > > > > > s/blkio/blkio_statistics/ to keep consistent with the field > > `disk_statistics`. +1 -

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review180958 --- include/mesos/mesos.proto Lines 1298 (patched)

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review180911 --- include/mesos/mesos.proto Lines 1525 (patched)

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review180907 --- I think you also need to make the change to

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 18, 2017, 9:31 p.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Lines 2886 (patched) > > > > > > Just curious, the reason that this is a `repeated` field is there are 5 > > operations

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 18, 2017, 6:31 a.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Lines 2886 (patched) > > > > > > Just curious, the reason that this is a `repeated` field is there are 5 > > operations

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 18, 2017, 6:31 a.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Lines 2950 (patched) > > > > > > Why do we need this msg? I do not see it is used anywhere. This was left by Jason. Should be

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review180794 --- include/mesos/mesos.proto Lines 2886 (patched)