Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review201935 --- Ship it! I'll fix up the last couple of nits as I commit. -

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On April 2, 2018, 8:30 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 420 (patched) > > > > > > What about `QuotaPolicy::ENFORCING_PASSIVE`? The monitoring loop should

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On March 27, 2018, 4:35 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Line 362 (original), 414 (patched) > > > > > > `needed` is still the allocated quota so you don't need

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated April 20, 2018, 6:48 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On March 27, 2018, 4:35 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 368 (patched) > > > > > > Move this into the case statement block. > > Harold Dost wrote: >

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On April 4, 2018, 6:06 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 544 (patched) > > > > > > I may be missing something here, why do you need this? Are you > >

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated April 18, 2018, 10:13 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On April 2, 2018, 8:30 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 393 (patched) > > > > > > This should be configurable. > > Harold Dost wrote: > So I had

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review200471 --- src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 398

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated April 4, 2018, 5:41 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On March 27, 2018, 4:35 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 368 (patched) > > > > > > Move this into the case statement block. So if I do that then I will

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On March 27, 2018, 4:35 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Line 362 (original), 414 (patched) > > > > > > `needed` is still the allocated quota so you don't need

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On April 2, 2018, 8:30 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Line 304 (original), 317-318 (patched) > > > > > > Keep `infos.contains(containerId)` check here.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On March 27, 2018, 9:35 a.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 420 (patched) > > > > > > It's unfortunately verbose, but we should do this: > > > >

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review200296 --- src/slave/containerizer/mesos/isolators/xfs/disk.cpp Line 304

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review25 --- src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 30

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 23, 2018, 4:13 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On March 22, 2018, 6:19 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 426 (patched) > > > > > > Document the invariants by adding > > ``` > >

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199778 --- src/slave/containerizer/mesos/isolators/xfs/disk.hpp Lines 77

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 22, 2018, 2:11 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 22, 2018, 7:43 a.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 20, 2018, 2:35 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199445 --- I've taken a first pass, but before we get into the details of

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199315 --- Patch looks great! Reviews applied: [66001] Passed command:

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199312 --- PASS: Mesos patch 66001 was successfully built and tested.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 16, 2018, 10:43 a.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199295 --- PASS: Mesos patch 66001 was successfully built and tested.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199292 --- Patch looks great! Reviews applied: [66001] Passed command:

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199270 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 15, 2018, 4:14 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199261 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 15, 2018, 1:48 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199257 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 15, 2018, 1:33 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199256 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 15, 2018, 1:27 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199092 --- Patch looks great! Reviews applied: [66001] Passed command:

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199087 --- PASS: Mesos patch 66001 was successfully built and tested.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 13, 2018, 1:45 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199014 --- PASS: Mesos patch 66001 was successfully built and tested.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review198969 --- Patch looks great! Reviews applied: [66000, 66001] Passed

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review198948 --- PASS: Mesos patch 66001 was successfully built and tested.