Re: Review Request 34631: Added QoS Controller.

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/ --- (Updated June 4, 2015, 2:23 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34631: Added QoS Controller.

2015-06-04 Thread Niklas Nielsen
On June 3, 2015, 4:02 p.m., Jie Yu wrote: include/mesos/slave/qos_controller.hpp, lines 25-26 https://reviews.apache.org/r/34631/diff/3/?file=977207#file977207line25 Can you add a wrapper header mesos/slave/oversubscription.hpp similar to what we do for things

Re: Review Request 34631: Added QoS Controller.

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/ --- (Updated June 4, 2015, 10:42 a.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34631: Added QoS Controller.

2015-06-03 Thread Bartek Plotka
On June 3, 2015, 5:54 p.m., Bartek Plotka wrote: include/mesos/slave/qos_controller.hpp, line 52 https://reviews.apache.org/r/34631/diff/3/?file=977207#file977207line52 Small thing: s/type/name/ ..to be consistent with allocator factory. (: What is the reason of

Re: Review Request 34631: Added QoS Controller.

2015-06-03 Thread Niklas Nielsen
On June 3, 2015, 10:54 a.m., Bartek Plotka wrote: include/mesos/slave/qos_controller.hpp, line 52 https://reviews.apache.org/r/34631/diff/3/?file=977207#file977207line52 Small thing: s/type/name/ ..to be consistent with allocator factory. (: What is the reason of

Re: Review Request 34631: Added QoS Controller.

2015-06-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review86499 --- Ship it! include/mesos/slave/qos_controller.hpp

Re: Review Request 34631: Added QoS Controller.

2015-06-03 Thread Niklas Nielsen
On June 3, 2015, 10:54 a.m., Bartek Plotka wrote: include/mesos/slave/qos_controller.hpp, line 52 https://reviews.apache.org/r/34631/diff/3/?file=977207#file977207line52 Small thing: s/type/name/ ..to be consistent with allocator factory. (: What is the reason of

Re: Review Request 34631: Added QoS Controller.

2015-06-03 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review86447 --- include/mesos/slave/qos_controller.hpp

Re: Review Request 34631: Added QoS Controller.

2015-06-02 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/ --- (Updated June 2, 2015, 9:26 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34631: Added QoS Controller.

2015-06-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review86004 --- Ship it! Ditto Vinod's comment on s/BE/revokable/

Re: Review Request 34631: Added QoS Controller.

2015-06-01 Thread Jie Yu
On May 29, 2015, 5:39 p.m., Vinod Kone wrote: include/mesos/slave/qos_controller.hpp, line 62 https://reviews.apache.org/r/34631/diff/2/?file=971661#file971661line62 s/QoSCorrection/listQoSCorrection/ ? Probably calling it 'correction' and returns a single QoSCorrection? Can you

Re: Review Request 34631: Added QoS Controller.

2015-05-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review85757 --- include/mesos/slave/qos_controller.hpp

Re: Review Request 34631: Added QoS Controller.

2015-05-26 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review85267 --- Ship it! Ship It! - Bartek Plotka On May 26, 2015, 3:30 p.m.,

Re: Review Request 34631: Added QoS Controller.

2015-05-26 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/ --- (Updated May 26, 2015, 8:30 a.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34631: Added QoS Controller.

2015-05-25 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review85150 --- include/mesos/slave/qos_controller.hpp