Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Jan. 14, 2016, 7:52 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review114561 --- Bad patch! Reviews applied: [38117] Failed command:

Re: Review Request 38117: Export per container SNMP statistics

> On Dec. 15, 2015, 9:18 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, lines > > 1131-1173 > > > > > > Can you please pull the parsing code out into a function and

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Jan. 5, 2016, 7:53 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review110563 --- Looks good, I just want to pull that parsing code out so it can be

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review110608 --- Patch looks great! Reviews applied: [38117] Passed command:

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Dec. 15, 2015, 12:05 a.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review109062 --- Patch looks great! Reviews applied: [38117] Passed command:

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Dec. 4, 2015, 7:18 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Dec. 4, 2015, 7:01 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review107482 --- Patch looks great! Reviews applied: [38117] Passed command:

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Nov. 20, 2015, 11:25 p.m.) Review request for mesos, Jie Yu, Paul

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Oct. 19, 2015, 6:49 p.m.) Review request for mesos, Jie Yu, Paul

Re: Review Request 38117: Export per container SNMP statistics

> On Oct. 16, 2015, 6 p.m., Ian Downes wrote: > > include/mesos/mesos.proto, lines 702-720 > > > > > > Are the statistics signed? If not, suggest using uint64 type. Yes, I used uint64 initially and then noticed

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review102933 --- include/mesos/mesos.proto (lines 702 - 720)

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Sept. 8, 2015, 9:12 p.m.) Review request for mesos, Jie Yu, Paul

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review98104 --- Patch looks great! Reviews applied: [38117] All tests passed. -

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review97870 --- src/slave/containerizer/isolators/network/port_mapping.cpp (line

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review97713 --- Patch looks great! Reviews applied: [38117] All tests passed. -