Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100171 --- src/linux/systemd.cpp (line 161)

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100290 --- Just some feedback on doxygen usage; trying to avoid comment bloat

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100306 --- src/slave/containerizer/linux_launcher.cpp (line 133)

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/ --- (Updated Sept. 23, 2015, 8:34 p.m.) Review request for mesos, Benjamin

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

> On Sept. 23, 2015, 8:52 a.m., Timothy Chen wrote: > > src/slave/containerizer/linux_launcher.cpp, line 117 > > > > > > How about we do what libprocess does where we initialize on each > > system:: call, and you

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/ --- (Updated Sept. 24, 2015, 3:41 a.m.) Review request for mesos, Benjamin

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/ --- (Updated Sept. 24, 2015, 3:52 a.m.) Review request for mesos, Benjamin

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

> On Sept. 23, 2015, 10:31 p.m., Kapil Arya wrote: > > src/slave/containerizer/linux_launcher.cpp, line 133 > > > > > > Do we want to ABORT, or return an Error here (and below)? Not sure, if > > we have a policy

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/ --- (Updated Sept. 24, 2015, 12:12 a.m.) Review request for mesos, Benjamin

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100332 --- Ship it! src/linux/systemd.hpp (lines 32 - 33)

Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

> On Sept. 23, 2015, 12:48 a.m., Niklas Nielsen wrote: > > src/slave/containerizer/linux_launcher.cpp, line 197 > > > > > > Wouldn't the idomatic way be to use stout's file abstractions? Which ones are you

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100109 --- src/slave/containerizer/linux_launcher.cpp (line 197)

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/ --- (Updated Sept. 23, 2015, 1:48 a.m.) Review request for mesos, Benjamin