Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

> On Nov. 11, 2015, 5:56 a.m., Ben Mahler wrote: > > support/apply-reviews.py, lines 158-164 > > > > > > The url added to the message here doesn't match the existing format > > used by apply-review.sh: > > > >

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review106053 --- support/apply-reviews.py (lines 148 - 154)

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 9, 2015, 6:18 a.m.) Review request for mesos, Benjamin Hindman, J

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 9, 2015, 2:57 a.m.) Review request for mesos, Benjamin Hindman, J

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 9, 2015, 12:29 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 4, 2015, 3 p.m.) Review request for mesos, Benjamin Hindman, Jori

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 4, 2015, 2:30 p.m.) Review request for mesos, Benjamin Hindman, J

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review104829 --- Ship it! Ship It! - Vinod Kone On Oct. 30, 2015, 8:54 a.m., Art

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review104828 --- support/apply-reviews.py (line 63)

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

> On Oct. 26, 2015, 4:22 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 79 > > > > > > s/options/dry_run/ > > > > you can generalize it to 'options' later if there is a need for it. I made `optio

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 30, 2015, 1:54 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

> On Oct. 26, 2015, 4:22 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 123 > > > > > > do you still need this if it's already in the atexit handler? I do, because atexit is called only once (for the las

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 28, 2015, 3:01 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review104106 --- support/apply-reviews.py (line 41)

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review104098 --- support/apply-reviews.py (line 18)

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review103778 --- Ship it! Ship It! - Marco Massenzio On Oct. 23, 2015, 6:18 a.m.

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 22, 2015, 11:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 20, 2015, 12:42 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 18, 2015, 3:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 17, 2015, 7:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102925 --- Patch looks great! Reviews applied: [38705, 38883] All tests pass

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

> On Oct. 16, 2015, 4:15 p.m., Marco Massenzio wrote: > > Ship It! > > Marco Massenzio wrote: > Thanks for addressing comments! hey, minor nit: I've just noticed you insert whitespaces around named args: ``` "".format(url = USER_URL, user = username) ``` PEP8[0] requires that there are

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

> On Oct. 16, 2015, 4:15 p.m., Marco Massenzio wrote: > > Ship It! Thanks for addressing comments! - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102921

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102921 --- Ship it! Ship It! - Marco Massenzio On Oct. 16, 2015, 3:29 p.m.

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

> On Oct. 14, 2015, 4:45 p.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 40 > > > > > > (setting aside for a second that we should use `requests.get()` instead > > :) > > > > can you please t

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 16, 2015, 8:29 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102904 --- Bad patch! Reviews applied: [38705, 38883] Failed command: ./supp

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

> On Oct. 14, 2015, 9:45 a.m., Marco Massenzio wrote: > > Again lots of nit-picking, feel free to ignore what you disagree with > > strongly :) > > > > Also, instead of using your homemade `shell()` method and `Subprocess`, > > given the usage pattern I've noticed, you may want to consider the

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 16, 2015, 12:03 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102624 --- Again lots of nit-picking, feel free to ignore what you disagree wi

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102039 --- Ship it! Ship It! - Guangya Liu On 十月 8, 2015, 6:28 p.m., Artem

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102000 --- Patch looks great! Reviews applied: [38705, 38883] All tests pass

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 8, 2015, 11:28 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review101146 --- Patch looks great! Reviews applied: [38705, 38883] All tests pass

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Sept. 30, 2015, 11:21 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review101131 --- Preliminary review. support/apply-reviews.py (line 27)

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review101092 --- Patch looks great! Reviews applied: [38705, 38883] All tests pass

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Sept. 29, 2015, 11:18 p.m.) Review request for mesos, Benjamin Hindman

Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, and