Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

> On Oct. 9, 2015, 8:12 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioner/docker/spec.hpp, line 22 > > > > > > Do we need this ? If not, remove this include. > > Gilbert Song wrote: > Ditto. It

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

> On Oct. 9, 2015, 1:12 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioner/docker/spec.hpp, line 18 > > > > > > We generally prefer header files that are `complete` i.e. they compile > > on their own

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/ --- (Updated Oct. 9, 2015, 2:39 p.m.) Review request for mesos, Jojy Varghese and T

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review102105 --- LGTM, Just some minor comments/concerns about including `headers` t

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review102103 --- Ship it! Ship It! src/tests/containerizer/provisioner_docker_tes

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/ --- (Updated Oct. 7, 2015, 11:57 a.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/ --- (Updated Oct. 6, 2015, 10:29 a.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review101553 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 357)

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review101533 --- src/slave/containerizer/provisioner/docker/message.proto (line 79)

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/ --- (Updated Oct. 5, 2015, 12:21 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/ --- (Updated Oct. 5, 2015, 12:14 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

> On Oct. 2, 2015, 3:38 p.m., Timothy Chen wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 361 > > > > > > What's invalid about this JSON? Because we have to make sure that we have at least one

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review101387 --- src/slave/containerizer/provisioner/docker/spec.hpp (line 37)

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/ --- (Updated Oct. 2, 2015, 1:10 p.m.) Review request for mesos, Jojy Varghese and T

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review101197 --- src/slave/containerizer/provisioner/docker/message.proto (line 69)

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review101156 --- Patch looks great! Reviews applied: [38901] All tests passed. -

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review101139 --- src/Makefile.am (line 537)

Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/ --- Review request for mesos, Jojy Varghese and Timothy Chen. Bugs: MESOS-2972