Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review107563 --- src/master/allocator/mesos/hierarchical.hpp (line 391)

Re: Review Request 39400: Quota: Implemented quota API.

> On Nov. 23, 2015, 8:07 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 391 > > > > > > For this newly added member `quotaRoleSorter`, I think we also need to > > initialize it in the

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review107517 --- Ship it! src/master/allocator/mesos/hierarchical.cpp (lines 152

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review107194 --- src/master/allocator/mesos/hierarchical.hpp (line 390)

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/ --- (Updated Nov. 11, 2015, 10:29 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39400: Quota: Implemented quota API.

> On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 925 > > > > > > Do you want to -symetrically to your todu when setting quota- print the > > actual quota

Re: Review Request 39400: Quota: Implemented quota API.

> On Nov. 10, 2015, 10:09 a.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 140 > > > > > > Maybe s/Introduce/Consider introducing/ > > Are we sure we want to do this? A

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/ --- (Updated Nov. 10, 2015, 11:06 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39400: Quota: Implemented quota API.

> On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 359 > > > > > > s/the/this Re-phrasing it a bit deeper. > On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote: >

Re: Review Request 39400: Quota: Implemented quota API.

> On Oct. 25, 2015, 9:06 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 903 > > > > > > I see that in the code, some are using > > > > '" << xxx << "'"; > > > >

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review105817 --- src/master/allocator/mesos/hierarchical.hpp (line 358)

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review105816 --- src/master/allocator/mesos/hierarchical.hpp (line 358)

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review105575 --- Ship it! Ship It! - Klaus Ma On Nov. 6, 2015, 2:25 a.m.,

Re: Review Request 39400: Quota: Implemented quota API.

> On Oct. 28, 2015, 8:54 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 903 > > > > > > Alex, just want to get more for why do we need to add '' for role? I > > know that role is

Re: Review Request 39400: Quota: Implemented quota API.

> On Oct. 28, 2015, 8:54 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 903 > > > > > > Alex, just want to get more for why do we need to add '' for role? I > > know that role is

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review104515 --- Ship it! Ship It! - Guangya Liu On Oct. 27, 2015, 7:17 p.m.,

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review104265 --- src/master/allocator/mesos/hierarchical.cpp (line 902)

Re: Review Request 39400: Quota: Implemented quota API.

> On Oct. 26, 2015, 6:52 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 897 > > > > > > I think we are not *moving" the role into the quota'ed role sorter, > > instead, we are adding

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/ --- (Updated Oct. 27, 2015, 7:17 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39400: Quota: Implemented quota API.

> On 十月 25, 2015, 9:06 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 903 > > > > > > I see that in the code, some are using > > > > '" << xxx << "'"; > > > > while

Re: Review Request 39400: Quota: Implemented quota API.

> On Oct. 25, 2015, 9:06 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 903 > > > > > > I see that in the code, some are using > > > > '" << xxx << "'"; > > > >

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review103946 --- src/master/allocator/mesos/hierarchical.cpp (line 902)

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/ --- (Updated Oct. 23, 2015, 4:38 p.m.) Review request for mesos, Bernd Mathiske,