Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

> On Oct. 30, 2015, 2:16 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.cpp, line 190 > > > > > > OK, this is problematic and almost caused us an incident at Twitter. > > > > Mesos is able to

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

> On Oct. 30, 2015, 9:16 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.cpp, line 190 > > > > > > OK, this is problematic and almost caused us an incident at Twitter. > > > > Mesos is able to

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review104619 --- src/slave/containerizer/linux_launcher.cpp (line 190)

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

> On Oct. 26, 2015, 11:55 a.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.hpp, line 39 > > > > > > Cna you rename it to 'available'? We tend to omit 'is' or 'are' for > > those functions (e.g., cgroups

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

> On Oct. 26, 2015, 6:55 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.hpp, line 39 > > > > > > Cna you rename it to 'available'? We tend to omit 'is' or 'are' for > > those functions (e.g., cgroups:

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review104064 --- Ship it! Thanks! src/slave/containerizer/linux_launcher.hpp (lin

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/ --- (Updated Oct. 23, 2015, 4:48 p.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review103880 --- src/slave/containerizer/linux_launcher.cpp (line 181)

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

> On Oct. 23, 2015, 11:18 p.m., Till Toenshoff wrote: > > src/slave/containerizer/linux_launcher.cpp, lines 187-190 > > > > > > It is pretty well readable already, hence this point is VERY minor... > > > > I

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review103875 --- src/slave/containerizer/linux_launcher.cpp (lines 187 - 190)

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/ --- (Updated Oct. 23, 2015, 3:21 p.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review103872 --- Ship it! Ship It! - Kapil Arya On Oct. 23, 2015, 5:58 p.m., Art

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/ --- (Updated Oct. 23, 2015, 2:58 p.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/ --- (Updated Oct. 23, 2015, 2:35 p.m.) Review request for mesos, Ben Mahler, Joris

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

> On Oct. 23, 2015, 11:42 a.m., Neil Conway wrote: > > src/slave/containerizer/linux_launcher.cpp, line 189 > > > > > > You could simplify this to "return freezer.isSome();". Clearly more > > concise; debatable whet

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/ --- (Updated Oct. 23, 2015, 11:50 a.m.) Review request for mesos, Ben Mahler, Joris