Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 25, 2015, 5:01 a.m., Michael Park wrote: > > src/master/http.cpp, lines 541-551 > > > > > > As far as its implementation, let's do: > > > > ```cpp > > static Resources removeDisks(Resources

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 26, 2015, 9:26 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 26, 2015, 10:42 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review108181 --- src/Makefile.am (line 1708)

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review108180 --- Submitted with the following minor changes. src/master/http.cpp

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 25, 2015, 5:01 a.m., Michael Park wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, lines 159-162 > > > > > > I would suggest that we reorder these since we expect `registered` to > > occur

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 25, 2015, 10:21 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 25, 2015, 5:01 a.m., Michael Park wrote: > > src/master/http.cpp, lines 541-551 > > > > > > As far as its implementation, let's do: > > > > ```cpp > > static Resources removeDisks(Resources

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107913 --- Ship it! Looks good overall! Some nit-picks, some thoughts on

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107637 --- Patch looks great! Reviews applied: [40242, 40243, 40244, 40245,

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 23, 2015, 1:35 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 541 > > > > > > Can you please add some comments here to clarify why need this? > > Guangya Liu wrote: > Another point is that can

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On 十一月 23, 2015, 1:35 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 541 > > > > > > Can you please add some comments here to clarify why need this? > > Guangya Liu wrote: > Another point is that can

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On 十一月 19, 2015, 3:14 a.m., Guangya Liu wrote: > > docs/persistent-volume.md, line 258 > > > > > > I think that the http endpoint should also works without autherization, > > for such case, the principal and

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 23, 2015, 11:44 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107584 --- Patch looks great! Reviews applied: [40242, 40243, 40244, 40245,

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107718 --- Ship it! Ship It! - Greg Mann On Nov. 23, 2015, 5:06 p.m.,

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On 十一月 23, 2015, 1:35 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 541 > > > > > > Can you please add some comments here to clarify why need this? > > Guangya Liu wrote: > Another point is that can

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 23, 2015, 5:06 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 19, 2015, 7:09 p.m., Michael Park wrote: > > docs/persistent-volume.md, lines 255-280 > > > > > > This looks to be formatted weird, could you double check? Here and below > > Neil Conway wrote: > I

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On 十一月 23, 2015, 1:35 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 541 > > > > > > Can you please add some comments here to clarify why need this? Another point is that can we set this as a helper

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107531 --- docs/persistent-volume.md (line 236)

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 19, 2015, 7:09 p.m., Michael Park wrote: > > docs/persistent-volume.md, lines 255-280 > > > > > > This looks to be formatted weird, could you double check? Here and below I previewed with

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 20, 2015, 10:32 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 19, 2015, 7:09 p.m., Michael Park wrote: > > src/master/http.cpp, line 612 > > > > > > The `volumes.flatten()` here looks incorrect to me. For `/reserve`, we > > call `flatten` since the `required`

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107477 --- Patch looks great! Reviews applied: [40242, 40243, 40244, 40245,

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review106966 --- docs/persistent-volume.md (lines 255 - 280)

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 18, 2015, 11:28 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107022 --- Patch looks great! Reviews applied: [40242, 40243, 40244, 40245,

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107121 --- docs/persistent-volume.md (line 258)

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review106413 --- Patch looks great! Reviews applied: [40242, 40243, 40244, 40245,

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 13, 2015, 12:47 p.m.) Review request for mesos, Greg Mann and

Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- Review request for mesos, Greg Mann and Michael Park. Bugs: MESOS-2455

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review106294 --- Patch looks great! Reviews applied: [40242, 40243, 40244, 40245,