Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review127624 --- Ship it! Ship It! - Jie Yu On March 31, 2016, 11:17 a.m.,

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 31, 2016, 11:17 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review126081 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review126059 --- Fix it, then Ship it! Ship It! src/docker/docker.cpp (line

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review126057 --- Fix it, then Ship it! Ship It! src/docker/docker.cpp (lines

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 30, 2016, 7:52 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 42516: Add support for user-defined networks.

> On March 29, 2016, 6:01 p.m., Avinash sridharan wrote: > > src/docker/docker.cpp, line 568 > > > > > > Maybe s/ Found .../Found multiple networks specified for this > > container. We can only attach docker

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125997 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125921 --- src/docker/docker.cpp (line 568)

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 29, 2016, 4:33 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:13 p.m., Avinash sridharan wrote: > > src/docker/docker.cpp, line 562 > > > > > > We should make sure the user is not trying to specify more than one > > network for this container

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:13 p.m., Avinash sridharan wrote: > > src/docker/docker.cpp, line 562 > > > > > > We should make sure the user is not trying to specify more than one > > network for this container

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:13 p.m., Avinash sridharan wrote: > > src/docker/docker.cpp, line 562 > > > > > > We should make sure the user is not trying to specify more than one > > network for this container

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 29, 2016, 11:08 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 42516: Add support for user-defined networks.

> On March 29, 2016, 8:54 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 567 > > > > > > Can you please add some comments here: If there are multiple network > > infos, the docker containerizer will only

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 29, 2016, 10:46 a.m.) Review request for mesos and Timothy

Re: Review Request 42516: Add support for user-defined networks.

> On 三月 29, 2016, 8:54 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 567 > > > > > > Can you please add some comments here: If there are multiple network > > infos, the docker containerizer will only

Re: Review Request 42516: Add support for user-defined networks.

> On March 29, 2016, 8:54 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 567 > > > > > > Can you please add some comments here: If there are multiple network > > infos, the docker containerizer will only

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125841 --- src/docker/docker.cpp (line 567)

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:13 p.m., Avinash sridharan wrote: > > src/docker/docker.cpp, line 562 > > > > > > We should make sure the user is not trying to specify more than one > > network for this container

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 29, 2016, 8:34 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42516: Add support for user-defined networks.

> On March 29, 2016, 7:51 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 553-572 > > > > > > I prefer the following format: > > > > case ContainerInfo::DockerInfo::USER: { > > // User

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125835 --- src/docker/docker.cpp (lines 553 - 572)

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 29, 2016, 7:31 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:13 p.m., Avinash sridharan wrote: > > src/docker/docker.cpp, line 562 > > > > > > We should make sure the user is not trying to specify more than one > > network for this container

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125790 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:43 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 554-572 > > > > > > 2 spaces indent, you can take > > https://github.com/apache/mesos/blob/master/src/master/http.cpp#L482 as >

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:43 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 554-572 > > > > > > 2 spaces indent, you can take > > https://github.com/apache/mesos/blob/master/src/master/http.cpp#L482 as >

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:43 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 554-572 > > > > > > 2 spaces indent, you can take > > https://github.com/apache/mesos/blob/master/src/master/http.cpp#L482 as >

Re: Review Request 42516: Add support for user-defined networks.

> On 三月 28, 2016, 3:43 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 554-572 > > > > > > 2 spaces indent, you can take > > https://github.com/apache/mesos/blob/master/src/master/http.cpp#L482 as > >

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:43 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 554-572 > > > > > > 2 spaces indent, you can take > > https://github.com/apache/mesos/blob/master/src/master/http.cpp#L482 as >

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125645 --- src/docker/docker.cpp (lines 554 - 572)

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125635 --- src/docker/docker.cpp (line 555)

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 28, 2016, 10:51 a.m.) Review request for mesos and Timothy

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review119730 --- include/mesos/v1/mesos.proto (lines 1543 - 1544)

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review119315 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Feb. 16, 2016, 12:39 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 16, 2016, 4:04 a.m., Timothy Chen wrote: > > Thinking about it a bit more I think it's fine without a unit test as it > > requires docker network create. Did you test this manually and made sure it > > worked? > > Once you update the comments I can merge it. I fixed all the typos

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review119266 --- Thinking about it a bit more I think it's fine without a unit

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review119265 --- include/mesos/v1/mesos.proto (line 1534)

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 12, 2016, 3:25 p.m., Travis Hegner wrote: > > Please have a look at https://reviews.apache.org/r/43093/. Should these > > patches be combined, or worked on together? Adding support for user defined > > networks, should also include support for proper IP address detection via > >

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 12, 2016, 3:25 p.m., Travis Hegner wrote: > > Please have a look at https://reviews.apache.org/r/43093/. Should these > > patches be combined, or worked on together? Adding support for user defined > > networks, should also include support for proper IP address detection via > >

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review119031 --- Please have a look at https://reviews.apache.org/r/43093/. Should

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 12, 2016, 3:25 p.m., Travis Hegner wrote: > > Please have a look at https://reviews.apache.org/r/43093/. Should these > > patches be combined, or worked on together? Adding support for user defined > > networks, should also include support for proper IP address detection via > > those

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118840 --- src/docker/docker.cpp (line 529)

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 11, 2016, 9:34 a.m., Klaus Ma wrote: > > src/docker/docker.cpp, line 529 > > > > > > Also check whether `network_name()` is empty string `""`. > > Ezra Silvera wrote: > I think we already covered this

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 11, 2016, 9:34 a.m., Klaus Ma wrote: > > src/docker/docker.cpp, line 529 > > > > > > Also check whether `network_name()` is empty string `""`. > > Ezra Silvera wrote: > I think we already covered this

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 11, 2016, 9:34 a.m., Klaus Ma wrote: > > src/docker/docker.cpp, line 529 > > > > > > Also check whether `network_name()` is empty string `""`. I think we already covered this issue in previous review

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Feb. 11, 2016, 1:51 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118871 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Feb. 11, 2016, 1:14 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 11, 2016, 5:34 p.m., Klaus Ma wrote: > > src/docker/docker.cpp, line 529 > > > > > > Also check whether `network_name()` is empty string `""`. > > Ezra Silvera wrote: > I think we already covered this

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 10, 2016, 1:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 526 > > > > > > I prefer that we use "higher than" or "greater than" instead of ">=", > > we can wait for the comments from Tim. > >

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 10, 2016, 1:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 526 > > > > > > I prefer that we use "higher than" or "greater than" instead of ">=", > > we can wait for the comments from Tim.

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 10, 2016, 1:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 526 > > > > > > I prefer that we use "higher than" or "greater than" instead of ">=", > > we can wait for the comments from Tim. >

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 10, 2016, 1:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 526 > > > > > > I prefer that we use "higher than" or "greater than" instead of ">=", > > we can wait for the comments from Tim. >

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 10, 2016, 1:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 526 > > > > > > I prefer that we use "higher than" or "greater than" instead of ">=", > > we can wait for the comments from Tim. > >

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118708 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118616 --- Ship it! Ship It! - haosdent huang On Feb. 10, 2016, 8:34

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Feb. 10, 2016, 8:34 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118633 --- src/docker/docker.cpp (line 526)

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 10, 2016, 1:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 526 > > > > > > I prefer that we use "higher than" or "greater than" instead of ">=", > > we can wait for the comments from Tim. > >

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 9, 2016, 2:17 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 525 > > > > > > Can you put a more elaborate message here? > > i.e: "User network mode requires Docker version higher than

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Feb. 9, 2016, 7:25 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118476 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118586 --- src/docker/docker.cpp (line 521)

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118349 --- src/docker/docker.cpp (line 525)

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review117409 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Feb. 2, 2016, 1:53 p.m.) Review request for mesos and TimothyIL

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Feb. 2, 2016, 1:57 p.m.) Review request for mesos and TimothyIL

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review117168 --- src/docker/docker.cpp (lines 517 - 522)

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review117169 --- BTW: I think that you meant to have tim Chen as shephard, his id

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review116567 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

> On Jan. 24, 2016, 6:58 a.m., Shuai Lin wrote: > > src/docker/docker.cpp, line 519 > > > > > > typo, s/sempty/empty :) good catch. thanks :-) - Ezra ---

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Jan. 27, 2016, 7:05 a.m.) Review request for mesos and TimothyIL

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115984 --- src/docker/docker.cpp (line 517)

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review116005 --- Fix it, then Ship it! src/docker/docker.cpp (line 518)

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Jan. 23, 2016, 8:45 p.m.) Review request for mesos and TimothyIL

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review116001 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Jan. 24, 2016, 6:42 a.m.) Review request for mesos and TimothyIL

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review116010 --- Fix it, then Ship it! src/docker/docker.cpp (line 519)

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review116012 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115542 --- src/docker/docker.cpp (line 517)

Re: Review Request 42516: Add support for user-defined networks.

> On Jan. 20, 2016, 7:41 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 539-541 > > > > > > I think that you may also want some test cases to verify port mapping > > plus user defined network. We agree

Re: Review Request 42516: Add support for user-defined networks.

> On 一月 19, 2016, 11:29 p.m., Guangya Liu wrote: > > A unit test also needed, please refer to > > https://github.com/apache/mesos/blob/master/src/tests/containerizer/docker_containerizer_tests.cpp#L297 > > for detail > > Ezra Silvera wrote: > Thanks. I'll have a look. We will probably

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115526 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Jan. 20, 2016, 12:25 p.m.) Review request for mesos and TimothyIL

Re: Review Request 42516: Add support for user-defined networks.

> On Jan. 19, 2016, 11:29 p.m., Guangya Liu wrote: > > A unit test also needed, please refer to > > https://github.com/apache/mesos/blob/master/src/tests/containerizer/docker_containerizer_tests.cpp#L297 > > for detail > > Ezra Silvera wrote: > Thanks. I'll have a look. We will probably

Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- Review request for mesos and TimothyIL TimothyIL. Bugs: MESOS-4369

Re: Review Request 42516: Add support for user-defined networks.

> On Jan. 19, 2016, 11:29 p.m., Guangya Liu wrote: > > A unit test also needed, please refer to > > https://github.com/apache/mesos/blob/master/src/tests/containerizer/docker_containerizer_tests.cpp#L297 > > for detail Thanks. I'll have a look. We will probably need to add support for "create

Re: Review Request 42516: Add support for user-defined networks.

> On 一月 19, 2016, 11:29 p.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 1469 > > > > > > What about name it as OVERLAY? > > Ezra Silvera wrote: > We choose USER because it is defined by Docker as

  1   2   >