Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review124836 --- Fix it, then Ship it! Looks good! I'll make some minor

Re: Review Request 43884: Added allocator metrics for used quotas.

> On March 17, 2016, 9:07 p.m., Ben Mahler wrote: > > docs/monitoring.md, lines 876-883 > > > > > > Thanks! How about: > > > > ``` > > > > > > allocator/mesos/quota//_allocated > >

Re: Review Request 43884: Added allocator metrics for used quotas.

> On March 17, 2016, 9:07 p.m., Ben Mahler wrote: > > docs/monitoring.md, lines 876-883 > > > > > > Thanks! How about: > > > > ``` > > > > > > allocator/mesos/quota//_allocated > >

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review124061 --- Thanks Benjamin! The main higher level suggestion here is to add

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 18, 2016, 5:08 p.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 15, 2016, 3:51 p.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

> On March 4, 2016, 1:46 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 75 > > > > > > two spaces > > Benjamin Bannier wrote: > I might be wrong, but don't we indent by four

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review14 --- src/master/allocator/mesos/metrics.hpp (line 98)

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review122151 --- Patch looks great! Reviews applied: [44070, 44071, 44073, 44260,

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 4, 2016, 5:01 p.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

> On March 4, 2016, 2:46 p.m., Alexander Rukletsov wrote: > > docs/monitoring.md, line 905 > > > > > > In the same vein as `allocator/allocated/KIND`, this should be > > something like

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review122057 --- docs/monitoring.md (line 905)

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 3, 2016, 2:11 p.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121685 --- Patch looks great! Reviews applied: [44070, 44071, 44073, 44260,

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 2, 2016, 11:54 a.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

> On March 1, 2016, 1:19 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 303 > > > > > > I'm even wondering whether `auto` here is a better idea than aliasing. Of the two possible

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 2, 2016, 11:34 a.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121366 --- src/master/allocator/mesos/hierarchical.hpp (line 302)

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121310 --- Bad review! Reviews applied: [43884, 43883, 43882, 43881, 43880,

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 29, 2016, 8:59 p.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121166 --- Bad review! Reviews applied: [43884, 43883, 43882, 43881, 43880,

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 28, 2016, 10:31 p.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121149 --- src/master/allocator/mesos/hierarchical.hpp (line 389)

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review120909 --- Bad review! Reviews applied: [43884, 43883, 43882, 43881, 43880,

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 26, 2016, 6 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review120740 --- Bad patch! Reviews applied: [43884, 43883, 43882, 43881, 43880,

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 25, 2016, 12:01 p.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review120506 --- Patch looks great! Reviews applied: [43879, 43880, 43881, 43882,

Re: Review Request 43884: Added allocator metrics for used quotas.

> On 二月 24, 2016, 1:26 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1077-1080 > > > > > > I think that we cannot say that the quota here is satisfied, but those > > are just

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 24, 2016, 2:49 p.m.) Review request for mesos, Alexander