Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review135504 --- Patch looks great! Reviews applied: [46373] Passed command:

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-30 Thread zhou xing
> On 五月 29, 2016, 1:36 a.m., Vinod Kone wrote: > > src/files/files.cpp, line 374 > > > > > > Can we fix the pailer to not send -1 length in a follow up patch? yes, will submit a patch then - zhou

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-28 Thread Vinod Kone
> On May 29, 2016, 1:36 a.m., Vinod Kone wrote: > > Can you rebased this? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review135408

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review135408 --- Ship it! src/files/files.cpp (line 374)

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review133742 --- Patch looks great! Reviews applied: [46373] Passed command:

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-17 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/ --- (Updated 五月 18, 2016, 4:13 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-17 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/ --- (Updated 五月 18, 2016, 4:07 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review133690 --- src/files/files.cpp (lines 374 - 376)

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review133502 --- Patch looks great! Reviews applied: [46373] Passed command:

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-16 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/ --- (Updated 五月 17, 2016, 5:29 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review132042 --- Patch looks great! Reviews applied: [46373] Passed command:

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-05 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/ --- (Updated 五月 6, 2016, 5:08 a.m.) Review request for mesos, Ben Mahler and Greg

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review130883 --- Patch looks great! Reviews applied: [46373] Passed command:

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-27 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/ --- (Updated 四月 28, 2016, 2:15 a.m.) Review request for mesos, Ben Mahler and Greg

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review130864 --- Fix it, then Ship it! Looks great! Just a couple small

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review130575 --- Patch looks great! Reviews applied: [46373] Passed command:

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-26 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/ --- (Updated 四月 26, 2016, 8:15 a.m.) Review request for mesos, Ben Mahler and Greg

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review130342 --- src/files/files.cpp (line 362)

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review129748 --- Patch looks great! Reviews applied: [46373] Passed command:

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-19 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/ --- (Updated 四月 20, 2016, 5:57 a.m.) Review request for mesos, Ben Mahler and Greg

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review129620 --- src/files/files.cpp (line 380)

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review129528 --- Patch looks great! Reviews applied: [46373] Passed command:

Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-19 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/ --- Review request for mesos, Ben Mahler and Greg Mann. Bugs: mesos-5060